Code review comment for lp:~mattrae/charm-helpers/lp1635067

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Thanks Matt! A few comments inline to consider, nothing too major though.

On the unit test front, if you're adding a new method you should have some sort of coverage. I think if you look at my suggestion on the use of glob you'll find the unit test much easier to write. All you'll need to do for that is to verify that it returns True when the bridge test criteria are met and False when its not.

review: Needs Fixing

« Back to merge proposal