Merge lp:~mattrae/charm-helpers/lp1635067 into lp:charm-helpers
Proposed by
Matt Rae
Status: | Merged |
---|---|
Merged at revision: | 706 |
Proposed branch: | lp:~mattrae/charm-helpers/lp1635067 |
Merge into: | lp:charm-helpers |
Diff against target: |
104 lines (+69/-1) 2 files modified
charmhelpers/contrib/network/ovs/__init__.py (+49/-1) tests/contrib/network/test_ovs.py (+20/-0) |
To merge this branch: | bzr merge lp:~mattrae/charm-helpers/lp1635067 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jorge Niedbalski (community) | Approve | ||
Matt Rae (community) | Needs Resubmitting | ||
James Page | Needs Fixing | ||
Billy Olsen | Needs Fixing | ||
Edward Hope-Morley | Pending | ||
Review via email: mp+314759@code.launchpad.net |
This proposal supersedes a proposal from 2017-01-09.
Description of the change
Adding functions to create an ovs bridge and check if an interface is a linux bridge.
This is needed in charm-helpers in order to add support for using a linuxbridge bridge in data-port config of neutron-gateway and neutron-openvswitch charms, such as 'juju set neutron-openvswitch data-port=
To post a comment you must log in.
LGTM, however I am missing unit tests for the change.