Merge lp:~matsubara/launchpad/772016-mailinglist-help into lp:launchpad

Proposed by Diogo Matsubara
Status: Merged
Approved by: Diogo Matsubara
Approved revision: no longer in the source branch.
Merged at revision: 13340
Proposed branch: lp:~matsubara/launchpad/772016-mailinglist-help
Merge into: lp:launchpad
Diff against target: 40 lines (+9/-5)
2 files modified
lib/lp/registry/stories/mailinglists/lifecycle.txt (+1/-1)
lib/lp/registry/templates/team-mailinglist.pt (+8/-4)
To merge this branch: bzr merge lp:~matsubara/launchpad/772016-mailinglist-help
Reviewer Review Type Date Requested Status
Jelmer Vernooij (community) code Approve
Review via email: mp+66443@code.launchpad.net

Commit message

[r=jelmer][bug=772016] Document in the +mailinglist page that email addresses not registered in LP will be silently discarded, fix link to more up to date documentation.

Description of the change

== Summary ==

This branch includes a note in the +mailinglist page stating that email
addresses not registered in LP will be silently discarded.
It also fixes the link to "Help for mailing lists" to point to the most
current documentation and rewrites the paragraph concerning ubuntu list
creation.

== Pre-implementation notes ==

Matthew helped with the text changes and Robert suggested that
help.launchpad.net should also include documentation about this behaviour. I
checked the page on the wiki and there's already documentation there about it.

== Tests ==

./bin/test -t stories/mailinglists

== Demo and Q/A ==

1. Open https://launchpad.dev/~ubuntu-team/+mailinglist

You'll see a note stating that email addresses not registered in LP will be
be discarded.

To post a comment you must log in.
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Another nice small UI cleanup. :)

Perhaps a bit pedantic, but maybe it should say that email is discarded rather than deleted as (at least as far as the user can tell) it is never stored in the first place.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/registry/stories/mailinglists/lifecycle.txt'
--- lib/lp/registry/stories/mailinglists/lifecycle.txt 2011-05-27 19:53:20 +0000
+++ lib/lp/registry/stories/mailinglists/lifecycle.txt 2011-06-30 13:57:32 +0000
@@ -21,7 +21,7 @@
21He thinks for a second whether his mailing list is for Ubuntu or not.21He thinks for a second whether his mailing list is for Ubuntu or not.
2222
23 >>> print extract_text(find_tag_by_id(browser.contents, 'ubuntu-notice'))23 >>> print extract_text(find_tag_by_id(browser.contents, 'ubuntu-notice'))
24 Ubuntu mailing lists should not be created here. Create them24 Ubuntu does not use Launchpad to host its mailing lists. Create them
25 at lists.ubuntu.com instead.25 at lists.ubuntu.com instead.
26 >>> print browser.getLink('lists.ubuntu.com')26 >>> print browser.getLink('lists.ubuntu.com')
27 <Link text='lists.ubuntu.com' url='https://lists.ubuntu.com'>27 <Link text='lists.ubuntu.com' url='https://lists.ubuntu.com'>
2828
=== modified file 'lib/lp/registry/templates/team-mailinglist.pt'
--- lib/lp/registry/templates/team-mailinglist.pt 2010-12-15 20:40:26 +0000
+++ lib/lp/registry/templates/team-mailinglist.pt 2011-06-30 13:57:32 +0000
@@ -49,15 +49,19 @@
49 <strong id="mailing-list-archive"49 <strong id="mailing-list-archive"
50 tal:content="context/visibility/title/fmt:lower" /> archive50 tal:content="context/visibility/title/fmt:lower" /> archive
51 </li>51 </li>
52 <li>
53 Launchpad will silently discard email sent from addresses that are
54 not associated with a Launchpad account.
55 </li>
52 </ul>56 </ul>
5357
54 <p id="ubuntu-notice"><strong>Ubuntu mailing lists should not be58 <p id="ubuntu-notice"><strong>Ubuntu does not use Launchpad to host
55 created here. Create them59 its mailing lists. Create them at
56 at <a href="https://lists.ubuntu.com">lists.ubuntu.com</a> instead.60 <a href="https://lists.ubuntu.com">lists.ubuntu.com</a> instead.
57 </strong></p>61 </strong></p>
5862
59 <p>63 <p>
60 &#187; <a href="https://help.launchpad.net/ListHelp">Help for mailing lists</a>64 &#187; <a href="https://help.launchpad.net/Teams/MailingLists">Help for mailing lists</a>
61 </p>65 </p>
62 <input tal:replace="structure view/request_list_creation/render" />66 <input tal:replace="structure view/request_list_creation/render" />
63 </div>67 </div>