Juju Charms Collection
jenkins-slave package

Code review comment for lp:~matsubara/charms/trusty/jenkins-slave/trusty-jenkins-slave

  1. Trusty Tahr (14.04)
  2. trusty-jenkins-slave
  3. Merge into trunk
Revision history for this message
Diogo Matsubara (matsubara) wrote :

> Hi Diogo.
>
> I think this change will break slaves that don't need credentials.

Hi Curtis,

I fixed the code per your review comments. Now the code checks if for username and password and update the config file accordingly. If there's no username and password, it will only update the jenkins url.

Thanks for the review!

Diogo

« Back to merge proposal