Merge lp:~matsubara/charms/trusty/jenkins-slave/trusty-jenkins-slave into lp:~juju-qa/charms/trusty/jenkins-slave/trunk
Proposed by
Diogo Matsubara
Status: | Merged |
---|---|
Merged at revision: | 21 |
Proposed branch: | lp:~matsubara/charms/trusty/jenkins-slave/trusty-jenkins-slave |
Merge into: | lp:~juju-qa/charms/trusty/jenkins-slave/trunk |
Diff against target: |
70 lines (+18/-8) 5 files modified
hooks/slave-relation-changed (+13/-1) hooks/slave-relation-joined (+1/-1) hooks/start (+0/-3) hooks/stop (+0/-3) metadata.yaml (+4/-0) |
To merge this branch: | bzr merge lp:~matsubara/charms/trusty/jenkins-slave/trusty-jenkins-slave |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+270418@code.launchpad.net |
Description of the change
Fix bug 1232886 by exporting the credentials from the jenkins master to the jenkins slave, so the slave agent can download the slave.jnlp file from the master and connect successfully.
Adds the extension interface to the charm so it can be used with the ci-configurator charm
Remove start/stop hooks since the slave should only be started or stopped based on its relation to the master.
To post a comment you must log in.
Hi Diogo.
I think this change will break slaves that don't need credentials.