Merge lp:~mathiaz/eucalyptus/k-keep-network-state-on-restart into lp:~ubuntu-core-dev/eucalyptus/ubuntu-karmic

Proposed by Mathias Gug
Status: Merged
Merged at revision: not available
Proposed branch: lp:~mathiaz/eucalyptus/k-keep-network-state-on-restart
Merge into: lp:~ubuntu-core-dev/eucalyptus/ubuntu-karmic
Diff against target: 24 lines
2 files modified
debian/changelog (+2/-0)
debian/eucalyptus-cc.upstart (+1/-2)
To merge this branch: bzr merge lp:~mathiaz/eucalyptus/k-keep-network-state-on-restart
Reviewer Review Type Date Requested Status
Dustin Kirkland  Needs Fixing
Review via email: mp+14331@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hmm, I think this would be a little better:

+ [ "$CLEAN" = "1" ] && rm -f /var/lib/eucalyptus/CC/*

As someone might conceivably use CLEAN=0.

I don't feel too strongly. This is more of a suggestion. Feel free to ignore.

review: Needs Fixing
719. By Mathias Gug

Merge karmic branch.

720. By Mathias Gug

Test whether CLEAN is actually set to 1.

721. By Mathias Gug

Merge karmic branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2009-11-03 16:05:34 +0000
+++ debian/changelog 2009-11-03 17:55:21 +0000
@@ -19,6 +19,8 @@
19 instead of publishing the CC IP address via the service name (LP: #458904).19 instead of publishing the CC IP address via the service name (LP: #458904).
20 * debian/avahi-daemon.conf: ship a specific avahi-daemon configuration file20 * debian/avahi-daemon.conf: ship a specific avahi-daemon configuration file
21 that doesn't publish IP addresses by default. (LP: #458904).21 that doesn't publish IP addresses by default. (LP: #458904).
22 * debian/eucalyptus-cc.upstart: Don't clean the CC network state when the CC is
23 stopped by default (LP: #460089).
2224
23 -- Thierry Carrez <thierry.carrez@ubuntu.com> Tue, 20 Oct 2009 12:26:19 +020025 -- Thierry Carrez <thierry.carrez@ubuntu.com> Tue, 20 Oct 2009 12:26:19 +0200
2426
2527
=== modified file 'debian/eucalyptus-cc.upstart'
--- debian/eucalyptus-cc.upstart 2009-10-14 00:43:55 +0000
+++ debian/eucalyptus-cc.upstart 2009-11-03 17:55:21 +0000
@@ -86,6 +86,5 @@
86 done86 done
87 fi87 fi
88 done88 done
8989 [ "${CLEAN}" = 1 ] && rm -f /var/lib/eucalyptus/CC/*
90 rm -f /var/lib/eucalyptus/CC/*
91end script90end script

Subscribers

People subscribed via source and target branches

to all changes: