Code review comment for lp:~martin-lp/hipl/n900-build-fix

Revision history for this message
Christof Mroz (christof-mroz) wrote :

On Mon, 10 Oct 2011 14:35:06 +0200, Diego Biurrun <email address hidden> wrote:

>>>> + tcase_set_timeout(tc_core, 120);
>>>
>>> I wonder if we should not set this in a slightly more global place.
>>
>> Any more thoughts on this? I've fixed the cosmetics and it would be
>> nice to get
>> this fix into trunk.
>
> I tend to suspect that we may run into this problem in other places in
> the future, so I'm inclined to set this (more) globally, but I don't
> much mind either way.

As a compromise, we could do that the next time we encounter a timeout on
the n900. But with a lower timeout, since 120 seconds are excessive even
on a phone for most operations. In this case (if I see it correctly),
multiple tests were bundled into one which stretched the runtime even
further.

« Back to merge proposal