Code review comment for lp:~martin-lp/hipl/n900-build-fix

 review approve

On Mon, Oct 10, 2011 at 12:20:38PM +0000, David Martin wrote:
> On Fri, Oct 7, 2011 at 1:21 PM, Christof Mroz <email address hidden> wrote:
> > I wouldn't set a global time limit: this way we can still catch poorly performing functions in other tests. So I'm fine with the new approach.
>
> Sounds reasonable.
>
> On Fri, Oct 7, 2011 at 11:28 AM, Diego Biurrun <email address hidden> wrote:
> > On Fri, Oct 07, 2011 at 09:20:31AM +0000, David Martin wrote:
>
> >> + tcase_set_timeout(tc_core, 120);
> >
> > I wonder if we should not set this in a slightly more global place.
>
> Any more thoughts on this? I've fixed the cosmetics and it would be nice to get
> this fix into trunk.

I tend to suspect that we may run into this problem in other places in
the future, so I'm inclined to set this (more) globally, but I don't
much mind either way. Push in whichever way you prefer.

Diego