Code review comment for lp:~martin-lp/hipl/n900-build-fix
Revision history for this message
| David Martin (martin-lp) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
a60fb26
(Get the code!)
On Fri, Oct 7, 2011 at 1:21 PM, Christof Mroz <email address hidden> wrote:
> I wouldn't set a global time limit: this way we can still catch poorly performing functions in other tests. So I'm fine with the new approach.
Sounds reasonable.
> Semi-related: is there a trivial way to change the "killed" message, as printed in case of a timeout, to something more helpful? Without modifying the check framework, I mean.
To be honest, no idea. Should I set up a bug report for it and attach the strace logs?
On Fri, Oct 7, 2011 at 11:28 AM, Diego Biurrun <email address hidden> wrote:
> On Fri, Oct 07, 2011 at 09:20:31AM +0000, David Martin wrote:
>> + tcase_set_
>
> I wonder if we should not set this in a slightly more global place.
Any more thoughts on this? I've fixed the cosmetics and it would be nice to get
this fix into trunk.