Code review comment for lp:~martin-lp/hipl/n900-build-fix

 review needs-info

On Fri, Oct 07, 2011 at 09:20:31AM +0000, David Martin wrote:
>
> --- test/lib/core/hostid.c 2011-09-05 08:46:53 +0000
> +++ test/lib/core/hostid.c 2011-10-07 09:19:23 +0000
> @@ -65,7 +65,7 @@
> START_TEST(test_serialize_deserialize_rsa_keys)
> {
> unsigned int i, keyrr_len = 0;
> - int bits[3] = {1024, 2048, 3072};
> + int bits[3] = { 1024, 2048, 3072 };
> RSA *key = NULL, *key_deserialized = NULL;

This you can push anytime.

> @@ -126,6 +126,11 @@
>
> TCase *tc_core = tcase_create("Core");
> + // the default test timeout of 4 seconds is too short,
> + // generating keys in scratchbox or on the N900 takes
> + // a while

nit: no need to break the second line and /* */ comments are preferred

> + tcase_set_timeout(tc_core, 120);

I wonder if we should not set this in a slightly more global place.

Diego