Code review comment for lp:~martin-lp/hipl/hipl_exp_backoff

On Thu, Mar 08, 2012 at 06:27:30PM +0000, David Martin wrote:
> On Thu, Mar 8, 2012 at 7:00 PM, Diego Biurrun <email address hidden> wrote:
> >> --- hipd/maintenance.c 2012-02-15 17:37:10 +0000
> >> +++ hipd/maintenance.c 2012-03-07 18:04:31 +0000
> >> @@ -87,6 +86,31 @@
> >> +static void update_retrans_backoff(struct hip_msg_retrans *const retrans)
> >> +{
> >> + retrans->current_backoff = retrans->current_backoff << 1;
> >> + if (retrans->current_backoff > HIP_RETRANSMIT_BACKOFF_MAX) {
> >> + HIP_DEBUG("Maximum retransmission backoff reached. Stopping"
> >> + " retransmission.\n");
> >
> > retransmissionS I think.
>
> I had the plural before but decided to change it. Directly quoted from
> the commit log:
>
> > "Stopping retransmissions." sounds like no more retransmissions will be
> > sent at all but it only refers to this specific one. "Stopping "
> > retransmission." makes it more clear.

OK, then keep your version, the singular was intended.

Diego