Code review comment for lp:~martin-lp/hipl/hipl_exp_backoff

 review approve

On Wed, Mar 07, 2012 at 06:05:28PM +0000, David Martin wrote:
> David Martin has proposed merging lp:~martin-lp/hipl/hipl_exp_backoff into lp:hipl.
>
> Requested reviews:
> HIPL core team (hipl-core)

No real comments from me, looks sane overall. If this is well-tested,
I trust you it will be fine.

> --- hipd/maintenance.c 2012-02-15 17:37:10 +0000
> +++ hipd/maintenance.c 2012-03-07 18:04:31 +0000
> @@ -87,6 +86,31 @@
> static struct hip_ll *maintenance_functions;
>
> /**
> + * Update the retransmission backoff of the given retransmission.
> + * The backoff will simply be doubled and in case the maximum is exceeded the
> + * retransmissions are disabled.

in case the maximum is exceeded retransmissions are

> +static void update_retrans_backoff(struct hip_msg_retrans *const retrans)
> +{
> + retrans->current_backoff = retrans->current_backoff << 1;
> + if (retrans->current_backoff > HIP_RETRANSMIT_BACKOFF_MAX) {
> + HIP_DEBUG("Maximum retransmission backoff reached. Stopping"
> + " retransmission.\n");

retransmissionS I think.

Diego