Code review comment for lp:~martin-lp/hipl/hipfwconf

Revision history for this message
Diego Biurrun (diego-biurrun) wrote :

 review approve

On Tue, Nov 08, 2011 at 05:12:08PM +0000, David Martin wrote:
> David Martin has proposed merging lp:~martin-lp/hipl/hipfwconf into lp:hipl.
>
> --- lib/core/message.c 2011-10-25 21:44:47 +0000
> +++ lib/core/message.c 2011-11-08 17:09:18 +0000
> @@ -319,23 +330,30 @@
>
> -static int send_recv_daemon_info_internal(struct hip_common *msg,
> - int opt_socket)
> +static int send_recv_info_internal(struct hip_common *msg, int opt_socket, int port)

nit: This is now a long line.

Anyway, this looks good to me now, so go ahead and push :)

Diego

review: Approve

« Back to merge proposal