These are my final comments about the logging.py module.
I also would like to discuss what should we do to force coverage (--cov-fail-under=MIN) on next MRs. IMO, we should consider these two approaches:
1 - Fixing the coverage percentage to what we have right now (95.13) on the tox command for unit tests
2 - add a "# pragma: no cover" on the lines missing unit tests with a message TODO to cover in the future and limit it with 100 percentage.
I slightly prefer the second option.
« Back to merge proposal
These are my final comments about the logging.py module.
I also would like to discuss what should we do to force coverage (--cov- fail-under= MIN) on next MRs. IMO, we should consider these two approaches:
1 - Fixing the coverage percentage to what we have right now (95.13) on the tox command for unit tests
2 - add a "# pragma: no cover" on the lines missing unit tests with a message TODO to cover in the future and limit it with 100 percentage.
I slightly prefer the second option.