Merge lp:~markgius/horizon/lp727414 into lp:~hudson-openstack/horizon/trunk

Proposed by Mark Gius
Status: Merged
Approved by: Devin Carlen
Approved revision: 51
Merged at revision: 51
Proposed branch: lp:~markgius/horizon/lp727414
Merge into: lp:~hudson-openstack/horizon/trunk
Prerequisite: lp:~markgius/horizon/lp787222
Diff against target: 22 lines (+3/-2)
1 file modified
openstack-dashboard/tools/install_venv.py (+3/-2)
To merge this branch: bzr merge lp:~markgius/horizon/lp727414
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+62050@code.launchpad.net

Description of the change

Makes existing messages for check_dependencies more clear. output for later steps already clear.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openstack-dashboard/tools/install_venv.py'
--- openstack-dashboard/tools/install_venv.py 2011-05-23 22:55:52 +0000
+++ openstack-dashboard/tools/install_venv.py 2011-05-23 22:55:52 +0000
@@ -64,6 +64,7 @@
64def check_dependencies():64def check_dependencies():
65 """Make sure virtualenv is in the path."""65 """Make sure virtualenv is in the path."""
6666
67 print 'checking dependencies...'
67 if not HAS_VIRTUALENV:68 if not HAS_VIRTUALENV:
68 print 'not found.'69 print 'not found.'
69 # Try installing it via easy_install...70 # Try installing it via easy_install...
@@ -73,8 +74,8 @@
73 die('ERROR: virtualenv not found.\n\nevelopment requires'74 die('ERROR: virtualenv not found.\n\nevelopment requires'
74 ' virtualenv, please install it using your favorite'75 ' virtualenv, please install it using your favorite'
75 ' package management tool')76 ' package management tool')
76 print 'done.'77 print 'virtualenv installation done.'
77 print 'done.'78 print 'dependency check done.'
7879
7980
80def create_virtualenv(venv=VENV):81def create_virtualenv(venv=VENV):

Subscribers

People subscribed via source and target branches