Merge lp:~mariusko/modemmanager/ubuntu.quantal_lp1057186 into lp:~modemmanager/modemmanager/ubuntu.quantal
Proposed by
Marius B. Kotsbak
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Mathieu Trudel-Lapierre | ||||
Proposed branch: | lp:~mariusko/modemmanager/ubuntu.quantal_lp1057186 | ||||
Merge into: | lp:~modemmanager/modemmanager/ubuntu.quantal | ||||
Diff against target: |
124 lines (+98/-0) 4 files modified
debian/changelog (+15/-0) debian/patches/0001-huawei-better-detection-of-data-port-on-some-modems.patch (+51/-0) debian/patches/git_via-plugin-has-vendor-product-string-probing-so-need_69fe9a8.patch (+31/-0) debian/patches/series (+1/-0) |
||||
To merge this branch: | bzr merge lp:~mariusko/modemmanager/ubuntu.quantal_lp1057186 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | Disapprove | ||
Review via email: mp+131224@code.launchpad.net |
To post a comment you must log in.
Unmerged revisions
- 168. By Marius B. Kotsbak
-
Remove patch 0001-via-
plugin- has-vendor- product- string- probing- so-need. patch as it applies to newer versions than
is currently in Quantal. - 167. By Marius B. Kotsbak
-
Formating error in changelog file.
- 166. By Marius B. Kotsbak
-
Fix Debian version number.
- 165. By Marius B. Kotsbak
-
Replace patch git_huawei-
better- detection- of-data- port-on- some-modems_ 18c3dfa. patch with two new from upstream:
huawei-better- detection- of-data- port-on- some-modems. patch and via-plugin- has-vendor- product- string- probing- so-need - 164. By Marius B. Kotsbak
-
git_huawei-
better- detection- of-data- port-on- some-modems_ 18c3dfa. patch:
fix for regression since Precise for Huawei E173 (LP: #1057186)
There's an extra file in teh changes: patches/ git_via- plugin- has-vendor- product- string- probing- so-need_ 69fe9a8. patch'
=== added file 'debian/
Is this expected? If so, to be applied it should be added debian/ patches/ series, and definitely mentioned in debian/changelog.
Additionally, please target this to the /ubuntu branch instead of /ubuntu.quantal, SRU normally requires updates to be tested in the development release before being provided in proposed for releases.