Code review comment for lp:~mariusko/modemmanager/ubuntu.quantal_lp1057186

Mathieu Trudel-Lapierre (cyphermox) wrote :

There's an extra file in teh changes:
 === added file 'debian/patches/git_via-plugin-has-vendor-product-string-probing-so-need_69fe9a8.patch'

Is this expected? If so, to be applied it should be added debian/patches/series, and definitely mentioned in debian/changelog.

Additionally, please target this to the /ubuntu branch instead of /ubuntu.quantal, SRU normally requires updates to be tested in the development release before being provided in proposed for releases.

review: Needs Fixing

« Back to merge proposal