Merge lp:~mardy/click-reviewers-tools/no-service-type-check into lp:click-reviewers-tools

[Alberto Mardegan]

Do not check for "type" element in OA .service files

Do not check for "type" element in OA .service files

[lp:~mardy/click-reviewers-tools/no-service-type-check]

506. By Alberto Mardegan on 2015-07-22

Update tests

[Jamie Strandboge (jdstrand)]

Thanks for the MP :) I think this looks fine but if we aren't going to check for type there is no reason stubbing it out or having a test case for it in the testsuite. I'll commit those changes on top of yours.

review: Approve

=== modified file 'clickreviews/cr_online_accounts.py'
--- clickreviews/cr_online_accounts.py	2015-07-14 21:27:25 +0000
+++ clickreviews/cr_online_accounts.py	2015-07-22 08:22:23 +0000
@@ -185,7 +185,7 @@
             if t == 'error':
                 continue
 
-            for tag in ['type', 'name', 'provider']:
+            for tag in ['name', 'provider']:
                 t = 'info'
                 n = '%s_%s_%s' % (app, account_type, tag)
                 s = "OK"
 
=== modified file 'clickreviews/tests/test_cr_online_accounts.py'
--- clickreviews/tests/test_cr_online_accounts.py	2015-06-25 19:00:57 +0000
+++ clickreviews/tests/test_cr_online_accounts.py	2015-07-22 08:22:23 +0000
@@ -167,7 +167,7 @@
         c = ClickReviewAccounts(self.test_name)
         c.check_service()
         r = c.click_report
-        expected_counts = {'info': 5, 'warn': 0, 'error': 0}
+        expected_counts = {'info': 4, 'warn': 0, 'error': 0}
         self.check_results(r, expected_counts)
 
     def test_check_service_not_specified(self):
@@ -216,7 +216,7 @@
         c = ClickReviewAccounts(self.test_name)
         c.check_service()
         r = c.click_report
-        expected_counts = {'info': None, 'warn': 0, 'error': 1}
+        expected_counts = {'info': None, 'warn': 0, 'error': 0}
         self.check_results(r, expected_counts)
 
     def test_check_service_missing_name(self):