lp:click-reviewers-tools

Created by Daniel Holbach on 2013-08-16 and last modified on 2019-02-15
Get this branch:
bzr branch lp:click-reviewers-tools
Members of Canonical Store Reviewers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Canonical Store Reviewers
Project:
Canonical Click Reviewers tools
Status:
Development

Recent revisions

1188. By Jamie Strandboge on 2019-02-15

rewrite declaration check to more closely match snapd

This rewrite reduces the lines of code and simplifies the logic significantly
so hopefully maintenance in this area will be easier. In addition to this, the
code should now properly support:
- regular expressions for interface attributes
- declarations that use lists for interface attributes (all must match now)
- alternative interface attributes
- better support for alternate constraints
- support $SLOT() and $PLUG()
- support $MISSING
- support plugs-attributes and slot-attributes in the same declaration
- corner case bug fix surrounding store/brand scoping
- several bug fixes for interface attributes

In addition to the above, many new test cases were added (indeed, they found
the bugs in the previous implementation).

Finally, the existing testsuite (unit and functional) was used to verify the
expected behavior is the same (ie, this rewrite should not introduce new manual
reviews in the store for existing snaps*).

* except for snaps plugging 'docker' since the tools previously incorrectly did
  not flag the installation constraint

1187. By Jamie Strandboge on 2019-02-01

bin/snap-check-notices: handle empty output from updates-available

1186. By Jamie Strandboge on 2019-02-01

bin/snap-check-notices: rewrite in python3

1185. By Jamie Strandboge on 2019-01-29

update changelog for recent commits

1184. By Jamie Strandboge on 2019-01-29

ignore W605 invalid escape sequence (remove this after click code is removed)

1183. By Jamie Strandboge on 2019-01-29

'application/x-pie-executable' is a binary type on disco

1182. By Jamie Strandboge on 2019-01-29

ignore 'W504 line break after binary operator'

1181. By Jamie Strandboge on 2019-01-29

update for newer pep8/pycodestyle

1180. By Jamie Strandboge on 2019-01-29

update for 2.37 interfaces

1179. By Jamie Strandboge on 2019-01-29

clickreviews/overrides.py: pi gadget is from Canonical

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.