Merge lp:~mardy/account-plugins/lp1029289 into lp:account-plugins
Proposed by
Alberto Mardegan
Status: | Merged |
---|---|
Approved by: | Alberto Mardegan |
Approved revision: | 83 |
Merged at revision: | 89 |
Proposed branch: | lp:~mardy/account-plugins/lp1029289 |
Merge into: | lp:account-plugins |
Diff against target: |
87 lines (+42/-4) 2 files modified
debian/rules (+1/-0) src/google.vala (+41/-4) |
To merge this branch: | bzr merge lp:~mardy/account-plugins/lp1029289 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
David King (community) | Approve | ||
Review via email: mp+138779@code.launchpad.net |
Commit message
Use web-server authentication with Google, to take advantage of refresh tokens
Use the web-authentication as described in https:/
To post a comment you must log in.
Looks fine, except:
32 + var oauth_params = get_parameters( ParametersUser. ACCOUNT_ PLUGIN) ; parameters (oauth_params); ParametersUser. CLIENT_ APPLICATIONS) ; oauth_parameter s (oauth_params); Ap.OAuthMechani sm.WEB_ SERVER) ;
33 + set_oauth_
34 +
35 + oauth_params = get_parameters(
36 + set_account_
37 +
38 + set_mechanism(
39 +
40 + set_ignore_cookies (true);
It is better to be consistent by adding a space before every opening bracket.