Code review comment for lp:~mardy/account-plugins/lp1029289

Revision history for this message
David King (amigadave) wrote :

Looks fine, except:

32 + var oauth_params = get_parameters(ParametersUser.ACCOUNT_PLUGIN);
33 + set_oauth_parameters (oauth_params);
34 +
35 + oauth_params = get_parameters(ParametersUser.CLIENT_APPLICATIONS);
36 + set_account_oauth_parameters (oauth_params);
37 +
38 + set_mechanism(Ap.OAuthMechanism.WEB_SERVER);
39 +
40 + set_ignore_cookies (true);

It is better to be consistent by adding a space before every opening bracket.

review: Needs Fixing

« Back to merge proposal