Code review comment for lp:~marcustomlinson/unity-scopes-api/lp-1267917-2

Revision history for this message
Michal Hruby (mhr3) wrote :

Hmm, looks a bit odd, are we really creating a thread solely to serve one request?

Nonetheless, it does fix the issue, I'm just not convinced it's a good idea to rely on emitting a signal to quit the thread, as this is inverting the responsibility and the thread is no longer a worker, but a "I'll quit when you ask me to" thing.

« Back to merge proposal