Merge lp:~marcustomlinson/unity-scopes-api/lp-1267917-2 into lp:unity-scopes-api
Proposed by
Marcus Tomlinson
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Michal Hruby | ||||
Approved revision: | 138 | ||||
Merged at revision: | 144 | ||||
Proposed branch: | lp:~marcustomlinson/unity-scopes-api/lp-1267917-2 | ||||
Merge into: | lp:unity-scopes-api | ||||
Diff against target: |
208 lines (+83/-57) 3 files modified
include/unity/scopes/internal/smartscopes/HttpClientQtThread.h (+8/-4) src/scopes/internal/smartscopes/HttpClientQt.cpp (+8/-22) src/scopes/internal/smartscopes/HttpClientQtThread.cpp (+67/-31) |
||||
To merge this branch: | bzr merge lp:~marcustomlinson/unity-scopes-api/lp-1267917-2 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Michal Hruby (community) | Approve | ||
Review via email:
|
Commit message
Ensure that manager_ and reply_ objects are created and destroyed from within the same Qt thread.
To post a comment you must log in.
PASSED: Continuous integration, rev:130 jenkins. qa.ubuntu. com/job/ unity-scopes- api-ci/ 252/ jenkins. qa.ubuntu. com/job/ unity-scopes- api-trusty- amd64-ci/ 252 jenkins. qa.ubuntu. com/job/ unity-scopes- api-trusty- armhf-ci/ 252 jenkins. qa.ubuntu. com/job/ unity-scopes- api-trusty- armhf-ci/ 252/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-scopes- api-trusty- i386-ci/ 252
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- scopes- api-ci/ 252/rebuild
http://