Code review comment for lp:~marcustomlinson/unity-scopes-api/lp-1267917-2

Revision history for this message
Michal Hruby (mhr3) wrote :

11 + moveToThread(this);

Shouldn't be necessary.

20 + reply_->deleteLater();

The reply_ object is created inside the thread, so it should be destroyed inside the thread, isn't that what the original error was about?

review: Needs Information

« Back to merge proposal