Code review comment for lp:~manuel-nicetto/unity/bug-754565

Revision history for this message
Tim Penhey (thumper) wrote :

On Sat, 25 Jun 2011 08:44:55 you wrote:
> +void
> +Launcher::RecvKeyReleased (unsigned int key_sym,
> + unsigned long key_code,
> + unsigned long key_state)
> +{
> + _shift_pressed=false;
> +}
> +

This looks wrong. What if the user held shift, then alt, then released alt,
but shift still down. This would incorrectly clear the shift pressed. We
should check the key code.

Tim

« Back to merge proposal