Merge lp:~manuel-nicetto/unity/bug-754565 into lp:unity
Proposed by
Manuel Nicetto
Status: | Superseded |
---|---|
Proposed branch: | lp:~manuel-nicetto/unity/bug-754565 |
Merge into: | lp:unity |
Diff against target: |
149 lines (+39/-4) 4 files modified
plugins/unityshell/src/Launcher.cpp (+24/-1) plugins/unityshell/src/Launcher.h (+2/-0) plugins/unityshell/src/LauncherIcon.cpp (+11/-3) plugins/unityshell/src/LauncherIcon.h (+2/-0) |
To merge this branch: | bzr merge lp:~manuel-nicetto/unity/bug-754565 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Unity Team | Pending | ||
Review via email: mp+65836@code.launchpad.net |
This proposal supersedes a proposal from 2011-06-16.
This proposal has been superseded by a proposal from 2011-06-27.
To post a comment you must log in.
Unmerged revisions
- 1245. By Manuel Nicetto
-
Pass shift_pressed on click behavior as suggested by Jason
- 1244. By Manuel Nicetto
-
-- fixed another identation error
- 1243. By Manuel Nicetto
-
-- Fixed key release checking the correct shift pressed event reported by Tim Penhey
-- Fixed identation errors reported from Marco Biscaro - 1242. By Manuel Nicetto
-
fixed _shift_pressed assigned twice in LauncherIcon.cpp
- 1241. By Manuel Nicetto
-
* Regression: shift+click on a launcher icon to open a new application instance gone
-- Manuel Nicetto <email address hidden> Thu 16 Jun 2011 23:31
On Sat, 25 Jun 2011 08:44:55 you wrote: :RecvKeyRelease d (unsigned int key_sym, pressed= false;
> +void
> +Launcher:
> + unsigned long key_code,
> + unsigned long key_state)
> +{
> + _shift_
> +}
> +
This looks wrong. What if the user held shift, then alt, then released alt,
but shift still down. This would incorrectly clear the shift pressed. We
should check the key code.
Tim