Code review comment for lp:~mandel/ubuntuone-client/eq-add-ancestors-watches

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* Do not overwrite methods like this:

        self.eq.monitor.add_watches_to_udf_ancestors = add_watches_to_udf_ancestor

Always, always, always, use self.patch. Alecu had huge headaches debugging a case like this! :-)

* Please restore the empty line from ubuntuone/platform/linux/filesystem_notifications.py (before the NAME_TRANSLATIONS definition).

* This log line:

            m = "Unsubscribing UDF %r because not in disk: %r"
            self.log.info(m, volume.volume_id, volume.path)

should remain in local_rescan.

review: Needs Fixing

« Back to merge proposal