Merge lp:~mandel/ubuntuone-client/eq-add-ancestors-watches into lp:ubuntuone-client
Proposed by
Manuel de la Peña
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Manuel de la Peña | ||||
Proposed branch: | lp:~mandel/ubuntuone-client/eq-add-ancestors-watches | ||||
Merge into: | lp:ubuntuone-client | ||||
Diff against target: |
368 lines (+177/-40) 8 files modified
tests/platform/linux/test_filesystem_notifications.py (+46/-0) tests/platform/windows/test_filesystem_notifications.py (+20/-0) tests/syncdaemon/test_eq_inotify.py (+38/-2) tests/syncdaemon/test_localrescan.py (+15/-0) ubuntuone/platform/linux/filesystem_notifications.py (+29/-1) ubuntuone/platform/windows/filesystem_notifications.py (+8/-0) ubuntuone/syncdaemon/event_queue.py (+15/-2) ubuntuone/syncdaemon/local_rescan.py (+6/-35) |
||||
To merge this branch: | bzr merge lp:~mandel/ubuntuone-client/eq-add-ancestors-watches | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alejandro J. Cura (community) | Approve | ||
Manuel de la Peña (community) | Disapprove | ||
Natalia Bidart (community) | Needs Fixing | ||
Review via email: mp+73775@code.launchpad.net |
Commit message
Fixes lp:838111
The code moves the addition of the watches for the UDF ancestor to the FilesystemMonitor which is a platform dependent class. The new API is exposed through the eq so that the local rescan can use it. This branch also provides the implementation of Windows which simply ignores the addition of the watches.
Description of the change
Fixes lp:838111
The code moves the addition of the watches for the UDF ancestor to the FilesystemMonitor which is a platform dependent class. The new API is exposed through the eq so that the local rescan can use it. This branch also provides the implementation of Windows which simply ignores the addition of the watches.
To post a comment you must log in.
Some comments on the style, while I finish the review:
There are a few dangling space characters at the end of some lines.
Also, a few typos:
"a new istance" - > "a new instance"
"ar not added" -> "are not added"
"have not bee" -> "have not been"
"for a use to" -> "for a user to"
"On windows we do no" -> "On windows we do not"
"we need to ensure that the udf is not watch because there was an issue when dealing with the addition of the parent watches." -> "we need to ensure that the udf is not subscribed when an error happens while adding the parent watches."