Merge lp:~mandel/ubuntu-sso-client/fix_735383 into lp:ubuntu-sso-client

Proposed by Manuel de la Peña
Status: Merged
Approved by: Roman Yepishev
Approved revision: 682
Merged at revision: 679
Proposed branch: lp:~mandel/ubuntu-sso-client/fix_735383
Merge into: lp:ubuntu-sso-client
Diff against target: 31 lines (+5/-2)
2 files modified
setup.py (+2/-1)
ubuntu_sso/networkstate/windows.py (+3/-1)
To merge this branch: bzr merge lp:~mandel/ubuntu-sso-client/fix_735383
Reviewer Review Type Date Requested Status
Roman Yepishev (community) fieldtest Approve
James Henstridge (community) Approve
Review via email: mp+53515@code.launchpad.net

Commit message

Fixed setup.py issues so that we can build .debs. This branch depends on the use of lp:~mandel/python-distutils-extra/import_issues

Description of the change

Fixed setup.py issues so that we can build .debs. This branch depends on the use of lp:~mandel/python-distutils-extra/import_issues

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good. Running "setup.py install" correctly installs the two missing sub-packages now. I son't get any error related to the wintypes module either using the new DistutilsExtra version.

On IRC I asked Manuel about the new annotations in ubuntu_sso/networkstate/windows.py. He says that they are for use by a future DistutilsExtra feature. Since Manuel is the main person touching this code, I don't see any problem leaving these in place even though they don't do anything yet.

review: Approve
Revision history for this message
Roman Yepishev (rye) wrote :

Did a full build of sso client with pbuilder and import_issues/DistUtilsExtra copied to SSO directory.
SSO client is now working again.

review: Approve (fieldtest)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup.py'
--- setup.py 2011-02-03 15:07:48 +0000
+++ setup.py 2011-03-15 20:42:34 +0000
@@ -94,7 +94,8 @@
94 long_description='Desktop service to allow applications to sign in' \94 long_description='Desktop service to allow applications to sign in' \
95 'to Ubuntu services via SSO',95 'to Ubuntu services via SSO',
96 url='https://launchpad.net/ubuntu-sso-client',96 url='https://launchpad.net/ubuntu-sso-client',
97 packages=['ubuntu_sso', 'ubuntu_sso.gtk', 'ubuntu_sso.utils'],97 packages=['ubuntu_sso', 'ubuntu_sso.gtk', 'ubuntu_sso.utils',
98 'ubuntu_sso.keyring', 'ubuntu_sso.networkstate'],
98 data_files=[99 data_files=[
99 ('share/dbus-1/services', ['data/com.ubuntu.sso.service']),100 ('share/dbus-1/services', ['data/com.ubuntu.sso.service']),
100 ('lib/ubuntu-sso-client', ['bin/ubuntu-sso-login']),101 ('lib/ubuntu-sso-client', ['bin/ubuntu-sso-login']),
101102
=== modified file 'ubuntu_sso/networkstate/windows.py'
--- ubuntu_sso/networkstate/windows.py 2011-03-10 15:55:08 +0000
+++ ubuntu_sso/networkstate/windows.py 2011-03-15 20:42:34 +0000
@@ -16,10 +16,12 @@
16# with this program. If not, see <http://www.gnu.org/licenses/>.16# with this program. If not, see <http://www.gnu.org/licenses/>.
17"""Network status implementation on Windows."""17"""Network status implementation on Windows."""
1818
19
19# pylint: disable=F040120# pylint: disable=F0401
21# distutils-extra: ignore-import=pythoncom,win32com.server.policy
22# distutils-extra: ignore-import=win32com.client
20import pythoncom23import pythoncom
21# pylint: enable=F040124# pylint: enable=F0401
22
23from ctypes import windll, byref25from ctypes import windll, byref
24from ctypes.wintypes import DWORD26from ctypes.wintypes import DWORD
25from threading import Thread27from threading import Thread

Subscribers

People subscribed via source and target branches