Ubuntu Single Sign On Client

Code review comment for lp:~mandel/ubuntu-sso-client/fix_735383

  1. fix_735383
  2. Merge into trunk
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good. Running "setup.py install" correctly installs the two missing sub-packages now. I son't get any error related to the wintypes module either using the new DistutilsExtra version.

On IRC I asked Manuel about the new annotations in ubuntu_sso/networkstate/windows.py. He says that they are for use by a future DistutilsExtra feature. Since Manuel is the main person touching this code, I don't see any problem leaving these in place even though they don't do anything yet.

review: Approve

« Back to merge proposal