Merge lp:~mandel/ubuntu-sso-client/fix_735383 into lp:ubuntu-sso-client

Proposed by Manuel de la Peña
Status: Merged
Approved by: Roman Yepishev
Approved revision: 682
Merged at revision: 679
Proposed branch: lp:~mandel/ubuntu-sso-client/fix_735383
Merge into: lp:ubuntu-sso-client
Diff against target: 31 lines (+5/-2)
2 files modified
setup.py (+2/-1)
ubuntu_sso/networkstate/windows.py (+3/-1)
To merge this branch: bzr merge lp:~mandel/ubuntu-sso-client/fix_735383
Reviewer Review Type Date Requested Status
Roman Yepishev (community) fieldtest Approve
James Henstridge (community) Approve
Review via email: mp+53515@code.launchpad.net

Commit message

Fixed setup.py issues so that we can build .debs. This branch depends on the use of lp:~mandel/python-distutils-extra/import_issues

Description of the change

Fixed setup.py issues so that we can build .debs. This branch depends on the use of lp:~mandel/python-distutils-extra/import_issues

To post a comment you must log in.
Revision history for this message
James Henstridge (jamesh) wrote :

Looks good. Running "setup.py install" correctly installs the two missing sub-packages now. I son't get any error related to the wintypes module either using the new DistutilsExtra version.

On IRC I asked Manuel about the new annotations in ubuntu_sso/networkstate/windows.py. He says that they are for use by a future DistutilsExtra feature. Since Manuel is the main person touching this code, I don't see any problem leaving these in place even though they don't do anything yet.

review: Approve
Revision history for this message
Roman Yepishev (rye) wrote :

Did a full build of sso client with pbuilder and import_issues/DistUtilsExtra copied to SSO directory.
SSO client is now working again.

review: Approve (fieldtest)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup.py'
2--- setup.py 2011-02-03 15:07:48 +0000
3+++ setup.py 2011-03-15 20:42:34 +0000
4@@ -94,7 +94,8 @@
5 long_description='Desktop service to allow applications to sign in' \
6 'to Ubuntu services via SSO',
7 url='https://launchpad.net/ubuntu-sso-client',
8- packages=['ubuntu_sso', 'ubuntu_sso.gtk', 'ubuntu_sso.utils'],
9+ packages=['ubuntu_sso', 'ubuntu_sso.gtk', 'ubuntu_sso.utils',
10+ 'ubuntu_sso.keyring', 'ubuntu_sso.networkstate'],
11 data_files=[
12 ('share/dbus-1/services', ['data/com.ubuntu.sso.service']),
13 ('lib/ubuntu-sso-client', ['bin/ubuntu-sso-login']),
14
15=== modified file 'ubuntu_sso/networkstate/windows.py'
16--- ubuntu_sso/networkstate/windows.py 2011-03-10 15:55:08 +0000
17+++ ubuntu_sso/networkstate/windows.py 2011-03-15 20:42:34 +0000
18@@ -16,10 +16,12 @@
19 # with this program. If not, see <http://www.gnu.org/licenses/>.
20 """Network status implementation on Windows."""
21
22+
23 # pylint: disable=F0401
24+# distutils-extra: ignore-import=pythoncom,win32com.server.policy
25+# distutils-extra: ignore-import=win32com.client
26 import pythoncom
27 # pylint: enable=F0401
28-
29 from ctypes import windll, byref
30 from ctypes.wintypes import DWORD
31 from threading import Thread

Subscribers

People subscribed via source and target branches