Merge lp:~mandel/ubuntu-sso-client/fix_735383 into lp:ubuntu-sso-client
Proposed by
Manuel de la Peña
Status: | Merged |
---|---|
Approved by: | Roman Yepishev |
Approved revision: | 682 |
Merged at revision: | 679 |
Proposed branch: | lp:~mandel/ubuntu-sso-client/fix_735383 |
Merge into: | lp:ubuntu-sso-client |
Diff against target: |
31 lines (+5/-2) 2 files modified
setup.py (+2/-1) ubuntu_sso/networkstate/windows.py (+3/-1) |
To merge this branch: | bzr merge lp:~mandel/ubuntu-sso-client/fix_735383 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Roman Yepishev (community) | fieldtest | Approve | |
James Henstridge (community) | Approve | ||
Review via email: mp+53515@code.launchpad.net |
Commit message
Fixed setup.py issues so that we can build .debs. This branch depends on the use of lp:~mandel/python-distutils-extra/import_issues
Description of the change
Fixed setup.py issues so that we can build .debs. This branch depends on the use of lp:~mandel/python-distutils-extra/import_issues
To post a comment you must log in.
Looks good. Running "setup.py install" correctly installs the two missing sub-packages now. I son't get any error related to the wintypes module either using the new DistutilsExtra version.
On IRC I asked Manuel about the new annotations in ubuntu_ sso/networkstat e/windows. py. He says that they are for use by a future DistutilsExtra feature. Since Manuel is the main person touching this code, I don't see any problem leaving these in place even though they don't do anything yet.