Merge lp:~makyo/charms/precise/juju-gui/core-chmod into lp:~juju-gui/charms/precise/juju-gui/trunk

[Madison Scott-Clary]

Charm dir perms in core #1202772

Apache was giving a 403 when charm was deployed using core due to perms on the charm dir.

https://codereview.appspot.com/11540043/

[Madison Scott-Clary (makyo)]

Reviewers: mp+175649_code.launchpad.net,

Message:
Please take a look.

Description:
Charm dir perms in core #1202772

Apache was giving a 403 when charm was deployed using core due to perms
on the charm dir.

https://code.launchpad.net/~makyo/charms/precise/juju-gui/core-chmod/+merge/175649

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/11540043/

Affected files:
   A [revision details]
   M hooks/backend.py

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision:
<email address hidden>
+New revision: <email address hidden>

Index: hooks/backend.py
=== modified file 'hooks/backend.py'
--- hooks/backend.py 2013-07-17 21:30:28 +0000
+++ hooks/backend.py 2013-07-18 18:38:11 +0000
@@ -149,6 +149,9 @@
  class GoMixin(object):
      debs = ('python-yaml',)

+ def install(self, backend):
+ utils.cmd_log(shelltoolbox.run('chmod', '+x', utils.CURRENT_DIR))
+

  class Backend(object):
      """Compose methods and policy needed to interact with a Juju
backend."""

[Benjamin Saller (bcsaller)]

LGTM

Thanks

https://codereview.appspot.com/11540043/

[Gary Poster (gary)]

LGTM with trivial.

Thank you!

Gary

https://codereview.appspot.com/11540043/diff/1/hooks/backend.py
File hooks/backend.py (right):

https://codereview.appspot.com/11540043/diff/1/hooks/backend.py#newcode153
hooks/backend.py:153: utils.cmd_log(shelltoolbox.run('chmod', '+x',
utils.CURRENT_DIR))
Please add a comment referencing the bug number to explain why we are
doing this.

https://codereview.appspot.com/11540043/

[Madison Scott-Clary (makyo)]

*** Submitted:

Charm dir perms in core #1202772

Apache was giving a 403 when charm was deployed using core due to perms
on the charm dir.

R=benjamin.saller, gary.poster
CC=
https://codereview.appspot.com/11540043

https://codereview.appspot.com/11540043/

=== modified file 'hooks/backend.py'
--- hooks/backend.py	2013-07-17 21:30:28 +0000
+++ hooks/backend.py	2013-07-18 18:52:30 +0000
@@ -149,6 +149,9 @@
 class GoMixin(object):
     debs = ('python-yaml',)
 
+    def install(self, backend):
+        utils.cmd_log(shelltoolbox.run('chmod', '+x', utils.CURRENT_DIR))
+
 
 class Backend(object):
     """Compose methods and policy needed to interact with a Juju backend."""