Code review comment for lp:~madsrh/ubiquity-slideshow-ubuntu/Yaru-CSS

Revision history for this message
Sebastien Bacher (seb128) wrote :

@Adolfo, that comment is not really useful nor constructive, please keep those away from reviews

@MadsRH, looking at the changes I've some comments/questions

- the commit message/description doesn't really convey why we need those changes. In fact the messages speaks about color but the diff includes new icons?

- we already got a recent icons refresh with https://code.launchpad.net/~fitojb/ubiquity-slideshow-ubuntu/logo-refresh/+merge/353025 ... how is that different?

- where are the icons coming from?

- why are the css changes needed?

- also the file permissions changes to +x on the .png seems buggy

Sorry that you felt like your work is not being considered, it's late for changes but we all want the best result so let's see what can be done

review: Needs Information

« Back to merge proposal