Merge lp:~madsrh/ubiquity-slideshow-ubuntu/Yaru-CSS into lp:ubiquity-slideshow-ubuntu
- Yaru-CSS
- Merge into html
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 829 | ||||
Proposed branch: | lp:~madsrh/ubiquity-slideshow-ubuntu/Yaru-CSS | ||||
Merge into: | lp:ubiquity-slideshow-ubuntu | ||||
Diff against target: |
833 lines (+0/-406) 1 file modified
slideshows/ubuntu/slides/link/base.css (+0/-406) |
||||
To merge this branch: | bzr merge lp:~madsrh/ubiquity-slideshow-ubuntu/Yaru-CSS | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Approve | ||
Will Cooke (community) | Disapprove | ||
Review via email: mp+355913@code.launchpad.net |
Commit message
Fixes the colors to match the Yaru theme.
Description of the change
- 828. By MadsRH
-
added Suru icons
MadsRH (madsrh) wrote : | # |
I hope you will reconsider approving the fix. As you mentioned it's pretty straightforward.
We've been working on this for months (as you know from Github) and just three weeks ago you wrote "the slideshow won't get updated until after UI freeze at the earliest". You pushed the screenshots yourself three days ago and now it's too late - it seems like a VERY small window!
Although this isn't as evident with a 18.10 wallpaper as with 18.04, this CSS also fixes the issue with orange hyperlinks on orange background and outdated icons.
We all just want Ubuntu to shine!
MadsRH (madsrh) wrote : | # |
I can see that you pushed an update to the screenshots and I fail to see how this is different than the updating the icons. Will you merge the icons pngs ONLY, if I create a seperate MR for that?
Regarding the CSS: I don't understand what could break from the three hex colors, that cannot be fixed/reverted in the 16 days til release - but it's your call.
Adolfo Jayme Barrientos (fitojb) wrote : | # |
Indeed, what Canonical does to contributors is BS.
Sebastien Bacher (seb128) wrote : | # |
@Adolfo, that comment is not really useful nor constructive, please keep those away from reviews
@MadsRH, looking at the changes I've some comments/questions
- the commit message/description doesn't really convey why we need those changes. In fact the messages speaks about color but the diff includes new icons?
- we already got a recent icons refresh with https:/
- where are the icons coming from?
- why are the css changes needed?
- also the file permissions changes to +x on the .png seems buggy
Sorry that you felt like your work is not being considered, it's late for changes but we all want the best result so let's see what can be done
MadsRH (madsrh) wrote : | # |
Thank you for the reply Sebastien!
> the commit message/description doesn't really convey why we need those changes.
> why are the css changes needed?
The current ubiquity slideshow uses colors from Ambiance for background, hyperlink and title. These were updated to match the new theme "Yaru".
> In fact the messages speaks about color but the diff includes new icons?
Sorry about that. The icons needs updating too because the new theme ships with Suru icons.
This is my very first commit EVER using Launchpad! I'm not a developer, but the though of seeing the new theme (that we spend 11 months working on) mixed with Ambiance styling, was so depressing that I read up on Launchpad documentation to push this fix myself.
I understand now, that I should have added the icons in a seperate MR or at least added them to the description.
> where are the icons coming from?
Sams Suru repo https:/
> - we already got a recent icons refresh with ... how is that different?
I simply didn't know! I tried the daily build and it still uses the old icons. I'll remove the Chromium and Firefox and only leave the Suru icons. Should I remove all the icons? Do you want a seperate MR for these?
> also the file permissions changes to +x on the .png seems buggy
Again, I didn't know, but it is noted that I need to check file permissions. I was just keen to push this because no one else did.
> Sorry that you felt like your work is not being considered, it's late for changes but we all want the best result so let's see what can be done.
+1 We really do and don't be sorry. Your workflow (you, as in Canonical) uses Launchpad, we use Github and the Community Hub (the mockups and code was there for months), so it's just a matter of learning to working together.
Sebastien Bacher (seb128) wrote : | # |
Thanks for the reply, I'm wrapping my work day but I've another look at those changes tomorrow!
MadsRH (madsrh) wrote : | # |
Sorry for the mess! Source for the icons can be found here:
https:/
https:/
https:/
https:/
https:/
Sebastien Bacher (seb128) wrote : | # |
K, that looks fine to me. The base.css being removed and added is probably wrong use of bzr, I fixed that locally before merging so it shows as a proper diff on that file. Thanks for the work and sorry for the frustrating first reply
Preview Diff
1 | === modified file 'slideshows/ubuntu/slides/icons/access.png' |
2 | Binary files slideshows/ubuntu/slides/icons/access.png 2015-04-01 00:01:34 +0000 and slideshows/ubuntu/slides/icons/access.png 2018-10-03 22:50:43 +0000 differ |
3 | === modified file 'slideshows/ubuntu/slides/icons/languages.png' |
4 | Binary files slideshows/ubuntu/slides/icons/languages.png 2015-04-01 00:01:34 +0000 and slideshows/ubuntu/slides/icons/languages.png 2018-10-03 22:50:43 +0000 differ |
5 | === modified file 'slideshows/ubuntu/slides/icons/pitivi.png' |
6 | Binary files slideshows/ubuntu/slides/icons/pitivi.png 2015-04-01 00:01:34 +0000 and slideshows/ubuntu/slides/icons/pitivi.png 2018-10-03 22:50:43 +0000 differ |
7 | === modified file 'slideshows/ubuntu/slides/icons/rhythmbox.png' |
8 | Binary files slideshows/ubuntu/slides/icons/rhythmbox.png 2015-04-01 00:01:34 +0000 and slideshows/ubuntu/slides/icons/rhythmbox.png 2018-10-03 22:50:43 +0000 differ |
9 | === modified file 'slideshows/ubuntu/slides/icons/shotwell.png' |
10 | Binary files slideshows/ubuntu/slides/icons/shotwell.png 2015-04-01 00:01:34 +0000 and slideshows/ubuntu/slides/icons/shotwell.png 2018-10-03 22:50:43 +0000 differ |
11 | === modified file 'slideshows/ubuntu/slides/icons/themes.png' |
12 | Binary files slideshows/ubuntu/slides/icons/themes.png 2015-04-01 00:01:34 +0000 and slideshows/ubuntu/slides/icons/themes.png 2018-10-03 22:50:43 +0000 differ |
13 | === added file 'slideshows/ubuntu/slides/link/base.css' |
14 | --- slideshows/ubuntu/slides/link/base.css 1970-01-01 00:00:00 +0000 |
15 | +++ slideshows/ubuntu/slides/link/base.css 2018-10-03 22:50:43 +0000 |
16 | @@ -0,0 +1,406 @@ |
17 | +html, body, div, span, applet, object, iframe, |
18 | +h1, h2, h3, h4, h5, h6, p, blockquote, pre, |
19 | +a, abbr, acronym, address, big, cite, code, |
20 | +del, dfn, em, font, img, ins, kbd, q, s, samp, |
21 | +small, strike, strong, sub, sup, tt, var, |
22 | +b, u, i, center, |
23 | +dl, dt, dd, ol, ul, li, |
24 | +fieldset, form, label, legend, |
25 | +table, caption, tbody, tfoot, thead, tr, th, td { |
26 | + margin:0; |
27 | + padding:0; |
28 | + border:0; |
29 | + outline:0; |
30 | + font-size: 100%; |
31 | + font-style:normal; |
32 | + text-decoration:none; |
33 | + font-weight:normal; |
34 | + vertical-align:baseline; |
35 | + background:transparent; |
36 | +} |
37 | +ol, ul { |
38 | + list-style:none; |
39 | +} |
40 | + |
41 | + |
42 | + |
43 | +html, body { |
44 | + margin:0; |
45 | + padding:0; |
46 | + |
47 | + background-color:#F7F6F6; |
48 | + |
49 | + font-family:'Ubuntu', 'UbuntuBeta', sans-serif; |
50 | + font-size:12px; |
51 | + line-height:1.4em; |
52 | + |
53 | + color:#333333; |
54 | + |
55 | + /* no reason to expose this extra stuff to the user */ |
56 | + -webkit-user-select:none; |
57 | + -moz-user-select:none; |
58 | + user-select:none; |
59 | + cursor:default; |
60 | +} |
61 | + |
62 | +/* |
63 | +Hyperlink-style text |
64 | +*/ |
65 | +a { |
66 | + color:#19B6EE; |
67 | + text-decoration:none; |
68 | + display:inline; |
69 | +} |
70 | + |
71 | +.text a:hover { |
72 | + text-decoration:underline; |
73 | +} |
74 | + |
75 | +strong { |
76 | + font-weight: bolder; |
77 | +} |
78 | + |
79 | +#wrapper { |
80 | + position:absolute; |
81 | + |
82 | + width:752px; |
83 | + height:100%; |
84 | +} |
85 | + |
86 | +#slideshow { |
87 | + width:752px; |
88 | + min-height:442px; |
89 | + height:100%; |
90 | + overflow:hidden; |
91 | +} |
92 | +#slideshow > div { |
93 | + position:absolute; |
94 | + width:100%; |
95 | + height:100%; |
96 | +} |
97 | + |
98 | +.control-arrow { |
99 | + display:block; |
100 | + position:absolute; |
101 | + |
102 | + z-index:100; |
103 | + top:218px; |
104 | + height:64px; |
105 | + width:33px; |
106 | + |
107 | + background-repeat:no-repeat; |
108 | + cursor:pointer; |
109 | +} |
110 | +.control-arrow.disabled { |
111 | + cursor:default; |
112 | +} |
113 | +.control-arrow:hover { |
114 | + background-position: 0px -65px; |
115 | +} |
116 | +.control-arrow:active { |
117 | + background-position: 0px -130px; |
118 | +} |
119 | +.control-arrow#prev-slide { |
120 | + background-image:url('arrow-back.png'); |
121 | + left:0px; |
122 | +} |
123 | +.control-arrow#next-slide { |
124 | + background-image:url('arrow-next.png'); |
125 | + left:719px; /* 752px - 33px */ |
126 | +} |
127 | + |
128 | +/* Fixed container for a slide's title */ |
129 | +.header { |
130 | + display:table; /* this is a bit evil, but it lets us vertically centre stuff */ |
131 | + position:absolute; |
132 | + /* FIXME: better to use position:relative here and for #main. |
133 | + Need to have a specific maximum height, though, |
134 | + which isn't working with display:table */ |
135 | + top:0px; |
136 | + width:100%; |
137 | + height:68px; |
138 | + background-color:#2b2929; |
139 | +} |
140 | + |
141 | +.header > .slidetitle { |
142 | + display:table-cell; |
143 | + padding:0px 25px; |
144 | + vertical-align:middle; |
145 | + |
146 | + font-size:24px; |
147 | + line-height:30px; |
148 | + font-weight:normal; |
149 | + color:#f9f9f9; |
150 | +} |
151 | +.header > .slidetitle img { |
152 | + display: block; |
153 | +} |
154 | + |
155 | +.main { |
156 | + position:absolute; |
157 | + top:70px; /* 68px + 2px margin */ |
158 | + bottom:2px; |
159 | + left:2px; |
160 | + right:2px; |
161 | + min-height:370px; /* 442px (from #slideshow) - 70px - 2px */ |
162 | + |
163 | + /* move this to #slideshow if we don't want the background image to move with slides */ |
164 | + background-image:url('background.png'); |
165 | +} |
166 | + |
167 | +.main.wide { |
168 | + top:68px; |
169 | + left:0px; |
170 | + right:0px; |
171 | + bottom:0px; |
172 | + background-image:none; |
173 | +} |
174 | + |
175 | +/* |
176 | +A slide's body text goes inside here. |
177 | +Inner space is 224px wide. |
178 | +*/ |
179 | +.main > .text { |
180 | + position:absolute; |
181 | + z-index:10; |
182 | + top:25px; |
183 | + left:36px; |
184 | + width:248px; |
185 | + bottom:35px; |
186 | + min-height:329px; /* 369 - 25 - 15 (for bottom) */ |
187 | + overflow:auto; |
188 | +} |
189 | + |
190 | +.text > div { |
191 | + margin-bottom:8px; |
192 | + padding:6px 12px; |
193 | + background-color:#F7F6F6; |
194 | +} |
195 | +.text > div:last-child { |
196 | + margin-bottom:0px; |
197 | +} |
198 | + |
199 | +.text > div > .subtitle { |
200 | + padding-bottom:2px; |
201 | + margin-bottom:5px; |
202 | + font-size:inherit; |
203 | + font-weight:normal; |
204 | + text-decoration:none; |
205 | + border-bottom:#333333 dotted 1px; |
206 | +} |
207 | + |
208 | +.main.wide > .text { |
209 | + top:25px; |
210 | + width:350px; |
211 | +} |
212 | + |
213 | +.main.wide > .text > div { |
214 | + background:none; |
215 | + font-size:16px; |
216 | + line-height:1.2em; |
217 | + color:#F7F6F6; |
218 | + text-shadow:1px 1px 2px #333333; |
219 | +} |
220 | + |
221 | +.featured ul { |
222 | + display:table; |
223 | +} |
224 | +.featured li { |
225 | + display:table-row; |
226 | +} |
227 | +.featured li > * { |
228 | + padding-bottom:12px; |
229 | +} |
230 | +.featured li .icon { |
231 | + display:table-cell; |
232 | + width:24px; |
233 | + height:auto; |
234 | + padding-right:12px; |
235 | +} |
236 | +.featured li .caption { |
237 | + display:table-cell; |
238 | + vertical-align:middle; |
239 | +} |
240 | + |
241 | +/* Expects screenshot to be 448x304 px */ |
242 | +.main > .screenshot { |
243 | + position:absolute; |
244 | + top:25px; |
245 | + right:-2px; /* offsets 2px margin of .main */ |
246 | + |
247 | + z-index:2; |
248 | + |
249 | + -webkit-box-shadow:#999999 0px 0px 5px; |
250 | + -moz-box-shadow:#999999 0px 0px 5px; |
251 | + box-shadow:#999999 0px 0px 5px; |
252 | +} |
253 | + |
254 | +/* Expects screenshot to be 748x370 px */ |
255 | +.main.wide > .background { |
256 | + top:0px; |
257 | + right:0px; |
258 | + width:100%; |
259 | + height:auto; |
260 | + -webkit-box-shadow:none; |
261 | + -moz-box-shadow:none; |
262 | + box-shadow:none; |
263 | + |
264 | + z-index:0; |
265 | +} |
266 | + |
267 | +.main.wide > .twitter-stream { |
268 | + display:none; /* always revealed by javascript */ |
269 | + |
270 | + position:absolute; |
271 | + width:334px; |
272 | + height:304px; /* 304 - 22 (for .twitter-stream-input) */ |
273 | + top:25px; |
274 | + right:16px; |
275 | + z-index:2; |
276 | + |
277 | + padding:0 6px; |
278 | + |
279 | + color:#eee; |
280 | +} |
281 | + |
282 | +.twitter-stream .twitter-stream-header { |
283 | + display:block; |
284 | + padding:6px 2px 0px 2px; |
285 | +} |
286 | +.twitter-stream .twitter-stream-header h2 { |
287 | + display:inline; |
288 | + color:#fff; |
289 | + |
290 | + font-size:16px; |
291 | +} |
292 | +.twitter-stream .twitter-stream-header img { |
293 | + opacity:0.6; |
294 | + float:right; |
295 | + |
296 | + margin-left:22px; |
297 | + |
298 | + -webkit-transition:opacity 150ms linear; |
299 | +} |
300 | +.twitter-stream .twitter-stream-header:hover img { |
301 | + opacity:0.8; |
302 | +} |
303 | + |
304 | +.twitter-stream .twitter-stream-tweets { |
305 | + overflow:hidden; |
306 | + |
307 | + height:100%; |
308 | + |
309 | + /* Warning: this is non-standard, only works in Webkit, could break at any time */ |
310 | + -webkit-mask-image:-webkit-linear-gradient(top, rgba(0,0,0,1) 0%, rgba(0,0,0,1) 70%, rgba(0,0,0,0) 100%); |
311 | +} |
312 | + |
313 | +.twitter-stream .tweet { |
314 | + padding:6px 2px; |
315 | + border-bottom:1px dotted rgba(255, 255, 255, 0.2); |
316 | +} |
317 | +.tweet .tweet-avatar { |
318 | + display:table-cell; |
319 | + vertical-align:top; |
320 | + padding:0 6px; |
321 | +} |
322 | + |
323 | +.tweet .tweet-author-details { |
324 | + display:inline-block; |
325 | +} |
326 | + |
327 | +.tweet .tweet-author-name { |
328 | + color:#fff; |
329 | + font-weight:bold; |
330 | +} |
331 | +.tweet .tweet-author-id { |
332 | + color:#bbb; |
333 | + font-weight:normal; |
334 | + margin-left:1em; |
335 | + font-size:0.9em; |
336 | +} |
337 | + |
338 | +.tweet .tweet-text { |
339 | + display:block; |
340 | +} |
341 | + |
342 | +.tweet .tweet-text a { |
343 | + color:#bbb; |
344 | +} |
345 | + |
346 | +.twitter-stream input.twitter-stream-input { |
347 | + width:100%; |
348 | + |
349 | + -webkit-box-sizing:border-box; |
350 | + padding:4px 2px 4px 22px; |
351 | + |
352 | + background-color:rgba(0, 0, 0, 0); |
353 | + border:none; |
354 | + outline:none; |
355 | + color:#fff; |
356 | + |
357 | + background-image:url('twitter-bird-16.png'); |
358 | + background-position:left center; |
359 | + background-repeat:no-repeat; |
360 | +} |
361 | +.twitter-stream input.twitter-stream-input:focus { |
362 | + background-color:rgba(0, 0, 0, 0.1); |
363 | +} |
364 | + |
365 | +/* |
366 | +This rule disables drag-and-drop for images. See bug #448703. |
367 | +*/ |
368 | +img { |
369 | + -webkit-user-drag:none; |
370 | +} |
371 | + |
372 | + |
373 | + |
374 | +/* RTL stuff */ |
375 | +.rtl { |
376 | + direction:rtl; |
377 | +} |
378 | + |
379 | +.rtl .control-arrow#prev-slide { |
380 | + background-image:url('arrow-next.png'); |
381 | + left:719px; |
382 | +} |
383 | +.rtl .control-arrow#next-slide { |
384 | + background-image:url('arrow-back.png'); |
385 | + left:0px; /* 752px - 33px */ |
386 | +} |
387 | + |
388 | +.rtl .main > .text { |
389 | + left:auto; |
390 | + right:36px; |
391 | +} |
392 | + |
393 | +.rtl .main > .screenshot { |
394 | + right:auto; |
395 | + left:-2px; |
396 | +} |
397 | + |
398 | +.rtl .featured li .icon { |
399 | + padding-right:0px; |
400 | + padding-left:12px; |
401 | +} |
402 | + |
403 | +.rtl .main.wide > .twitter-stream { |
404 | + right:auto; |
405 | + left:16px; |
406 | +} |
407 | + |
408 | +.rtl .twitter-stream .twitter-stream-header img { |
409 | + float:left; |
410 | + margin-left:0; |
411 | + margin-right:22px; |
412 | +} |
413 | + |
414 | +.rtl .twitter-stream input.twitter-stream-input { |
415 | + padding:4px 22px 4px 2px; |
416 | + background-position:right center; |
417 | +} |
418 | + |
419 | +.l10n-string { |
420 | + display:none; |
421 | +} |
422 | + |
423 | |
424 | === removed file 'slideshows/ubuntu/slides/link/base.css' |
425 | --- slideshows/ubuntu/slides/link/base.css 2015-04-01 00:03:36 +0000 |
426 | +++ slideshows/ubuntu/slides/link/base.css 1970-01-01 00:00:00 +0000 |
427 | @@ -1,406 +0,0 @@ |
428 | -html, body, div, span, applet, object, iframe, |
429 | -h1, h2, h3, h4, h5, h6, p, blockquote, pre, |
430 | -a, abbr, acronym, address, big, cite, code, |
431 | -del, dfn, em, font, img, ins, kbd, q, s, samp, |
432 | -small, strike, strong, sub, sup, tt, var, |
433 | -b, u, i, center, |
434 | -dl, dt, dd, ol, ul, li, |
435 | -fieldset, form, label, legend, |
436 | -table, caption, tbody, tfoot, thead, tr, th, td { |
437 | - margin:0; |
438 | - padding:0; |
439 | - border:0; |
440 | - outline:0; |
441 | - font-size: 100%; |
442 | - font-style:normal; |
443 | - text-decoration:none; |
444 | - font-weight:normal; |
445 | - vertical-align:baseline; |
446 | - background:transparent; |
447 | -} |
448 | -ol, ul { |
449 | - list-style:none; |
450 | -} |
451 | - |
452 | - |
453 | - |
454 | -html, body { |
455 | - margin:0; |
456 | - padding:0; |
457 | - |
458 | - background-color:#F7F6F6; |
459 | - |
460 | - font-family:'Ubuntu', 'UbuntuBeta', sans-serif; |
461 | - font-size:12px; |
462 | - line-height:1.4em; |
463 | - |
464 | - color:#333333; |
465 | - |
466 | - /* no reason to expose this extra stuff to the user */ |
467 | - -webkit-user-select:none; |
468 | - -moz-user-select:none; |
469 | - user-select:none; |
470 | - cursor:default; |
471 | -} |
472 | - |
473 | -/* |
474 | -Hyperlink-style text |
475 | -*/ |
476 | -a { |
477 | - color:#DD4814; |
478 | - text-decoration:none; |
479 | - display:inline; |
480 | -} |
481 | - |
482 | -.text a:hover { |
483 | - text-decoration:underline; |
484 | -} |
485 | - |
486 | -strong { |
487 | - font-weight: bolder; |
488 | -} |
489 | - |
490 | -#wrapper { |
491 | - position:absolute; |
492 | - |
493 | - width:752px; |
494 | - height:100%; |
495 | -} |
496 | - |
497 | -#slideshow { |
498 | - width:752px; |
499 | - min-height:442px; |
500 | - height:100%; |
501 | - overflow:hidden; |
502 | -} |
503 | -#slideshow > div { |
504 | - position:absolute; |
505 | - width:100%; |
506 | - height:100%; |
507 | -} |
508 | - |
509 | -.control-arrow { |
510 | - display:block; |
511 | - position:absolute; |
512 | - |
513 | - z-index:100; |
514 | - top:218px; |
515 | - height:64px; |
516 | - width:33px; |
517 | - |
518 | - background-repeat:no-repeat; |
519 | - cursor:pointer; |
520 | -} |
521 | -.control-arrow.disabled { |
522 | - cursor:default; |
523 | -} |
524 | -.control-arrow:hover { |
525 | - background-position: 0px -65px; |
526 | -} |
527 | -.control-arrow:active { |
528 | - background-position: 0px -130px; |
529 | -} |
530 | -.control-arrow#prev-slide { |
531 | - background-image:url('arrow-back.png'); |
532 | - left:0px; |
533 | -} |
534 | -.control-arrow#next-slide { |
535 | - background-image:url('arrow-next.png'); |
536 | - left:719px; /* 752px - 33px */ |
537 | -} |
538 | - |
539 | -/* Fixed container for a slide's title */ |
540 | -.header { |
541 | - display:table; /* this is a bit evil, but it lets us vertically centre stuff */ |
542 | - position:absolute; |
543 | - /* FIXME: better to use position:relative here and for #main. |
544 | - Need to have a specific maximum height, though, |
545 | - which isn't working with display:table */ |
546 | - top:0px; |
547 | - width:100%; |
548 | - height:68px; |
549 | - background-color:#3C3B37; |
550 | -} |
551 | - |
552 | -.header > .slidetitle { |
553 | - display:table-cell; |
554 | - padding:0px 25px; |
555 | - vertical-align:middle; |
556 | - |
557 | - font-size:24px; |
558 | - line-height:30px; |
559 | - font-weight:normal; |
560 | - color:#DED9CB; |
561 | -} |
562 | -.header > .slidetitle img { |
563 | - display: block; |
564 | -} |
565 | - |
566 | -.main { |
567 | - position:absolute; |
568 | - top:70px; /* 68px + 2px margin */ |
569 | - bottom:2px; |
570 | - left:2px; |
571 | - right:2px; |
572 | - min-height:370px; /* 442px (from #slideshow) - 70px - 2px */ |
573 | - |
574 | - /* move this to #slideshow if we don't want the background image to move with slides */ |
575 | - background-image:url('background.png'); |
576 | -} |
577 | - |
578 | -.main.wide { |
579 | - top:68px; |
580 | - left:0px; |
581 | - right:0px; |
582 | - bottom:0px; |
583 | - background-image:none; |
584 | -} |
585 | - |
586 | -/* |
587 | -A slide's body text goes inside here. |
588 | -Inner space is 224px wide. |
589 | -*/ |
590 | -.main > .text { |
591 | - position:absolute; |
592 | - z-index:10; |
593 | - top:25px; |
594 | - left:36px; |
595 | - width:248px; |
596 | - bottom:35px; |
597 | - min-height:329px; /* 369 - 25 - 15 (for bottom) */ |
598 | - overflow:auto; |
599 | -} |
600 | - |
601 | -.text > div { |
602 | - margin-bottom:8px; |
603 | - padding:6px 12px; |
604 | - background-color:#F7F6F6; |
605 | -} |
606 | -.text > div:last-child { |
607 | - margin-bottom:0px; |
608 | -} |
609 | - |
610 | -.text > div > .subtitle { |
611 | - padding-bottom:2px; |
612 | - margin-bottom:5px; |
613 | - font-size:inherit; |
614 | - font-weight:normal; |
615 | - text-decoration:none; |
616 | - border-bottom:#333333 dotted 1px; |
617 | -} |
618 | - |
619 | -.main.wide > .text { |
620 | - top:25px; |
621 | - width:350px; |
622 | -} |
623 | - |
624 | -.main.wide > .text > div { |
625 | - background:none; |
626 | - font-size:16px; |
627 | - line-height:1.2em; |
628 | - color:#F7F6F6; |
629 | - text-shadow:1px 1px 2px #333333; |
630 | -} |
631 | - |
632 | -.featured ul { |
633 | - display:table; |
634 | -} |
635 | -.featured li { |
636 | - display:table-row; |
637 | -} |
638 | -.featured li > * { |
639 | - padding-bottom:12px; |
640 | -} |
641 | -.featured li .icon { |
642 | - display:table-cell; |
643 | - width:24px; |
644 | - height:auto; |
645 | - padding-right:12px; |
646 | -} |
647 | -.featured li .caption { |
648 | - display:table-cell; |
649 | - vertical-align:middle; |
650 | -} |
651 | - |
652 | -/* Expects screenshot to be 448x304 px */ |
653 | -.main > .screenshot { |
654 | - position:absolute; |
655 | - top:25px; |
656 | - right:-2px; /* offsets 2px margin of .main */ |
657 | - |
658 | - z-index:2; |
659 | - |
660 | - -webkit-box-shadow:#999999 0px 0px 5px; |
661 | - -moz-box-shadow:#999999 0px 0px 5px; |
662 | - box-shadow:#999999 0px 0px 5px; |
663 | -} |
664 | - |
665 | -/* Expects screenshot to be 748x370 px */ |
666 | -.main.wide > .background { |
667 | - top:0px; |
668 | - right:0px; |
669 | - width:100%; |
670 | - height:auto; |
671 | - -webkit-box-shadow:none; |
672 | - -moz-box-shadow:none; |
673 | - box-shadow:none; |
674 | - |
675 | - z-index:0; |
676 | -} |
677 | - |
678 | -.main.wide > .twitter-stream { |
679 | - display:none; /* always revealed by javascript */ |
680 | - |
681 | - position:absolute; |
682 | - width:334px; |
683 | - height:304px; /* 304 - 22 (for .twitter-stream-input) */ |
684 | - top:25px; |
685 | - right:16px; |
686 | - z-index:2; |
687 | - |
688 | - padding:0 6px; |
689 | - |
690 | - color:#eee; |
691 | -} |
692 | - |
693 | -.twitter-stream .twitter-stream-header { |
694 | - display:block; |
695 | - padding:6px 2px 0px 2px; |
696 | -} |
697 | -.twitter-stream .twitter-stream-header h2 { |
698 | - display:inline; |
699 | - color:#fff; |
700 | - |
701 | - font-size:16px; |
702 | -} |
703 | -.twitter-stream .twitter-stream-header img { |
704 | - opacity:0.6; |
705 | - float:right; |
706 | - |
707 | - margin-left:22px; |
708 | - |
709 | - -webkit-transition:opacity 150ms linear; |
710 | -} |
711 | -.twitter-stream .twitter-stream-header:hover img { |
712 | - opacity:0.8; |
713 | -} |
714 | - |
715 | -.twitter-stream .twitter-stream-tweets { |
716 | - overflow:hidden; |
717 | - |
718 | - height:100%; |
719 | - |
720 | - /* Warning: this is non-standard, only works in Webkit, could break at any time */ |
721 | - -webkit-mask-image:-webkit-linear-gradient(top, rgba(0,0,0,1) 0%, rgba(0,0,0,1) 70%, rgba(0,0,0,0) 100%); |
722 | -} |
723 | - |
724 | -.twitter-stream .tweet { |
725 | - padding:6px 2px; |
726 | - border-bottom:1px dotted rgba(255, 255, 255, 0.2); |
727 | -} |
728 | -.tweet .tweet-avatar { |
729 | - display:table-cell; |
730 | - vertical-align:top; |
731 | - padding:0 6px; |
732 | -} |
733 | - |
734 | -.tweet .tweet-author-details { |
735 | - display:inline-block; |
736 | -} |
737 | - |
738 | -.tweet .tweet-author-name { |
739 | - color:#fff; |
740 | - font-weight:bold; |
741 | -} |
742 | -.tweet .tweet-author-id { |
743 | - color:#bbb; |
744 | - font-weight:normal; |
745 | - margin-left:1em; |
746 | - font-size:0.9em; |
747 | -} |
748 | - |
749 | -.tweet .tweet-text { |
750 | - display:block; |
751 | -} |
752 | - |
753 | -.tweet .tweet-text a { |
754 | - color:#bbb; |
755 | -} |
756 | - |
757 | -.twitter-stream input.twitter-stream-input { |
758 | - width:100%; |
759 | - |
760 | - -webkit-box-sizing:border-box; |
761 | - padding:4px 2px 4px 22px; |
762 | - |
763 | - background-color:rgba(0, 0, 0, 0); |
764 | - border:none; |
765 | - outline:none; |
766 | - color:#fff; |
767 | - |
768 | - background-image:url('twitter-bird-16.png'); |
769 | - background-position:left center; |
770 | - background-repeat:no-repeat; |
771 | -} |
772 | -.twitter-stream input.twitter-stream-input:focus { |
773 | - background-color:rgba(0, 0, 0, 0.1); |
774 | -} |
775 | - |
776 | -/* |
777 | -This rule disables drag-and-drop for images. See bug #448703. |
778 | -*/ |
779 | -img { |
780 | - -webkit-user-drag:none; |
781 | -} |
782 | - |
783 | - |
784 | - |
785 | -/* RTL stuff */ |
786 | -.rtl { |
787 | - direction:rtl; |
788 | -} |
789 | - |
790 | -.rtl .control-arrow#prev-slide { |
791 | - background-image:url('arrow-next.png'); |
792 | - left:719px; |
793 | -} |
794 | -.rtl .control-arrow#next-slide { |
795 | - background-image:url('arrow-back.png'); |
796 | - left:0px; /* 752px - 33px */ |
797 | -} |
798 | - |
799 | -.rtl .main > .text { |
800 | - left:auto; |
801 | - right:36px; |
802 | -} |
803 | - |
804 | -.rtl .main > .screenshot { |
805 | - right:auto; |
806 | - left:-2px; |
807 | -} |
808 | - |
809 | -.rtl .featured li .icon { |
810 | - padding-right:0px; |
811 | - padding-left:12px; |
812 | -} |
813 | - |
814 | -.rtl .main.wide > .twitter-stream { |
815 | - right:auto; |
816 | - left:16px; |
817 | -} |
818 | - |
819 | -.rtl .twitter-stream .twitter-stream-header img { |
820 | - float:left; |
821 | - margin-left:0; |
822 | - margin-right:22px; |
823 | -} |
824 | - |
825 | -.rtl .twitter-stream input.twitter-stream-input { |
826 | - padding:4px 22px 4px 2px; |
827 | - background-position:right center; |
828 | -} |
829 | - |
830 | -.l10n-string { |
831 | - display:none; |
832 | -} |
833 | - |
Thank you very much for creating the MP in Launchpad.
While on the face of it this is a straightforward and small change to the CSS, this change comes very late in the release process and might have a chance, however small, of breaking something somewhere for someone.
I'm afraid I will NACK this request for Cosmic. It's my feeling that we're just too close to release to risk a change in the installer, no matter how small.
Sorry.
This can go in early next cycle.