Code review comment for lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6

Revision history for this message
Olivier Mattelaer (olivier-mattelaer) wrote :

Hi Marco,

You can ask him by email if he wants to react on that.

Cheers,

Olivier

On Sep 5, 2014, at 1:36 PM, marco zaro <email address hidden> wrote:

> ok thanks!
> shall we wait for any comment from juan?
>
>
> Marco Zaro
>
>
> On Fri, Sep 5, 2014 at 2:34 PM, Olivier Mattelaer <
> <email address hidden>> wrote:
>
>> Review: Approve
>>
>> Hi Marco,
>>
>> so this was indeed my fault.
>> I have put a nice message error for the kind of stupid error that I did.
>>
>> I still can not compile lhapdf6. So I will abstain on that part but
>> lhapdf5 works very well now :-)
>> So please take a quick look at my fix and go ahead for the merge.
>>
>> Cheers and thanks,
>>
>> Olivier
>>
>> --
>>
>> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
>> Your team MadDevelopers is subscribed to branch
>> lp:~maddevelopers/mg5amcnlo/2.2.0.
>>
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
> You are reviewing the proposed merge of lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6 into lp:~maddevelopers/mg5amcnlo/2.2.0.

« Back to merge proposal