Merge lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6 into lp:~maddevelopers/mg5amcnlo/2.2.0

[marco zaro]

lhapdf6 is enabled

[Rikkert Frederix (frederix)]

Hi Marco,

It's not working correctly on my machine:

INFO: Starting run
INFO: Compiling the code
INFO: Using LHAPDF v6.1.4 interface for PDFs
INFO: Trying to download NNPDF23_nlo_as_0119
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
WARNING: Could not download NNPDF23_nlo_as_0119 into /usr/local/share/LHAPDF. Trying to save it locally
INFO: Trying to download NNPDF23_nlo_as_0119
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
WARNING: Could not download NNPDF23_nlo_as_0119 into /Users/frederix/Documents/Physics/aMCatNLO/2.1.2-lhapdf6/PROCNLO_sm_1/lib/PDFsets. Trying to save it locally
INFO: Trying to download NNPDF23_nlo_as_0119
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
WARNING: Could not download NNPDF23_nlo_as_0119 into /Users/frederix/Documents/Physics/aMCatNLO/2.1.2-lhapdf6/PROCNLO_sm_1/lib/PDFsets. Trying to save it locally
INFO: Trying to download NNPDF23_nlo_as_0119
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
ERROR: Could not write to /usr/local/share/LHAPDF/NNPDF23_nlo_as_0119.tar.gz
WARNING: Could not download NNPDF23_nlo_as_0119 into /Users/frederix/Documents/Physics/aMCatNLO/2.1.2-lhapdf6/PROCNLO_sm_1/lib/PDFsets. Trying to save it locally

and it keeps doing this. I have the NNPDF set installed, so I don't understand why he cannot find it.

Cheers,
Rik

[Rikkert Frederix (frederix)]

review: Needs Fixing

[marco zaro (marco-zaro)]

Ciao Rik,
thanks for trying
ehm,
the problem is the following:
while for lhapdf5 the lhapdf-getdata tries to install the dataset in the current working dir, the corresponding command (lhapdf install, or lhapdf get) for v6 always tries to store it in the shared directory, which, in your case, is write protected…
for v5 mg tries first to install it system-wise, then, if the lhapdf/.../PDFsets dir is not writable it saves it locally (lib/PDFsets).
I am not aware of a way to solve this problem still using lhapdf -related commands for v6.
Of course, one way to solve is either to have a local installation of lhapdf6, or to get write permissions in the /usr/local/share/LHAPDF dir.

Cheers,

Marco

On 23 Aug 2014, at 22:03, Rikkert Frederix <email address hidden> wrote:

> Review: Needs Fixing
>
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
> Your team MadDevelopers is subscribed to branch lp:~maddevelopers/mg5amcnlo/2.2.0.

[Rikkert Frederix (frederix)]

Hi Marco,

Ok, I understand. It looks like it is indeed no longer possible to have a local download of a PDFset for LHAPDF6. Maybe we could ask Andy if this will become available in future versions. Anyway, for now there should be a proper message explaining this when the code is trying, because the code goes into an infinite loop now.

Cheers,
Rik

review: Needs Fixing

[lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6]

272. By marco zaro on 2014-08-26

the pdf set is installed locally only for v5 (for v6 an error is raised)

[marco zaro (marco-zaro)]

Ciao Rik,
I have added an error message for the moment.
I’ll write Andy and ask him.
Cheers,

Marco

On 23 Aug 2014, at 23:08, Rikkert Frederix <email address hidden> wrote:

> Review: Needs Fixing
>
> Hi Marco,
>
> Ok, I understand. It looks like it is indeed no longer possible to have a local download of a PDFset for LHAPDF6. Maybe we could ask Andy if this will become available in future versions. Anyway, for now there should be a proper message explaining this when the code is trying, because the code goes into an infinite loop now.
>
> Cheers,
> Rik
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
> Your team MadDevelopers is subscribed to branch lp:~maddevelopers/mg5amcnlo/2.2.0.

[Rikkert Frederix (frederix)]

Thanks Marco. I approve this merge.

review: Approve

[Olivier Mattelaer (olivier-mattelaer)]

Just for completion of this review, here is the crash that we need to fix asap (reported in the wrong thread):

generate p p > e+ e-
launch
set pdlabel cteq6l1
launch
set pdlabel lhapd
set lhaid 70251

Cheers,

Olivier

review: Needs Fixing

[lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6]

273. By marco zaro on 2014-09-05

fixed bug related to madevent

the commands
    generate p p > e+ e-
    launch
    set pdlabel cteq6l1
    launch
    set pdlabel lhapdf
    set lhaid 21100
now work

274. By marco zaro on 2014-09-05

merged with 2.2.0 r307

[marco zaro (marco-zaro)]

It should be working now.
Cheers,

M
On 05 Sep 2014, at 13:19, Olivier Mattelaer <email address hidden> wrote:

> Review: Needs Fixing
>
> Just for completion of this review, here is the crash that we need to fix asap (reported in the wrong thread):
>
> generate p p > e+ e-
> launch
> set pdlabel cteq6l1
> launch
> set pdlabel lhapd
> set lhaid 70251
>
> Cheers,
>
> Olivier
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
> Your team MadDevelopers is subscribed to branch lp:~maddevelopers/mg5amcnlo/2.2.0.

[Olivier Mattelaer (olivier-mattelaer)]

Hi Marco,

I'm sorry but this is still not working for me :-(

Olivier

review: Needs Fixing

[Olivier Mattelaer (olivier-mattelaer)]

Hi Marco,

so this was indeed my fault.
I have put a nice message error for the kind of stupid error that I did.

I still can not compile lhapdf6. So I will abstain on that part but lhapdf5 works very well now :-)
So please take a quick look at my fix and go ahead for the merge.

Cheers and thanks,

Olivier

review: Approve

[lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6]

275. By Olivier Mattelaer on 2014-09-05

add a nice error message if the pdlabel is not valid (doesn't need to dig into the fortran log file anymore).

[marco zaro (marco-zaro)]

ok thanks!
shall we wait for any comment from juan?

Marco Zaro

On Fri, Sep 5, 2014 at 2:34 PM, Olivier Mattelaer <
<email address hidden>> wrote:

> Review: Approve
>
> Hi Marco,
>
> so this was indeed my fault.
> I have put a nice message error for the kind of stupid error that I did.
>
> I still can not compile lhapdf6. So I will abstain on that part but
> lhapdf5 works very well now :-)
> So please take a quick look at my fix and go ahead for the merge.
>
> Cheers and thanks,
>
> Olivier
>
> --
>
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
> Your team MadDevelopers is subscribed to branch
> lp:~maddevelopers/mg5amcnlo/2.2.0.
>

[Olivier Mattelaer (olivier-mattelaer)]

Hi Marco,

You can ask him by email if he wants to react on that.

Cheers,

Olivier

On Sep 5, 2014, at 1:36 PM, marco zaro <email address hidden> wrote:

> ok thanks!
> shall we wait for any comment from juan?
>
>
> Marco Zaro
>
>
> On Fri, Sep 5, 2014 at 2:34 PM, Olivier Mattelaer <
> <email address hidden>> wrote:
>
>> Review: Approve
>>
>> Hi Marco,
>>
>> so this was indeed my fault.
>> I have put a nice message error for the kind of stupid error that I did.
>>
>> I still can not compile lhapdf6. So I will abstain on that part but
>> lhapdf5 works very well now :-)
>> So please take a quick look at my fix and go ahead for the merge.
>>
>> Cheers and thanks,
>>
>> Olivier
>>
>> --
>>
>> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
>> Your team MadDevelopers is subscribed to branch
>> lp:~maddevelopers/mg5amcnlo/2.2.0.
>>
>
> --
> https://code.launchpad.net/~maddevelopers/mg5amcnlo/2.1.2-lhapdf6/+merge/231731
> You are reviewing the proposed merge of lp:~maddevelopers/mg5amcnlo/2.1.2-lhapdf6 into lp:~maddevelopers/mg5amcnlo/2.2.0.

=== modified file 'Template/LO/Source/PDF/makefile'
--- Template/LO/Source/PDF/makefile	2014-02-23 03:15:09 +0000
+++ Template/LO/Source/PDF/makefile	2014-09-05 12:34:28 +0000
@@ -23,7 +23,5 @@
 $(LIBDIR)$(LIBRARY): $(PDF)
 	$(call CREATELIB, $@, $^)
 
-clean_lhapdf:
-	rm -f $(LIBDIR)$(LIBRARY)
 clean:
 	$(RM) *.o $(LIBDIR)$(LIBRARY)

=== modified file 'Template/NLO/SubProcesses/ajob_template'
--- Template/NLO/SubProcesses/ajob_template	2014-06-12 16:12:08 +0000
+++ Template/NLO/SubProcesses/ajob_template	2014-09-05 12:34:28 +0000
@@ -84,7 +84,6 @@
 #    link1up MadLoop5_resources
     link1up OLE_order.olc
     link1up param_card.dat
-    link1up libLHAPDF.so
     
 #   check where is the basic file for the creation of input_app.txt
 #       

=== modified file 'UpdateNotes.txt'
--- UpdateNotes.txt	2014-08-23 13:57:35 +0000
+++ UpdateNotes.txt	2014-09-05 12:34:28 +0000
@@ -16,6 +16,10 @@
                 PT: Redesigned shower_card.dat and eliminated modbos options for Herwig6          
                 RF: Change the SPINUP information in the NLO LHEF from 0 to 9 (i.e. sum over helicities)
                 RF: Fixed a bug in the check on the determination of the conflicting BWs.
+                PT: Redesigned shower_card.dat and eliminated modbos options for Herwig6          
+                RF: Change the SPINUP information in the NLO LHEF from 0 to 9 (i.e. sum over helicities)
+                RF: Fixed a bug in the check on the determination of the conflicting BWs.
+                MZ: enabled LHAPDF6 interface 
 
 2.1.2(03/07/14) OM: Fix a bug in ALOHA in presence of customized propagator (Thanks Saurabh)
                 OM: Fixing some compilation issue with MadWeight (Thanks A. Pin)

=== modified file 'madgraph/interface/amcatnlo_run_interface.py'
--- madgraph/interface/amcatnlo_run_interface.py	2014-08-28 13:45:22 +0000
+++ madgraph/interface/amcatnlo_run_interface.py	2014-09-05 12:34:28 +0000
@@ -3212,12 +3212,6 @@
         if os.path.exists(pjoin(self.me_dir,'SubProcesses','OLE_order.olc')):
             input_files.append(pjoin(cwd, 'OLE_order.olc'))
 
-        # LHAPDF dynamic libraries (needed for lhapdf6)
-        lhalibs = ['libLHAPDF.dylib', 'libLHAPDF.so'] 
-        for lib in [pjoin(self.me_dir, 'lib', l) for l in lhalibs \
-           if os.path.exists(pjoin(self.me_dir, 'lib', l))]:
-            input_files.append(lib)
-      
         # File for the loop (might not be present if MadLoop is not used)
         if os.path.exists(pjoin(cwd,'MadLoop5_resources')):
             tf=tarfile.open(pjoin(cwd,'MadLoop5_resources.tar'),'w',

=== modified file 'madgraph/interface/common_run_interface.py'
--- madgraph/interface/common_run_interface.py	2014-07-25 20:20:42 +0000
+++ madgraph/interface/common_run_interface.py	2014-09-05 12:34:28 +0000
@@ -1629,33 +1629,18 @@
 
         if lhapdf_version.startswith('5.'):
             pdfsetsdir = subprocess.Popen([self.options['lhapdf'], '--pdfsets-path'],
-                     stdout = subprocess.PIPE).stdout.read().strip()
-            self.lhapdf_pdfsets = self.get_lhapdf_pdfsets_list(pdfsetsdir)
-            # link the static library in lib
-            lhalib = 'libLHAPDF.a'
-
-        elif lhapdf_version.startswith('6.'):
+                 stdout = subprocess.PIPE).stdout.read().strip()
+        else:
             pdfsetsdir = subprocess.Popen([self.options['lhapdf'], '--datadir'],
-                     stdout = subprocess.PIPE).stdout.read().strip()
-            self.lhapdf_pdfsets = self.get_lhapdf_pdfsets_list(pdfsetsdir)
-            # link the dynamic library in lib
-            if os.path.exists(pjoin(lhalibdir, 'libLHAPDF.so')):
-                lhalib = 'libLHAPDF.so'
-            elif os.path.exists(pjoin(lhalibdir, 'libLHAPDF.dylib')):
-                lhalib = 'libLHAPDF.dylib'
-            else:
-                raise MadGraph5Error('Dynamic library not found for LHAPDF6')
-
-        else:
-            raise MadGraph5Error('Not valid LHAPDF version: %s' % lhapdf_version)
+                 stdout = subprocess.PIPE).stdout.read().strip()
+        
+        self.lhapdf_pdfsets = self.get_lhapdf_pdfsets_list(pdfsetsdir)
+        # link the static library in lib
+        lhalib = 'libLHAPDF.a'
 
         if os.path.exists(pjoin(libdir, lhalib)):
             files.rm(pjoin(libdir, lhalib))
         files.ln(pjoin(lhalibdir, lhalib), libdir)
-        # link the dynamic library for v6 in extra_dirs
-        if lhapdf_version.startswith('6.'):
-            for d in extra_dirs:
-                files.ln(pjoin(libdir, lhalib), pjoin(self.me_dir, d))
         # just create the PDFsets dir, the needed PDF set will be copied at run time
         if not os.path.isdir(pjoin(libdir, 'PDFsets')):
             os.mkdir(pjoin(libdir, 'PDFsets'))
@@ -1682,9 +1667,12 @@
                         'lhaid and PDF_set_min/max in the run_card do not correspond to the' + \
                         'same PDF set. Please check the run_card.')
             except KeyError:
-                raise MadGraph5Error(\
+                if self.lhapdf_version.startswith('5'):
+                    raise MadGraph5Error(\
                         ('invalid lhaid set in th run_card: %d .\nPlease note that some sets' % lhaid) + \
-                    '(eg MSTW 90%CL error sets) \nare not available in aMC@NLO + LHAPDF 5.x.x')
+                         '(eg MSTW 90%CL error sets) \nare not available in aMC@NLO + LHAPDF 5.x.x')
+                else:
+                    logger.debug('%d not found in pdfsets.index' % lhaid)
 
 
         # check if the file exists, otherwise install it:
@@ -1696,13 +1684,17 @@
             except OSError:
                 pdfsets_dir = pjoin(self.me_dir, 'lib', 'PDFsets')
 
-        if pdfsetname and not os.path.exists(pjoin(pdfsets_dir, pdfsetname)):
-            self.install_lhapdf_pdfset(pdfsets_dir, pdfsetname)
-            
-        if os.path.exists(pjoin(pdfsets_dir, pdfsetname)):
-            files.cp(pjoin(pdfsets_dir, pdfsetname), pjoin(self.me_dir, 'lib', 'PDFsets'))
-        elif os.path.exists(pjoin(os.path.dirname(pdfsets_dir), pdfsetname)):
-            files.cp(pjoin(os.path.dirname(pdfsets_dir), pdfsetname), pjoin(self.me_dir, 'lib', 'PDFsets'))
+        #check that the pdfset is not already there
+        if not os.path.exists(pjoin(self.me_dir, 'lib', 'PDFsets', pdfsetname)) and \
+           not os.path.isdir(pjoin(self.me_dir, 'lib', 'PDFsets', pdfsetname)):
+
+            if pdfsetname and not os.path.exists(pjoin(pdfsets_dir, pdfsetname)):
+                self.install_lhapdf_pdfset(pdfsets_dir, pdfsetname)
+
+            if os.path.exists(pjoin(pdfsets_dir, pdfsetname)):
+                files.cp(pjoin(pdfsets_dir, pdfsetname), pjoin(self.me_dir, 'lib', 'PDFsets'))
+            elif os.path.exists(pjoin(os.path.dirname(pdfsets_dir), pdfsetname)):
+                files.cp(pjoin(os.path.dirname(pdfsets_dir), pdfsetname), pjoin(self.me_dir, 'lib', 'PDFsets'))
             
 
     def install_lhapdf_pdfset(self, pdfsets_dir, filename):
@@ -1731,11 +1723,15 @@
            os.path.isdir(pjoin(pdfsets_dir, filename)):
             logger.info('%s successfully downloaded and stored in %s' \
                     % (filename, pdfsets_dir))
-        #otherwise save it locally
-        else:
+        #otherwise (if v5) save it locally
+        elif lhapdf_version.startswith('5.'):
             logger.warning('Could not download %s into %s. Trying to save it locally' \
                     % (filename, pdfsets_dir))
             self.install_lhapdf_pdfset(pjoin(self.me_dir, 'lib', 'PDFsets'), filename)
+        else:
+            raise MadGraph5Error, \
+                'Could not download %s into %s. Please try to install it manually.' \
+                    % (filename, pdfsets_dir)
 
 
     def get_lhapdf_pdfsets_list(self, pdfsets_dir):
@@ -1787,8 +1783,8 @@
                         stdout = subprocess.PIPE).stdout.read().strip()
 
         # this will be removed once some issues in lhapdf6 will be fixed
-        if self.lhapdf_version.startswith('6.'):
-            raise MadGraph5Error('LHAPDF 6 not yet supported. Please use v5.x.x')
+        if self.lhapdf_version.startswith('6.0'):
+            raise MadGraph5Error('LHAPDF 6.0.x not supported. Please use v6.1 or later')
 
         return self.lhapdf_version
 

=== modified file 'madgraph/interface/madevent_interface.py'
--- madgraph/interface/madevent_interface.py	2014-07-02 13:51:34 +0000
+++ madgraph/interface/madevent_interface.py	2014-09-05 12:34:28 +0000
@@ -3524,20 +3524,21 @@
         # limit the number of event to 100k
         self.check_nb_events()
 
+        # this is in order to avoid conflicts between runs with and without
+        # lhapdf
+        misc.compile(['clean4pdf'], cwd = pjoin(self.me_dir, 'Source'))
+        
         # set environment variable for lhapdf.
         if self.run_card['pdlabel'] == "lhapdf":
             os.environ['lhapdf'] = 'True'
             self.link_lhapdf(pjoin(self.me_dir,'lib'))
-            pdfsetsdir = subprocess.Popen('%s --pdfsets-path' % self.options['lhapdf'],
-                    shell = True, stdout = subprocess.PIPE).stdout.read().strip()
+            pdfsetsdir = self.get_lhapdf_pdfsetsdir()
             lhaid_list = [int(self.run_card['lhaid'])]
             self.copy_lhapdf_set(lhaid_list, pdfsetsdir)
         elif 'lhapdf' in os.environ.keys():
             del os.environ['lhapdf']
         if self.run_card['pdlabel'] != "lhapdf":
             self.pdffile = None
-            #remove lhapdf stuff
-            self.compile(arg=['clean_lhapdf'], cwd=os.path.join(self.me_dir, 'Source'))
             
         # set random number
         if self.run_card['iseed'] != '0':

=== modified file 'madgraph/iolibs/template_files/madevent_makefile_source'
--- madgraph/iolibs/template_files/madevent_makefile_source	2013-11-22 13:16:07 +0000
+++ madgraph/iolibs/template_files/madevent_makefile_source	2014-09-05 12:34:28 +0000
@@ -68,9 +68,9 @@
 run_card.inc: ../Cards/run_card.dat
 	../bin/madevent treatcards run
 
-clean_lhapdf:
-	rm -f $(LIBDIR)libgeneric.$(libext)
-	cd PDF; make clean_lhapdf
+clean4pdf:
+	rm -f ../lib/libpdf.$(libext)
+	rm -f ../lib/libgeneric.$(libext)
 
 clean:
 	$(RM) *.o $(LIBRARIES) $(BINARIES)

=== modified file 'madgraph/various/banner.py'
--- madgraph/various/banner.py	2014-07-25 20:20:42 +0000
+++ madgraph/various/banner.py	2014-09-05 12:34:28 +0000
@@ -25,7 +25,7 @@
     import madgraph.iolibs.file_writers as file_writers
     import madgraph.iolibs.files as files 
     import models.check_param_card as param_card_reader
-    from madgraph import MG5DIR
+    from madgraph import MG5DIR, InvalidCmd
     MADEVENT = False
 except ImportError:
     MADEVENT = True
@@ -33,6 +33,7 @@
     import internal.files as files
     import internal.check_param_card as param_card_reader
     import internal.misc as misc
+    from internal import InvalidCmd
     
     MEDIR = os.path.split(os.path.dirname(os.path.realpath( __file__ )))[0]
     MEDIR = os.path.split(MEDIR)[0]
@@ -535,7 +536,8 @@
     
 
 
-
+class InvalidRunCard(InvalidCmd):
+    pass
 
 class RunCard(dict):
     """A class object for the run_card"""
@@ -650,7 +652,7 @@
     
         self.add_line('maxjetflavor', 'int', 4)
         if int(self['maxjetflavor']) > 6:
-            raise Exception, 'maxjetflavor should be lower than 5! (6 is partly supported)'
+            raise InvalidRunCard, 'maxjetflavor should be lower than 5! (6 is partly supported)'
         self.add_line('auto_ptj_mjj', 'bool', True)
         self.add_line('cut_decays', 'bool', True)
         # minimum pt
@@ -822,7 +824,7 @@
                     logger.warning('Since use_syst=T, We change the value of \'alpsfact\' to 1')
                     self['alpsfact'] = 1.0
             if int(self['maxjetflavor']) == 6:
-                raise Exception, 'maxjetflavor at 6 is NOT supported for matching!'
+                raise InvalidRUnCard, 'maxjetflavor at 6 is NOT supported for matching!'
             self.add_line('alpsfact', 'float', 1.0)
             self.add_line('pdfwgt', 'bool', True)
             self.add_line('clusinfo', 'bool', False)
@@ -860,6 +862,12 @@
         self.add_line('bwcutoff', 'float', 15.0)
         #  Collider pdf
         self.add_line('pdlabel','str','cteq6l1')
+        
+        # check validity of the pdf set
+        possible_set = ['lhapdf','mrs02nl','mrs02nn', 'mrs0119','mrs0117','mrs0121','mrs01_j', 'mrs99_1','mrs99_2','mrs99_3','mrs99_4','mrs99_5','mrs99_6', 'mrs99_7','mrs99_8','mrs99_9','mrs9910','mrs9911','mrs9912', 'mrs98z1','mrs98z2','mrs98z3','mrs98z4','mrs98z5','mrs98ht', 'mrs98l1','mrs98l2','mrs98l3','mrs98l4','mrs98l5', 'cteq3_m','cteq3_l','cteq3_d', 'cteq4_m','cteq4_d','cteq4_l','cteq4a1','cteq4a2', 'cteq4a3','cteq4a4','cteq4a5','cteq4hj','cteq4lq', 'cteq5_m','cteq5_d','cteq5_l','cteq5hj','cteq5hq', 'cteq5f3','cteq5f4','cteq5m1','ctq5hq1','cteq5l1', 'cteq6_m','cteq6_d','cteq6_l','cteq6l1', 'nn23lo','nn23lo1','nn23nlo']
+        if self['pdlabel'] not in possible_set:
+            raise InvalidRunCard, 'Invalid PDF set (argument of pdlabel) possible choice are:\n %s' % ','.join(possible_set)
+    
         if self['pdlabel'] == 'lhapdf':
             self.add_line('lhaid', 'int', 10042)
         else:
@@ -974,6 +982,13 @@
         self.add_line('isoEM', 'bool', True)
         #  Collider pdf
         self.add_line('pdlabel','str','cteq6_m')
+        # check validity of the pdf set
+        possible_set = ['lhapdf','mrs02nl','mrs02nn', 'mrs0119','mrs0117','mrs0121','mrs01_j', 'mrs99_1','mrs99_2','mrs99_3','mrs99_4','mrs99_5','mrs99_6', 'mrs99_7','mrs99_8','mrs99_9','mrs9910','mrs9911','mrs9912', 'mrs98z1','mrs98z2','mrs98z3','mrs98z4','mrs98z5','mrs98ht', 'mrs98l1','mrs98l2','mrs98l3','mrs98l4','mrs98l5', 'cteq3_m','cteq3_l','cteq3_d', 'cteq4_m','cteq4_d','cteq4_l','cteq4a1','cteq4a2', 'cteq4a3','cteq4a4','cteq4a5','cteq4hj','cteq4lq', 'cteq5_m','cteq5_d','cteq5_l','cteq5hj','cteq5hq', 'cteq5f3','cteq5f4','cteq5m1','ctq5hq1','cteq5l1', 'cteq6_m','cteq6_d','cteq6_l','cteq6l1', 'nn23lo','nn23lo1','nn23nlo']
+        if self['pdlabel'] not in possible_set:
+            raise InvalidRunCard, 'Invalid PDF set (argument of pdlabel) possible choice are:\n %s' % ','.join(possible_set)
+    
+        
+        
         if self['pdlabel'] == 'lhapdf':
             self.add_line('lhaid', 'int', 21100)
         else: