Merge lp:~macslow/unity-notifications/dont-ignore-placeholder into lp:unity-notifications
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 198 |
Merged at revision: | 199 |
Proposed branch: | lp:~macslow/unity-notifications/dont-ignore-placeholder |
Merge into: | lp:unity-notifications |
Diff against target: |
79 lines (+9/-9) 5 files modified
examples/sd-example-incoming-file.py (+1/-1) examples/sd-example-much-body-text.py (+1/-1) examples/sd-example-using-button-tint-hint.py (+1/-1) src/NotificationModel.cpp (+1/-1) test/notificationtest.cpp (+5/-5) |
To merge this branch: | bzr merge lp:~macslow/unity-notifications/dont-ignore-placeholder |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+206950@code.launchpad.net |
Commit message
Updated NotificationModel and its unit-test to not ignore the permanent PlaceHolder notification in the queue.
Description of the change
Updated NotificationModel and its unit-test to not ignore the permanent PlaceHolder notification in the queue.
* Are there any related MPs required for this MP to build/function as expected?
This MP is related...
* https:/
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.
* If you changed the UI, has there been a design review?
Not applicable.
PASSED: Continuous integration, rev:198 jenkins. qa.ubuntu. com/job/ unity-notificat ions-ci/ 45/ jenkins. qa.ubuntu. com/job/ unity-notificat ions-trusty- amd64-ci/ 20 jenkins. qa.ubuntu. com/job/ unity-notificat ions-trusty- armhf-ci/ 20 jenkins. qa.ubuntu. com/job/ unity-notificat ions-trusty- armhf-ci/ 20/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-notificat ions-trusty- i386-ci/ 20
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- notifications- ci/45/rebuild
http://