Merge lp:~macslow/unity8/fix-object-name-of-notification-ap-test into lp:unity8

[Mirco Müller]

The snap-decision AP-test for "incoming call"-case used the wrong objectName "notification0". It has to be "notification1".

The snap-decision AP-test for "incoming call"-case used the wrong objectName "notification0", which ignores the PlaceHolder notification at the first position in the model.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
Yes. lp:~macslow/unity-notifications/dont-ignore-placeholder needs to be merged to lp:unity-notifications first for this to work.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

 * If you changed the UI, has there been a design review?
Not applicable.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:760
http://jenkins.qa.ubuntu.com/job/unity8-ci/2473/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3852
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3437/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1343
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/994
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/998
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/998/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/994
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3378
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3876
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3876/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3439
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3439/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5795/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4713

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2473/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
N/A

 * Did CI run pass? If not, please explain why.
No, needs the unity-notifications branch to land, tested locally.

review: Approve

[Albert Astals Cid (aacid)]

Looks good

review: Approve

[Albert Astals Cid (aacid)]

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

* Did CI run pass? If not, please explain why.
Yes

=== modified file 'tests/autopilot/unity8/shell/tests/test_notifications.py'
--- tests/autopilot/unity8/shell/tests/test_notifications.py	2014-02-23 01:28:40 +0000
+++ tests/autopilot/unity8/shell/tests/test_notifications.py	2014-03-12 11:40:15 +0000
@@ -194,7 +194,7 @@
 
         notify_list = self._get_notifications_list()
         get_notification = lambda: notify_list.wait_select_single(
-            'Notification', objectName='notification0')
+            'Notification', objectName='notification1')
         notification = get_notification()
         self._assert_notification(notification, None, None, True, True, 1.0)
         initial_height = notification.height