Code review comment for lp:~macobo/mailman/macobo-conf_sort_option

Revision history for this message
Barry Warsaw (barry) wrote :

Thanks for the contribution to Mailman! Your branch looks quite good, and with just a few modifications, I am merging this branch. I did change -x to -t and added a few tests. I am giving you top credit for fixing the bug but I'm also going to mention David Soto's contribution. His branch lacked tests and there was no merge proposal from him, so your branch provided the bulk of the new code.

Again, thanks!

review: Approve

« Back to merge proposal