Merge lp:~macobo/mailman/macobo-conf_sort_option into lp:mailman
Proposed by
Karl-Aksel Puulmann
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 7221 | ||||
Proposed branch: | lp:~macobo/mailman/macobo-conf_sort_option | ||||
Merge into: | lp:mailman | ||||
Diff against target: |
111 lines (+27/-5) 3 files modified
src/mailman/commands/cli_conf.py (+18/-5) src/mailman/commands/docs/conf.rst (+8/-0) src/mailman/commands/tests/test_conf.py (+1/-0) |
||||
To merge this branch: | bzr merge lp:~macobo/mailman/macobo-conf_sort_option | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Barry Warsaw | Approve | ||
Review via email: mp+157469@code.launchpad.net |
Description of the change
Since the -s option is taken by --section, I decided to use -x instead (perhaps should be changed).
When doing the changes, I didn't notice that David Soto had already made a branch to fix this issue.
To post a comment you must log in.
Thanks for the contribution to Mailman! Your branch looks quite good, and with just a few modifications, I am merging this branch. I did change -x to -t and added a few tests. I am giving you top credit for fixing the bug but I'm also going to mention David Soto's contribution. His branch lacked tests and there was no merge proposal from him, so your branch provided the bulk of the new code.
Again, thanks!