Code review comment for lp:~ma5dev/madanalysis5/ma5_pyhf

Hi Benjamin

By suggestion do you mean ask the user if they want to install FJ or not? Or just like a warning? Are we allowed to interact with the user through Mg5 interface? If so I'll do that accordingly.

Cheers
Jack

> Hi Jack,
>
> Can you please change this behaviour:
> + # If FastJet is installed, install PADForSFS
> + if self.main.archi_info.has_fastjet and install_padforsfs:
> + self.logger.info('Installing PAD for SFS')
> + if not installer.Execute('padforsfs'):
> + self.logger.error('Impossible to install PAD For SFS.')
> + return False
>
> If fastjet is not installed, then the code should propose the user to "install
> fastjet and then install the PADForSFS". Can you please implement that change?
> Thanks in advance. I will merge the code when done. The MG5 thingie looks
> good.
>
> Cheers,
>
> Benj