Merge lp:~ma5dev/madanalysis5/ma5_pyhf into lp:~ma5dev/madanalysis5/v1.9_beta
Proposed by
Jack Y. Araz
Status: | Merged |
---|---|
Approved by: | Benjamin Fuks |
Approved revision: | 150 |
Merged at revision: | 147 |
Proposed branch: | lp:~ma5dev/madanalysis5/ma5_pyhf |
Merge into: | lp:~ma5dev/madanalysis5/v1.9_beta |
Diff against target: |
165 lines (+60/-19) 4 files modified
madanalysis/install/install_pad.py (+8/-3) madanalysis/interpreter/cmd_install.py (+38/-6) madanalysis/interpreter/ma5_interpreter.py (+11/-2) madanalysis/system/detect_pad.py (+3/-8) |
To merge this branch: | bzr merge lp:~ma5dev/madanalysis5/ma5_pyhf |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jack Y. Araz | Needs Resubmitting | ||
Benjamin Fuks | Needs Fixing | ||
Review via email: mp+398157@code.launchpad.net |
Commit message
installation of PADForSFS bind to FastJet
Description of the change
this commit has been pushed on top of latest commit on v1.9_beta
revno: 143
committer: Benjamin Fuks <email address hidden>
branch nick: v1.9_beta
timestamp: Tue 2021-01-12 10:29:05 +0100
message:
Bug fix with the mg5 interface
To post a comment you must log in.
Hi Jack,
Can you please change this behaviour: archi_info. has_fastjet and install_padforsfs: info('Installin g PAD for SFS') Execute( 'padforsfs' ): error(' Impossible to install PAD For SFS.')
+ # If FastJet is installed, install PADForSFS
+ if self.main.
+ self.logger.
+ if not installer.
+ self.logger.
+ return False
If fastjet is not installed, then the code should propose the user to "install fastjet and then install the PADForSFS". Can you please implement that change? Thanks in advance. I will merge the code when done. The MG5 thingie looks good.
Cheers,
Benj