Code review comment for lp:~lukas-kde/unity8/fix-shell-chrome

Lukáš Tinkl (lukas-kde) wrote :

> hmm... a couple of questions:
>
> * A timer of 1 second seems quite long. Is that really what we want?

Well yes :/ try lowering the value and see it fail more and more often.

> * afaict, this change now only loads the windowstatestorage stuff if we're
> starting up in windowed mode. However, it should still load the
> windowedX/Y/Width/Height even though we're in staged mode, just not use them
> yet while we're in staged mode. Once we're switching from staged to windowed,
> it should then use the previously loaded stuff.

Correct, fixed that

« Back to merge proposal