Merge lp:~lukas-kde/unity8/fix-shell-chrome into lp:unity8

Proposed by Lukáš Tinkl on 2017-02-22
Status: Merged
Approved by: Michał Sawicz on 2017-03-08
Approved revision: 2851
Merged at revision: 2851
Proposed branch: lp:~lukas-kde/unity8/fix-shell-chrome
Merge into: lp:unity8
Diff against target: 360 lines (+56/-59)
9 files modified
qml/Stage/ApplicationWindow.qml (+1/-0)
qml/Stage/Stage.qml (+21/-11)
qml/Stage/StagedFullscreenPolicy.qml (+7/-13)
qml/Stage/WindowStateSaver.qml (+4/-3)
qml/Stage/WindowedFullscreenPolicy.qml (+4/-12)
tests/mocks/Unity/Application/ApplicationManager.cpp (+1/-0)
tests/qmltests/Stage/tst_DesktopStage.qml (+3/-3)
tests/qmltests/tst_OrientedShell.qml (+5/-3)
tests/qmltests/tst_Shell.qml (+10/-14)
To merge this branch: bzr merge lp:~lukas-kde/unity8/fix-shell-chrome
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration 2017-02-22 Approve on 2017-03-06
Michael Zanetti (community) 2017-02-22 Approve on 2017-02-27
Daniel d'Andrada (community) Needs Information on 2017-02-24
Review via email: mp+318015@code.launchpad.net

This proposal supersedes a proposal from 2017-02-22.

Commit message

Shell chrome fixes

Correctly save and load the window state from storage, do not restore our QML window right away but queue the state, filter it with the shell chrome policy (when in windowed mode) later on, and then apply it at altogether, once the surface creation is settled.

For a more elegant longterm fix, we should probably introduce "initialSurfaceState" in qtmir, much like the recent "initialSurfaceSize" so that the window/surface gets the correct state right from the beginning.

Description of the change

Shell chrome fixes

To post a comment you must log in.
Daniel d'Andrada (dandrader) wrote : Posted in a previous version of this proposal

"""
interval: 1000
"""

Why 1000 and not 500 or 2000. Do you know what are you waiting for more exactly?

Daniel d'Andrada (dandrader) wrote : Posted in a previous version of this proposal

would be great if you could split the timer hack from the other, uncontroversial, proper fixes.

Lukáš Tinkl (lukas-kde) wrote :

No, I can't really split them, since they need to come in this specific order (as written in the description).

As for the interval... yup it's not pretty, but given all the different timers and (blocking) queued connections we have in QML and qtmir, it has to be "high" enough so that it doesn't interfere with the internal state changes.

Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2835
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3182/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4178
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2461
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2461
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4206
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4043
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4043/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4043
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4043/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4043
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4043/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4043
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4043/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4043
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4043/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4043
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4043/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3182/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2835
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3183/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4179
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2463
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2463
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4207
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4044
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4044/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4044
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4044/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4044
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4044/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4044
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4044/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4044
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4044/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4044
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4044/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3183/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2836
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3184/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4180
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2464
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2464
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4208
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4045
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4045/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4045
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4045/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4045
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4045/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4045
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4045/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4045
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4045/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4045
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4045/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3184/rebuild

review: Needs Fixing (continuous-integration)
Michael Zanetti (mzanetti) wrote :

hmm... a couple of questions:

* A timer of 1 second seems quite long. Is that really what we want?

* afaict, this change now only loads the windowstatestorage stuff if we're starting up in windowed mode. However, it should still load the windowedX/Y/Width/Height even though we're in staged mode, just not use them yet while we're in staged mode. Once we're switching from staged to windowed, it should then use the previously loaded stuff.

review: Needs Information
Lukáš Tinkl (lukas-kde) wrote :

> hmm... a couple of questions:
>
> * A timer of 1 second seems quite long. Is that really what we want?

Well yes :/ try lowering the value and see it fail more and more often.

> * afaict, this change now only loads the windowstatestorage stuff if we're
> starting up in windowed mode. However, it should still load the
> windowedX/Y/Width/Height even though we're in staged mode, just not use them
> yet while we're in staged mode. Once we're switching from staged to windowed,
> it should then use the previously loaded stuff.

Correct, fixed that

Michael Zanetti (mzanetti) wrote :

> > hmm... a couple of questions:
> >
> > * A timer of 1 second seems quite long. Is that really what we want?
>
> Well yes :/ try lowering the value and see it fail more and more often.

Hmm... I'm not entirely happy with that... can't we somehow trigger this as a result of the other stuff being finished instead of having a timer that is a) so slow, it's visible to the user, and b) might still fail if the machine is under load or something...

Daniel d'Andrada (dandrader) wrote :

> > > hmm... a couple of questions:
> > >
> > > * A timer of 1 second seems quite long. Is that really what we want?
> >
> > Well yes :/ try lowering the value and see it fail more and more often.
>
> Hmm... I'm not entirely happy with that... can't we somehow trigger this as a
> result of the other stuff being finished instead of having a timer that is a)
> so slow, it's visible to the user, and b) might still fail if the machine is
> under load or something...

+1

Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2837
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3186/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4183
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2467
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2467
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4211
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4048
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4048/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4048
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4048/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4048
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4048/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4048
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4048/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4048
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4048/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4048
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4048/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3186/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2838
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3190/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4187
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2469
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2469
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4215
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4051
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4051/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4051
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4051/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4051
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4051/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4051
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4051/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4051
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4051/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4051
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4051/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3190/rebuild

review: Needs Fixing (continuous-integration)
Daniel d'Andrada (dandrader) wrote :

In qml/Stage/ApplicationWindow.qml:

"""
     Binding {
         target: root.application
         property: "initialSurfaceSize"
         value: Qt.size(root.requestedWidth, root.requestedHeight)
+ when: d.surfaceInitialized
     }
"""

This doesn't make sense to me. initialSurfaceSize is only useful if it's correctly set *before* the surface is created.

review: Needs Information
Lukáš Tinkl (lukas-kde) wrote :

> This doesn't make sense to me. initialSurfaceSize is only useful if it's
> correctly set *before* the surface is created.

Fixed

Daniel d'Andrada (dandrader) wrote :

What about this:
http://bazaar.launchpad.net/~dandrader/unity8/fix-shell-chrome/revision/2838

I think it's better to avoid creating yet another property in Stage.qml if possible. Specially since this one is only used once during initialization and never again. And its name gives the impression it affects the window state throughout the delegate's lifetime

Daniel d'Andrada (dandrader) wrote :

If I understood correctly all you need is to wait until the surface shows up so that you can query its shellChrome property, right?

In which case you can just consult appDelegate.surface, which is readily available instead of exposing surfaceInitialized from ApplicationWindow.

review: Needs Information
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2840
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3201/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4203
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2480
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2480
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4231
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4066
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4066/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4066
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4066/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4066
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4066/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4066
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4066/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4066
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4066/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4066
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4066/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3201/rebuild

review: Approve (continuous-integration)
Lukáš Tinkl (lukas-kde) wrote :

> What about this:
> http://bazaar.launchpad.net/~dandrader/unity8/fix-shell-chrome/revision/2838
>
> I think it's better to avoid creating yet another property in Stage.qml if
> possible. Specially since this one is only used once during initialization and
> never again. And its name gives the impression it affects the window state
> throughout the delegate's lifetime

Makes sense yeah, merged in

Lukáš Tinkl (lukas-kde) wrote :

> If I understood correctly all you need is to wait until the surface shows up
> so that you can query its shellChrome property, right?

Not only that, if I don't wait for surfaceInitialized, then requesting a new (loaded/policy) state does not work :/ I tried that

> In which case you can just consult appDelegate.surface, which is readily
> available instead of exposing surfaceInitialized from ApplicationWindow.

Daniel d'Andrada (dandrader) wrote :

On 24/02/2017 10:49, Lukáš Tinkl wrote:
>> If I understood correctly all you need is to wait until the surface shows up
>> so that you can query its shellChrome property, right?
> Not only that, if I don't wait for surfaceInitialized, then requesting a new (loaded/policy) state does not work :/ I tried that

Interesting.

Calling window.requestState() should work even *before* the window gets
a surface. As the request gets cached and applied once window finally
receives a surface. But that's not really relevant in this case as you
have to wait for the surface.shellChrome value anyway. But good to keep
in mind.

This might be related to the fact that the SurfaceContainer inside
ApplicationWindow is only made visible once "surface !== null &&
d.surfaceInitialized === true".

When you request a state, it really should work. Worth investigating
what's going on in qtmir and miral.

A insivible MirSurfaceItem make its MirSurface visibility state go to
hidden. Maybe miral ignores certain state change requests for a surface
that is not exposed.

Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2844
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3204/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4207
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2482
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2482
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4235
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4070
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4070/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4070
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4070/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4070
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4070/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4070
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4070/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4070
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4070/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4070
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4070/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3204/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2846
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3205/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4208
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2485
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2485
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4236
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4071
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4071/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4071
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4071/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4071
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4071/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4071
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4071/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4071
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4071/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4071
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4071/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3205/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2847
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3211/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4214
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2487
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2487
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4242
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4077
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4077/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4077
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4077/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4077
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4077/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4077
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4077/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4077
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4077/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4077
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4077/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3211/rebuild

review: Approve (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2848
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3212/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4215
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2488
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2488
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4243
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4078
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4078/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4078
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4078/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4078
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4078/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4078
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4078/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4078
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4078/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4078
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4078/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3212/rebuild

review: Approve (continuous-integration)
Michael Zanetti (mzanetti) wrote :

code makes mostly sense. One issue is that with this change, the position/size is only stored when an app is closed in windowed mode. This leads to the following situation:

* open an app, drag it to somewhere, close it
* restart the app, it will open where you closed it, so far so good.
* move the app around
* switch to staged mode
* close the app
* switch to windowed mode
* restart the app => it will open at the old saved position instead of the last one where it was moved to

review: Needs Fixing
Lukáš Tinkl (lukas-kde) wrote :

> code makes mostly sense. One issue is that with this change, the position/size
> is only stored when an app is closed in windowed mode. This leads to the
> following situation:
>
> * open an app, drag it to somewhere, close it
> * restart the app, it will open where you closed it, so far so good.
> * move the app around
> * switch to staged mode
> * close the app
> * switch to windowed mode
> * restart the app => it will open at the old saved position instead of the
> last one where it was moved to

Fixed

Michael Zanetti (mzanetti) wrote :

works fine now. I get this warning in tryShell:

file:///home/micha/Develop/reviews/fix-shell-chrome/tests/qmltests/tst_Shell.qml:382: TypeError: Cannot read property 'shellChrome' of null

perhaps worth fixing too

Michael Zanetti (mzanetti) wrote :

ok. looks good to me now. waiting for CI for top-approval

review: Approve
Lukáš Tinkl (lukas-kde) wrote :

> works fine now. I get this warning in tryShell:
>
> file:///home/micha/Develop/reviews/fix-shell-
> chrome/tests/qmltests/tst_Shell.qml:382: TypeError: Cannot read property
> 'shellChrome' of null
>
> perhaps worth fixing too

Warning fixed too

Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2849
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3217/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4221
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2494
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2494
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4249
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4084
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4084/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4084
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4084/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4084
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4084/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4084
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4084/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4084
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4084/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4084
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4084/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3217/rebuild

review: Approve (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3221/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4225
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2497
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2497
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4253
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4088
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4088/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4088
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4088/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4088
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4088/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4088
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4088/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4088
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4088/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4088
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4088/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3221/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3242/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4251
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2529
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2529
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4279
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4116
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4116/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4116
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4116/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4116
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4116/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4116
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4116/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4116
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4116/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4116
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4116/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3242/rebuild

review: Approve (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3244/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4261
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2533
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2533
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4289
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4123
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4123/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4123
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4123/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4123
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4123/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4123
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4123/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4123
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4123/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4123
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4123/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3244/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3253/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4274
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2545
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2545
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4302
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4136
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4136/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4136
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4136/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4136
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4136/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4136
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4136/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4136
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4136/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4136
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4136/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3253/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3254/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4278
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2550
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2550
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4306
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4140
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4140/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4140
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4140/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4140
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4140/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4140
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4140/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4140
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4140/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4140
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4140/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3254/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3256/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4282
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2551
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2551
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4310
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4144
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4144/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4144
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4144/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4144
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4144/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4144
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4144/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4144
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4144/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4144
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4144/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3256/rebuild

review: Approve (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3258/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/4285/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4313
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4147
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4147/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4147
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4147/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4147
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4147/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4147/console
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4147/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4147
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4147/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4147
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4147/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3258/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3259/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4286
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2556
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2556
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4314
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4149
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4149/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4149
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4149/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4149
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4149/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4149
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4149/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4149
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4149/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4149
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4149/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3259/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3267/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4296
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2561
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2561
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4324
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4158
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4158/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4158
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4158/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4158
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4158/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4158
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4158/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4158
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4158/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4158
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4158/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3267/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3269/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4298
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2563
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2563
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4326
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4160
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4160/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4160
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4160/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4160
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4160/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4160
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4160/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4160
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4160/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4160
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4160/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3269/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2850
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3272/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4309
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2571
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2571
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4337
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4171
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4171/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4171
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4171/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4171
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4171/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4171
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4171/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4171
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4171/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4171
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4171/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3272/rebuild

review: Approve (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2851
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3275/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4312
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2574
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2574
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4340
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4174
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4174/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4174
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4174/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4174
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4174/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4174
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4174/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4174
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4174/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4174
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4174/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3275/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2851
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3280/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4319
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2577
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2577
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4347
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4181
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4181/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4181
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4181/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4181
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4181/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4181
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4181/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4181
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4181/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4181
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4181/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3280/rebuild

review: Needs Fixing (continuous-integration)
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2851
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3283/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/4322
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2579
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2579
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/4350
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4184
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/4184/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4184
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/4184/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4184
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/4184/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4184
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/4184/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4184
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/4184/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4184
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/4184/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/3283/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Stage/ApplicationWindow.qml'
2--- qml/Stage/ApplicationWindow.qml 2016-09-22 14:17:39 +0000
3+++ qml/Stage/ApplicationWindow.qml 2017-03-02 13:00:45 +0000
4@@ -28,6 +28,7 @@
5 property bool orientationChangesEnabled: d.supportsSurfaceResize ? d.surfaceOldEnoughToBeResized : true
6 readonly property string title: surface && surface.name !== "" ? surface.name : d.name
7 readonly property QtObject focusedSurface: d.focusedSurface.surface
8+ readonly property alias surfaceInitialized: d.surfaceInitialized
9
10 // to be set from outside
11 property QtObject surface
12
13=== modified file 'qml/Stage/Stage.qml'
14--- qml/Stage/Stage.qml 2017-02-16 13:44:45 +0000
15+++ qml/Stage/Stage.qml 2017-03-02 13:00:45 +0000
16@@ -470,7 +470,7 @@
17 extend: "stagedRightEdge"
18 PropertyChanges {
19 target: sideStage
20- opacity: priv.sideStageDelegate.x === sideStage.x ? 1 : 0
21+ opacity: priv.sideStageDelegate && priv.sideStageDelegate.x === sideStage.x ? 1 : 0
22 visible: true
23 }
24 },
25@@ -723,6 +723,7 @@
26 // miral doesn't know about our window decorations. So we have to deduct them
27 value: Qt.point(appDelegate.requestedX + appDelegate.clientAreaItem.x,
28 appDelegate.requestedY + appDelegate.clientAreaItem.y)
29+ when: root.mode == "windowed"
30 }
31
32 // In those are for windowed mode. Those values basically store the window's properties
33@@ -768,7 +769,6 @@
34 Math.max(0, priv.virtualKeyboardHeight - (appContainer.height - (appDelegate.requestedY + appDelegate.height))))
35 when: root.oskEnabled && appDelegate.focus && (appDelegate.state == "normal" || appDelegate.state == "restored")
36 && root.inputMethodRect.height > 0
37-
38 }
39
40 Behavior on x { id: xBehavior; enabled: priv.closingIndex >= 0; UbuntuNumberAnimation { onRunningChanged: if (!running) priv.closingIndex = -1} }
41@@ -933,7 +933,8 @@
42 } else if (model.window.state === Mir.MaximizedBottomRightState) {
43 appDelegate.maximizeBottomRight();
44 } else if (model.window.state === Mir.RestoredState) {
45- if (appDelegate.fullscreen && appDelegate.prevWindowState != WindowStateStorage.WindowStateRestored) {
46+ if (appDelegate.fullscreen && appDelegate.prevWindowState != WindowStateStorage.WindowStateRestored
47+ && appDelegate.prevWindowState != WindowStateStorage.WindowStateNormal) {
48 model.window.requestState(WindowStateStorage.toMirState(appDelegate.prevWindowState));
49 } else {
50 appDelegate.restore();
51@@ -945,6 +946,21 @@
52 }
53 }
54
55+ readonly property bool windowReady: clientAreaItem.surfaceInitialized
56+ onWindowReadyChanged: {
57+ if (windowReady) {
58+ var loadedMirState = WindowStateStorage.toMirState(windowStateSaver.loadedState);
59+ // need to apply the shell chrome policy on top the saved window state
60+ var policy;
61+ if (root.mode == "windowed") {
62+ policy = windowedFullscreenPolicy;
63+ } else {
64+ policy = stagedFullscreenPolicy
65+ }
66+ window.requestState(policy.applyPolicy(loadedMirState, surface.shellChrome));
67+ }
68+ }
69+
70 Component.onCompleted: {
71 if (application && application.rotatesWindowContents) {
72 decoratedWindow.surfaceOrientationAngle = shellOrientationAngle;
73@@ -957,7 +973,6 @@
74 windowedY = priv.focusedAppDelegate ? priv.focusedAppDelegate.windowedY + units.gu(3) : normalZ * units.gu(3)
75 // Now load any saved state. This needs to happen *after* the cascading!
76 windowStateSaver.load();
77- model.window.requestState(WindowStateStorage.toMirState(windowState));
78
79 updateQmlFocusFromMirSurfaceFocus();
80
81@@ -1441,7 +1456,7 @@
82 ]
83 transitions: [
84 Transition {
85- from: "staged,stagedWithSideStage"; to: "normal"
86+ from: "staged,stagedWithSideStage"
87 enabled: appDelegate.animationsEnabled
88 PropertyAction { target: appDelegate; properties: "visuallyMinimized,visuallyMaximized" }
89 UbuntuNumberAnimation { target: appDelegate; properties: "x,y,requestedX,requestedY,opacity,requestedWidth,requestedHeight,scale"; duration: priv.animationDuration }
90@@ -1462,8 +1477,7 @@
91 },
92 Transition {
93 from: "normal,staged"; to: "stagedWithSideStage"
94- UbuntuNumberAnimation { target: appDelegate; properties: "x,y"; duration: priv.animationDuration }
95- UbuntuNumberAnimation { target: appDelegate; properties: "requestedWidth,requestedHeight"; duration: priv.animationDuration }
96+ UbuntuNumberAnimation { target: appDelegate; properties: "x,y,requestedWidth,requestedHeight"; duration: priv.animationDuration }
97 },
98 Transition {
99 to: "windowedRightEdge"
100@@ -1503,7 +1517,6 @@
101 from: ",normal,restored,maximized,maximizedLeft,maximizedRight,maximizedTopLeft,maximizedTopRight,maximizedBottomLeft,maximizedBottomRight,maximizedHorizontally,maximizedVertically,fullscreen"
102 to: "minimized"
103 SequentialAnimation {
104- ScriptAction { script: print("transitioning:", appDelegate.x, appDelegate.y, appDelegate.scale) }
105 ScriptAction { script: { fakeRectangle.stop(); } }
106 PropertyAction { target: appDelegate; property: "visuallyMaximized" }
107 UbuntuNumberAnimation { target: appDelegate; properties: "x,y,scale,opacity"; duration: priv.animationDuration }
108@@ -1514,7 +1527,6 @@
109 from: "minimized"
110 to: ",normal,restored,maximized,maximizedLeft,maximizedRight,maximizedTopLeft,maximizedTopRight,maximizedBottomLeft,maximizedBottomRight,maximizedHorizontally,maximizedVertically,fullscreen"
111 SequentialAnimation {
112- ScriptAction { script: print("transitioning:", appDelegate.x, appDelegate.y, appDelegate.scale) }
113 PropertyAction { target: appDelegate; property: "visuallyMinimized,z" }
114 ParallelAnimation {
115 UbuntuNumberAnimation { target: appDelegate; properties: "x"; from: -appDelegate.width / 2; duration: priv.animationDuration }
116@@ -1661,8 +1673,6 @@
117
118 WindowedFullscreenPolicy {
119 id: windowedFullscreenPolicy
120- active: root.mode == "windowed"
121- surface: model.window.surface
122 }
123 StagedFullscreenPolicy {
124 id: stagedFullscreenPolicy
125
126=== modified file 'qml/Stage/StagedFullscreenPolicy.qml'
127--- qml/Stage/StagedFullscreenPolicy.qml 2016-11-30 19:24:02 +0000
128+++ qml/Stage/StagedFullscreenPolicy.qml 2017-03-02 13:00:45 +0000
129@@ -28,14 +28,14 @@
130 QtObject {
131 property bool active: true
132
133+ function applyPolicy(surfaceState, surfaceChrome) {
134+ if (surfaceChrome === Mir.LowChrome) {
135+ return Mir.FullscreenState;
136+ }
137+ return surfaceState;
138+ }
139+
140 property var surface: null
141- onSurfaceChanged: {
142- if (!active || !surface) return;
143- if (surface.shellChrome === Mir.LowChrome) {
144- surface.requestState(Mir.FullscreenState);
145- }
146- }
147-
148 property var _connections: Connections {
149 target: surface
150 onShellChromeChanged: {
151@@ -46,11 +46,5 @@
152 surface.requestState(Mir.RestoredState);
153 }
154 }
155- onStateChanged: {
156- if (!active) return;
157- if (surface.state === Mir.RestoredState && surface.shellChrome === Mir.LowChrome) {
158- surface.requestState(Mir.FullscreenState);
159- }
160- }
161 }
162 }
163
164=== modified file 'qml/Stage/WindowStateSaver.qml'
165--- qml/Stage/WindowStateSaver.qml 2016-11-23 18:43:48 +0000
166+++ qml/Stage/WindowStateSaver.qml 2017-03-02 13:00:45 +0000
167@@ -28,6 +28,8 @@
168 property int leftMargin: 0
169 property int minimumY: 0
170
171+ property int loadedState
172+
173 function load() {
174 var defaultWidth = units.gu(60);
175 var defaultHeight = units.gu(50);
176@@ -41,14 +43,13 @@
177 (target.fullscreen ? 0 : root.leftMargin)); });
178 target.windowedY = Qt.binding(function() { return Math.max(Math.min(windowGeometry.y, screenHeight - target.windowedHeight), minimumY); });
179
180- var windowState = WindowStateStorage.getState(target.appId, WindowStateStorage.WindowStateNormal)
181- target.restore(false /* animated */, windowState);
182-
183 target.updateNormalGeometry();
184
185 // initialize the x/y to restore to
186 target.restoredX = target.normalX;
187 target.restoredY = target.normalY;
188+
189+ loadedState = WindowStateStorage.getState(target.appId, WindowStateStorage.WindowStateNormal);
190 }
191
192 function save() {
193
194=== modified file 'qml/Stage/WindowedFullscreenPolicy.qml'
195--- qml/Stage/WindowedFullscreenPolicy.qml 2016-11-30 19:24:02 +0000
196+++ qml/Stage/WindowedFullscreenPolicy.qml 2017-03-02 13:00:45 +0000
197@@ -22,18 +22,10 @@
198 // On first surface load; if the surface is set to low chrome & fullscreen, the
199 // state of the window is returned to restored.
200 QtObject {
201- property bool active: true
202- property QtObject surface: null
203-
204- property bool _firstTimeSurface: true
205-
206- onSurfaceChanged: {
207- if (!active || !surface) return;
208- if (!_firstTimeSurface) return;
209- _firstTimeSurface = false;
210-
211- if (surface.state === Mir.FullscreenState && surface.shellChrome === Mir.LowChrome) {
212- surface.requestState(Mir.RestoredState);
213+ function applyPolicy(surfaceState, surfaceChrome) {
214+ if (surfaceState === Mir.FullscreenState && surfaceChrome === Mir.LowChrome) {
215+ return Mir.RestoredState;
216 }
217+ return surfaceState;
218 }
219 }
220
221=== modified file 'tests/mocks/Unity/Application/ApplicationManager.cpp'
222--- tests/mocks/Unity/Application/ApplicationManager.cpp 2017-01-26 11:10:01 +0000
223+++ tests/mocks/Unity/Application/ApplicationManager.cpp 2017-03-02 13:00:45 +0000
224@@ -337,6 +337,7 @@
225 application->setScreenshotId("camera");
226 application->setIconId("camera");
227 application->setFullscreen(true);
228+ application->setShellChrome(Mir::LowChrome);
229 application->setSupportedOrientations(Qt::PortraitOrientation
230 | Qt::LandscapeOrientation
231 | Qt::InvertedPortraitOrientation
232
233=== modified file 'tests/qmltests/Stage/tst_DesktopStage.qml'
234--- tests/qmltests/Stage/tst_DesktopStage.qml 2017-02-16 13:43:56 +0000
235+++ tests/qmltests/Stage/tst_DesktopStage.qml 2017-03-02 13:00:45 +0000
236@@ -321,7 +321,7 @@
237 var maximizeButton = findChild(appDelegate, "maximizeWindowButton");
238 verify(maximizeButton);
239 mouseClick(maximizeButton);
240- tryCompare(appDelegate, "visuallyMaximized", true);
241+ tryCompare(appDelegate, "maximized", true);
242 }
243
244 function test_tappingOnDecorationFocusesApplication(data) {
245@@ -637,7 +637,7 @@
246 var dialerAppDelegate = startApplication("dialer-app");
247
248 // verify the drop shadow becomes visible
249- verify(PanelState.dropShadow == true);
250+ tryCompareFunction(function() { return PanelState.dropShadow; }, true);
251
252 // close the maximized app
253 ApplicationManager.stopApplication("facebook-webapp");
254@@ -785,7 +785,7 @@
255 waitUntilTransitionsEnd(dialerAppDelegate);
256 waitUntilTransitionsEnd(stage);
257
258- tryCompare(dialerAppDelegate, "state", "maximized");
259+ tryCompare(dialerAppDelegate, "maximized", true);
260 }
261
262 function test_saveRestoreSize() {
263
264=== modified file 'tests/qmltests/tst_OrientedShell.qml'
265--- tests/qmltests/tst_OrientedShell.qml 2017-01-26 12:57:39 +0000
266+++ tests/qmltests/tst_OrientedShell.qml 2017-03-02 13:00:45 +0000
267@@ -695,9 +695,11 @@
268 // false -> true -> false
269 compare(transitionSpy.count, 2);
270
271- // It should retain native dimensions regardless of its rotation/orientation
272- compare(cameraSurface.width, orientedShell.width);
273- compare(cameraSurface.height, orientedShell.height);
274+ if (!data.windowed) { // subject to shell-chrome policies
275+ // It should retain native dimensions regardless of its rotation/orientation
276+ compare(cameraSurface.width, orientedShell.width);
277+ compare(cameraSurface.height, orientedShell.height);
278+ }
279
280 // Surface focus shouldn't have been touched because of the rotation
281 compare(focusChangedSpy.count, 0);
282
283=== modified file 'tests/qmltests/tst_Shell.qml'
284--- tests/qmltests/tst_Shell.qml 2017-02-16 13:46:11 +0000
285+++ tests/qmltests/tst_Shell.qml 2017-03-02 13:00:45 +0000
286@@ -334,7 +334,7 @@
287
288 Row {
289 CheckBox {
290- id: fullscreeAppCheck
291+ id: fullscreenAppCheck
292 activeFocusOnPress: false
293 activeFocusOnTab: false
294
295@@ -348,13 +348,10 @@
296 }
297
298 Binding {
299- target: fullscreeAppCheck
300+ target: fullscreenAppCheck
301 when: topLevelSurfaceList && topLevelSurfaceList.focusedWindow
302 property: "checked"
303- value: {
304- if (!topLevelSurfaceList || !topLevelSurfaceList.focusedWindow) return false;
305- return topLevelSurfaceList.focusedWindow.state === Mir.FullscreenState
306- }
307+ value: topLevelSurfaceList.focusedWindow.state === Mir.FullscreenState
308 }
309 }
310 Label {
311@@ -365,6 +362,8 @@
312 Row {
313 CheckBox {
314 id: chromeAppCheck
315+ activeFocusOnPress: false
316+ activeFocusOnTab: false
317
318 onTriggered: {
319 if (!topLevelSurfaceList.focusedWindow || !topLevelSurfaceList.focusedWindow.surface) return;
320@@ -380,10 +379,8 @@
321 target: chromeAppCheck
322 when: topLevelSurfaceList && topLevelSurfaceList.focusedWindow !== null && topLevelSurfaceList.focusedWindow.surface !== null
323 property: "checked"
324- value: {
325- if (!topLevelSurfaceList || !topLevelSurfaceList.focusedWindow || !topLevelSurfaceList.focusedWindow.surface) return false;
326- topLevelSurfaceList.focusedWindow.surface.shellChrome === Mir.LowChrome
327- }
328+ value: topLevelSurfaceList.focusedWindow.surface &&
329+ topLevelSurfaceList.focusedWindow.surface.shellChrome === Mir.LowChrome
330 }
331 }
332 Label {
333@@ -2294,7 +2291,6 @@
334 return [
335 { tag: "phone" },
336 { tag: "tablet" },
337- { tag: "desktop" },
338 ]
339 }
340
341@@ -2674,8 +2670,8 @@
342 }
343
344 function test_cursorHidingWithFullscreenApp() {
345- loadShell("desktop");
346- shell.usageScenario = "desktop";
347+ loadShell("phone");
348+ shell.usageScenario = "phone";
349 waitForRendering(shell);
350 swipeAwayGreeter();
351
352@@ -2779,7 +2775,7 @@
353 tryCompare(stage, "state", "staged");
354
355 // Try by Super+W
356- keyPress(Qt.Key_W, Qt.MetaModifier)
357+ keyPress(Qt.Key_W, Qt.MetaModifier, 200);
358 tryCompare(stage, "state", data.spreadEnabled ? "spread" : "staged");
359 keyRelease(Qt.Key_W, Qt.MetaModifier)
360 }

Subscribers

People subscribed via source and target branches