Code review comment for ~lucaskanashiro/ubuntu/+source/ubuntu-fan:fix-autopkgtest

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Lucas.

I talked to him in private and asked why not handle no_proxy inside the "docker" script, since it already has code in place to deal with http{,s}_proxy as well. He told me that he attempted that, but it strangely doesn't work.

As for the value chosen for no_proxy, according to:

https://www.gnu.org/software/wget/manual/html_node/Proxies.html

it should contain a comma-separated list of domain suffixes. Maybe a better value for it would be ".internal,$no_proxy"? I haven't really tested.

Anywa, I don't think it's worth spending too much time on this, and his solution seems to work fine, so I'm approving this MP.

review: Approve

« Back to merge proposal