Merge ~lucaskanashiro/ubuntu/+source/ubuntu-fan:fix-autopkgtest into ubuntu/+source/ubuntu-fan:ubuntu/devel

[Lucas Kanashiro]

Fix autopkgtest failure on amd64 blocking docker.io migration. This is the test log:

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute/hirsute/amd64/u/ubuntu-fan/20210121_190359_0ef80@/log.gz

The test is working fine locally and it is a proxy issue in the Ubuntu's autopkgtest infrastructure.

Here is a PPA with the proposed package:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/ubuntu-fan/+packages

And the test log of an autopkgtest run with the package from the PPA:

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute-lucaskanashiro-ubuntu-fan/hirsute/amd64/u/ubuntu-fan/20210122_160631_a87a8@/log.gz

autopkgtest [16:06:17]: @@@@@@@@@@@@@@@@@@@@ summary
command1 PASS
lxd PASS

[Sergio Durigan Junior (sergiodj)]

Thanks for the MP, Lucas.

I talked to him in private and asked why not handle no_proxy inside the "docker" script, since it already has code in place to deal with http{,s}_proxy as well. He told me that he attempted that, but it strangely doesn't work.

As for the value chosen for no_proxy, according to:

https://www.gnu.org/software/wget/manual/html_node/Proxies.html

it should contain a comma-separated list of domain suffixes. Maybe a better value for it would be ".internal,$no_proxy"? I haven't really tested.

Anywa, I don't think it's worth spending too much time on this, and his solution seems to work fine, so I'm approving this MP.

review: Approve

[Lucas Kanashiro (lucaskanashiro)]

Thanks Sergion. Uploaded:

$ git push pkg upload/0.12.14
Enumerating objects: 15, done.
Counting objects: 100% (15/15), done.
Delta compression using up to 32 threads
Compressing objects: 100% (10/10), done.
Writing objects: 100% (10/10), 1.23 KiB | 1.23 MiB/s, done.
Total 10 (delta 6), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/ubuntu-fan
 * [new tag] upload/0.12.14 -> upload/0.12.14
$ dput ubuntu ../ubuntu-fan_0.12.14_source.changes
Checking signature on .changes
gpg: ../ubuntu-fan_0.12.14_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: ../ubuntu-fan_0.12.14.dsc: Valid signature from F823A2729883C97C
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading ubuntu-fan_0.12.14.dsc: done.
  Uploading ubuntu-fan_0.12.14.tar.xz: done.
  Uploading ubuntu-fan_0.12.14_source.changes: done.
Successfully uploaded packages.

diff --git a/debian/changelog b/debian/changelog
index 8d2628c..b990ae6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+ubuntu-fan (0.12.14) hirsute; urgency=medium
+
+  * d/t/control: add squid.internal to $no_proxy in the docker test.
+
+ -- Lucas Kanashiro <[e-mail]>  Fri, 22 Jan 2021 16:33:15 -0300
+
 ubuntu-fan (0.12.13) eoan; urgency=medium
 
   * d/t/control: Fix missing dependencies for autopkgtests (LP: #1832238)
diff --git a/debian/tests/control b/debian/tests/control
index 8a76d7b..c79b173 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,4 +1,4 @@
-Tests: docker
+Test-Command: no_proxy=squid.internal,$no_proxy docker
 Depends: ubuntu-fan, docker.io, bridge-utils, net-tools
 Restrictions: needs-root, isolation-machine, allow-stderr