Code review comment for ~lucaskanashiro/ubuntu/+source/strongswan:groovy-merge
Revision history for this message
| Christian Ehrhardt (paelzer) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Glad the "droppable after 20.04" now also could go away :-)
Yeah, the remaining Delta LGTM.
Lets next week (on the invite you sent) talk about the details of these two remaining deltas, why they exists and if/how we might upstream them.
Further I'd want to talk about testing strongswan merges in that session and we'll run the tests I used to use on your PPA together. From there you might have a chance to extend these tests a bit maybe, but you don't need to do the initial-work that already exists.
One feedback on the changelog, the NTRU bug should no more be (LP: #1863749) as that would ping on the bug, make it (LP: 1863749) or such to avoid bumping it. I already saw that LP automatically linked your MP on the bug due to it being referenced on the commit subject - rename that and the changelog on a rebase please :-)