Code review comment for ~lucaskanashiro/ubuntu/+source/resource-agents:merge-lunar

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lucas.

Package builds fine. Even though you provided local autopkgtest results, I took the liberty to trigger autopkgtest runs against the build that's in the PPA. Please take a look at their results before uploading, just to be safe.

You can squash the last commit with the "reconstruct-changelog" one.

Otherwise, everything else LGTM. range-diff is very clean and the Debian changes don't need any intervention.

+1 assuming that the dep8 tests pass in the infrastructure.

review: Approve

« Back to merge proposal