Merge ~lucaskanashiro/ubuntu/+source/resource-agents:merge-lunar into ubuntu/+source/resource-agents:debian/sid

Proposed by Lucas Kanashiro
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: git-ubuntu bot
Merged at revision: a3c1fd84051690e37a4d7c88d48ba519ef2cfe65
Proposed branch: ~lucaskanashiro/ubuntu/+source/resource-agents:merge-lunar
Merge into: ubuntu/+source/resource-agents:debian/sid
Diff against target: 790 lines (+538/-45)
15 files modified
debian/DEPRECATED_AGENTS (+13/-0)
debian/changelog (+274/-0)
debian/control (+71/-5)
debian/curated-agents (+5/-0)
debian/extract-agents-description (+44/-0)
debian/install-common-files (+41/-0)
debian/install-curated-agents (+25/-0)
debian/install-ldirectord-files (+26/-0)
debian/resource-agents-cleanup (+13/-0)
debian/resource-agents-common.lintian-overrides (+11/-0)
debian/resource-agents-extra.docs (+1/-0)
debian/resource-agents-extra.lintian-overrides (+0/-6)
debian/rules (+13/-16)
debian/tests/control (+1/-1)
dev/null (+0/-17)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Sergio Durigan Junior (community) Approve
Canonical Server Reporter Pending
Review via email: mp+435969@code.launchpad.net

Description of the change

Merge version 1:4.11.0-3 from Debian unstable. All the delta was kept since it is the split of agents in curated and non-curated (Ubuntu only).

The proposed package is available in this PPA:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/ha-stack/+packages

autopkgtest summary in a local run:

autopkgtest [10:36:33]: @@@@@@@@@@@@@@@@@@@@ summary
IPaddr2 PASS
command1 PASS
command2 PASS
command3 PASS
command4 PASS
command5 PASS
command6 PASS
command7 PASS
command8 PASS
command9 PASS
command10 PASS
command11 PASS
command12 PASS
command13 PASS

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lucas.

Package builds fine. Even though you provided local autopkgtest results, I took the liberty to trigger autopkgtest runs against the build that's in the PPA. Please take a look at their results before uploading, just to be safe.

You can squash the last commit with the "reconstruct-changelog" one.

Otherwise, everything else LGTM. range-diff is very clean and the Debian changes don't need any intervention.

+1 assuming that the dep8 tests pass in the infrastructure.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: lucaskanashiro, sergiodj
Uploaders: lucaskanashiro, sergiodj
MP auto-approved

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thank you for the review Sergio! The tests have passed, so I am uploading the package:

Uploading resource-agents_4.11.0-3ubuntu1.dsc
Uploading resource-agents_4.11.0.orig.tar.gz
Uploading resource-agents_4.11.0-3ubuntu1.debian.tar.xz
Uploading resource-agents_4.11.0-3ubuntu1_source.buildinfo
Uploading resource-agents_4.11.0-3ubuntu1_source.changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/DEPRECATED_AGENTS b/debian/DEPRECATED_AGENTS
2new file mode 100644
3index 0000000..ce1d688
4--- /dev/null
5+++ b/debian/DEPRECATED_AGENTS
6@@ -0,0 +1,13 @@
7+# Deprecated agents
8+
9+All the agents listed below are no longer maintained upstream and their use is
10+discouraged. They might be removed in future releases.
11+
12+* Evmsd: EVMS is no longer actively maintained and should not be used.
13+* EvmsSCC: EVMS is no longer actively maintained and should not be used.
14+* LinuxSCSI: This agent makes use of Linux SCSI hot-plug functionality which has
15+ been superseded by SCSI reservations.
16+* pingd: It was superseded by ocf:pacemaker:pingd.
17+* scsi2reservation: It depends on scsi_reserve which is not supported
18+ (SCSI-2 reservation is not supported, please use SCSI-3 reservation. That can
19+ be achieved with the sg_persist resource agent)
20diff --git a/debian/changelog b/debian/changelog
21index d15f488..57dfd15 100644
22--- a/debian/changelog
23+++ b/debian/changelog
24@@ -1,3 +1,28 @@
25+resource-agents (1:4.11.0-3ubuntu1) lunar; urgency=medium
26+
27+ * Merge with Debian unstable (LP: #1993440). Remaining changes:
28+ - d/control: Demote python3-googleapi to Suggests to avoid inclusion
29+ in Ubuntu main.
30+ - Create the resource-agents-common binary package.
31+ This new binary package will be used by curated and non-curated
32+ Resource Agents.
33+ - d/control: add python3 as a runtime dependency to resource-agents.
34+ Lintian complained that one of the scripts requires python3 and it was
35+ not listed as a dependency.
36+ - Create the resource-agents-base binary package.
37+ It contains all the resource agents curated by Ubuntu Server.
38+ - Rename resource-agents with non-curated agents to resource-agents-extra.
39+ - Create a transitional binary package called resource-agents.
40+ It depends on both resource-agents-{base,extra}.
41+ - d/curated-agents: add LVM-activate and iSCSI related agents.
42+ They are iscsi, iSCSILogicalUnit and iSCSITarget.
43+ - d/control: suggest packages used by the agents in the base binary
44+ package (LP #1863677).
45+ - d/DEPRECATED_AGENTS: document the agents deprecated by upstream.
46+ Also create d/resource-agents-extra.docs to install it.
47+
48+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Wed, 18 Jan 2023 09:41:55 -0300
49+
50 resource-agents (1:4.11.0-3) unstable; urgency=medium
51
52 * debian/patches: fix build failure in shellcheck of WAS6
53@@ -17,6 +42,38 @@ resource-agents (1:4.11.0-2) unstable; urgency=medium
54
55 -- Valentin Vidic <vvidic@debian.org> Sun, 13 Nov 2022 13:58:03 +0100
56
57+resource-agents (1:4.11.0-1ubuntu1) kinetic; urgency=medium
58+
59+ * Merge with Debian unstable (LP: #1971317). Remaining changes:
60+ - d/control: Demote python3-googleapi to Suggests to avoid inclusion
61+ in Ubuntu main.
62+ - Create the resource-agents-common binary package.
63+ This new binary package will be used by curated and non-curated
64+ Resource Agents.
65+ - d/control: add python3 as a runtime dependency to resource-agents.
66+ Lintian complained that one of the scripts requires python3 and it was
67+ not listed as a dependency.
68+ - Create the resource-agents-base binary package.
69+ It contains all the resource agents curated by Ubuntu Server.
70+ - Rename resource-agents with non-curated agents to resource-agents-extra.
71+ - Create a transitional binary package called resource-agents.
72+ It depends on both resource-agents-{base,extra}.
73+ - d/curated-agents: add LVM-activate agent.
74+ - d/curated-agents: add iSCSI resource agents.
75+ They are iscsi, iSCSILogicalUnit and iSCSITarget.
76+ - d/control: suggest packages used by the agents in the base binary
77+ package (LP #1863677).
78+ - d/DEPRECATED_AGENTS: document the agents deprecated by upstream.
79+ Also create d/resource-agents-extra.docs to install it.
80+ * Dropped:
81+ - d/control: remove old Conflicts and Replaces.
82+ + Replaces/Conflicts in resource-agents*: cluster-agents, rgmanager
83+ and resource-agents-dev.
84+ + Conflicts in ldirectord: libpils0, libstonith0 and stonith.
85+ [changes applied in Debian version 1:4.10.0-1]
86+
87+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Mon, 08 Aug 2022 17:35:17 -0300
88+
89 resource-agents (1:4.11.0-1) unstable; urgency=medium
90
91 * New upstream version 4.11.0
92@@ -43,6 +100,138 @@ resource-agents (1:4.10.0-1) unstable; urgency=medium
93
94 -- Valentin Vidic <vvidic@debian.org> Sun, 03 Apr 2022 13:39:33 +0200
95
96+resource-agents (1:4.7.0-1ubuntu8) kinetic; urgency=medium
97+
98+ * d/control: breaks/replaces for file reorg (LP: #1981598)
99+ to un-break upgrades
100+
101+ -- Christian Ehrhardt <christian.ehrhardt@canonical.com> Thu, 14 Jul 2022 13:09:42 +0200
102+
103+resource-agents (1:4.7.0-1ubuntu7) jammy; urgency=medium
104+
105+ * d/DEPRECATED_AGENTS: document the agents deprecated by upstream.
106+ * d/resource-agents-extra.docs: install d/DEPRECATED_AGENTS.
107+
108+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Tue, 29 Mar 2022 16:47:03 -0300
109+
110+resource-agents (1:4.7.0-1ubuntu6) jammy; urgency=medium
111+
112+ * d/curated-agents: add iSCSI resource agents.
113+ They are iscsi, iSCSILogicalUnit and iSCSITarget.
114+ * d/control: suggest packages used by the agents in the base binary package
115+ (LP: #1863677).
116+
117+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Thu, 24 Feb 2022 11:58:58 -0300
118+
119+resource-agents (1:4.7.0-1ubuntu5) impish; urgency=medium
120+
121+ * d/curated-agents: add LVM-activate agent.
122+ * d/install-curated-agents: check if ocft config exists to install it.
123+
124+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Fri, 11 Jun 2021 16:12:05 -0300
125+
126+resource-agents (1:4.7.0-1ubuntu4) impish; urgency=medium
127+
128+ * Rename resource-agents with non-curated agents to resource-agents-extra.
129+ - d/control: rename the resource-agents binary package to
130+ resource-agents-extra.
131+ - d/extract-agents-description:
132+ + Rename the package name used in the substvars filename.
133+ + Rename all the occurrences of the 'unsupported' term to 'non-curated'.
134+ - Rename RESOURCE_AGENTS_DIR to RESOURCE_AGENTS_EXTRA_DIR with the
135+ appropriate path in the following files:
136+ + d/install-common-files
137+ + d/install-common-files
138+ + d/install-supported-agents
139+ + d/resource-agents-cleanup
140+ + d/rules
141+ * Rename resource-agents-supported with curated agents to
142+ resource-agents-base.
143+ - d/control:
144+ + Rename resource-agents-supported binary package to resource-agents-base.
145+ + Update the short and long description to not use the 'supported' term.
146+ + Rename the supportedAgents substvar to curatedAgents.
147+ - d/curated-agents: new file, this is the renamed d/supported-agents file.
148+ - d/extract-agents-description:
149+ + Rename the package name used in the substvars filename.
150+ + Rename all the occurrences of the 'supported' term to 'curated'.
151+ - d/install-common-files: Rename all the occurrences of the 'supported'
152+ term to 'curated'.
153+ - d/install-curated-agents: new file, this is the renamed
154+ d/install-supported-agents script.
155+ - d/rules: call d/install-curated-agents instead of
156+ d/install-supported-agents.
157+ - d/t/control: make IPaddr2 test depend on resource-agents-base instead of
158+ resource-agents-supported.
159+ * Create a transitional binary package called resource-agents.
160+ - d/control: add a new section for the transitional package, adding
161+ resource-agents-{base,extra} as dependencies.
162+ * d/control: add a missing Breaks/Replaces relation to the
163+ resource-agents-base.
164+
165+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Wed, 12 May 2021 16:15:15 -0300
166+
167+resource-agents (1:4.7.0-1ubuntu3) impish; urgency=medium
168+
169+ * d/control: make resource-agents recommend resource-agents-supported.
170+
171+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Mon, 03 May 2021 09:10:54 -0300
172+
173+resource-agents (1:4.7.0-1ubuntu2) impish; urgency=medium
174+
175+ * Create the resource-agents-common binary package with files to be shared
176+ by the supported and unsupported agents.
177+ - d/control: add a new paragraph for the new binary package and add it as
178+ a runtime dependency of resource-agents.
179+ - d/extract-agents-description: add this new script to extract agents
180+ description.
181+ - d/{ldirectord,resource-agents}.install: removed, now files are installed
182+ via rules file.
183+ - d/install-{common,ldirectord}-files: create those scripts to install files
184+ in resource-agents-common and ldirectord binary packages.
185+ - d/rules:
186+ + Override dh_auto_install to set the $DESTDIR variable.
187+ + Override dh_install to move files to the correspondent binary package.
188+ + Clean up the dh_gencontrol override, call the
189+ d/extract-agents-description shell script instead of implementing a
190+ complex logic in a Makefile.
191+ * Create the resource-agents-supported binary package.
192+ - d/control: add a new paragraph for the new binary package.
193+ - d/extract-agents-description: update the script to set also the new
194+ supportedAgents substvar.
195+ - d/install-supported-agents: add a shell script to manage the
196+ installation of all supported agents into the right binary package.
197+ - d/resource-agents-common.lintian-overrides: create this new file to move
198+ the lintian overrides previously present in resource-agents binary
199+ package.
200+ - d/resource-agents.lintian-overrides: remove the overrides referring to
201+ code moves to resource-agents-common.
202+ - d/rules: call the d/install-supported-agents shell script in the
203+ dh_install override.
204+ - d/supported-agents: add a file with a list of the supported agents.
205+ - d/t/control: make IPaddr2 test depend on resource-agents-supported
206+ instead of resource-agents.
207+ * Add python3 as a runtime dependency of resource-agents. Lintian complained
208+ about that.
209+
210+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Wed, 28 Apr 2021 09:39:00 -0300
211+
212+resource-agents (1:4.7.0-1ubuntu1) hirsute; urgency=medium
213+
214+ * Merge with Debian unstable. Remaining changes:
215+ - d/control: Demote python3-googleapi to Suggests to avoid inclusion
216+ in Ubuntu main.
217+ * Dropped:
218+ - d/p/u/lp1895348-*: Post Release Fixes (LP #1895348):
219+ + [d22700fc] azure-lb: Don't redirect nc listener output to pidfile
220+ + [3b0ffc59] build: fix distcheck issue introduced by including
221+ READMEs in heartbeat directory
222+ + [73551ac0] galera: Fix automatic recovery when a cluster was not
223+ gracefully stopped
224+ [applied by upstream]
225+
226+ -- Lucas Kanashiro <kanashiro@ubuntu.com> Mon, 18 Jan 2021 17:34:05 -0300
227+
228 resource-agents (1:4.7.0-1) unstable; urgency=medium
229
230 * New upstream version 4.7.0
231@@ -58,6 +247,27 @@ resource-agents (1:4.7.0-1) unstable; urgency=medium
232
233 -- Valentin Vidic <vvidic@debian.org> Mon, 14 Dec 2020 14:34:09 +0100
234
235+resource-agents (1:4.6.1-1ubuntu2) groovy; urgency=medium
236+
237+ * d/p/u/lp1895348-*: Post Release Fixes (LP: #1895348):
238+ - [d22700fc] azure-lb: Don't redirect nc listener output to pidfile
239+ - [3b0ffc59] build: fix distcheck issue introduced by including
240+ READMEs in heartbeat directory
241+ - [73551ac0] galera: Fix automatic recovery when a cluster was not
242+ gracefully stopped
243+
244+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Fri, 11 Sep 2020 19:30:14 +0000
245+
246+resource-agents (1:4.6.1-1ubuntu1) groovy; urgency=medium
247+
248+ * Merge with Debian unstable (LP: #1886603). Remaining changes:
249+ - d/control: Demote python3-googleapi to Suggests to avoid inclusion in
250+ Ubuntu main.
251+ * Dropped (from Ubuntu):
252+ - Remove bind9 autopkgtest not compatible with ubuntu (LP: 1872877)
253+
254+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Fri, 10 Jul 2020 11:55:55 -0300
255+
256 resource-agents (1:4.6.1-1) unstable; urgency=medium
257
258 * New upstream version 4.6.1
259@@ -65,6 +275,20 @@ resource-agents (1:4.6.1-1) unstable; urgency=medium
260
261 -- Valentin Vidic <vvidic@debian.org> Thu, 18 Jun 2020 21:03:31 +0200
262
263+resource-agents (1:4.5.0-2ubuntu2) focal; urgency=medium
264+
265+ * Remove bind9 autopkgtest not compatible with ubuntu (LP: #1872877)
266+
267+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Wed, 15 Apr 2020 03:32:33 +0000
268+
269+resource-agents (1:4.5.0-2ubuntu1) focal; urgency=medium
270+
271+ * Merge with Debian unstable (LP: #1866383). Remaining changes:
272+ - d/control: Demote python3-googleapi to Suggests to avoid
273+ inclusion in Ubuntu main.
274+
275+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Tue, 07 Apr 2020 22:43:39 +0000
276+
277 resource-agents (1:4.5.0-2) unstable; urgency=medium
278
279 * debian/tests: fix test for new bind9 version
280@@ -78,6 +302,16 @@ resource-agents (1:4.5.0-1) unstable; urgency=medium
281
282 -- Valentin Vidic <vvidic@debian.org> Fri, 06 Mar 2020 19:50:58 +0100
283
284+resource-agents (1:4.4.0-3ubuntu1) focal; urgency=low
285+
286+ * Merge from Debian unstable. Remaining changes:
287+ - d/control: Demote python3-googleapi to Suggests to avoid inclusion
288+ in Ubuntu main.
289+ * Dropped changes, included in Debian:
290+ - Test dep on postgresql, not postgresql-11 which is now gone.
291+
292+ -- Steve Langasek <steve.langasek@ubuntu.com> Sat, 15 Feb 2020 16:56:30 -0800
293+
294 resource-agents (1:4.4.0-3) unstable; urgency=medium
295
296 * debian/salsa-ci.yml: enable CI
297@@ -93,6 +327,27 @@ resource-agents (1:4.4.0-2) unstable; urgency=medium
298
299 -- Valentin Vidic <vvidic@debian.org> Sat, 16 Nov 2019 10:47:46 +0100
300
301+resource-agents (1:4.4.0-1ubuntu2) focal; urgency=medium
302+
303+ * Test dep on postgresql, not postgresql-11 which is now gone.
304+
305+ -- Steve Langasek <steve.langasek@ubuntu.com> Fri, 14 Feb 2020 17:20:21 -0800
306+
307+resource-agents (1:4.4.0-1ubuntu1) focal; urgency=medium
308+
309+ * Merge from Debian unstable. Remaining changes:
310+ - d/control: Demote python3-googleapi to Suggests to avoid inclusion
311+ in Ubuntu main.
312+ * Dropped changes (in Debian):
313+ - d/p/lp1825250-ethmonitor-check-if-interface-exists-by-link.patch:
314+ ethmonitor: check if interface exists by link.
315+ [Fixed upstream]
316+ - d/p/lp1825250-ethmonitor-fix-is_interface-regression.patch:
317+ ethmonitor: fix is_interface() regression.
318+ [Fixed upstream]
319+
320+ -- Rafael David Tinoco <rafaeldtinoco@ubuntu.com> Fri, 08 Nov 2019 16:45:38 +0000
321+
322 resource-agents (1:4.4.0-1) unstable; urgency=medium
323
324 * New upstream version 4.4.0
325@@ -128,6 +383,24 @@ resource-agents (1:4.2.0-2) unstable; urgency=medium
326
327 -- Valentin Vidic <vvidic@debian.org> Sun, 09 Dec 2018 21:04:49 +0100
328
329+resource-agents (1:4.2.0-1ubuntu2) eoan; urgency=medium
330+
331+ * Fix heartbeat/ethmonitor not listing network interfaces without IP
332+ addresses (LP: #1825250). Fixed by upstream patches:
333+ - d/p/lp1825250-ethmonitor-check-if-interface-exists-by-link.patch:
334+ ethmonitor: check if interface exists by link
335+ - d/p/lp1825250-ethmonitor-fix-is_interface-regression.patch:
336+ ethmonitor: fix is_interface() regression
337+
338+ -- Heitor Alves de Siqueira <halves@canonical.com> Tue, 23 Apr 2019 14:17:29 -0300
339+
340+resource-agents (1:4.2.0-1ubuntu1) disco; urgency=medium
341+
342+ * d/control: Demote python3-googleapi to Suggests to avoid inclusion
343+ in Ubuntu main.
344+
345+ -- James Page <james.page@ubuntu.com> Thu, 22 Nov 2018 14:31:51 +0000
346+
347 resource-agents (1:4.2.0-1) unstable; urgency=medium
348
349 * New upstream version 4.2.0
350@@ -619,3 +892,4 @@ cluster-agents (1:1.0+hg20090915-1) unstable; urgency=low
351 * Initial release of packages for the cluster agents collection
352
353 -- Martin Loschwitz <madkiss@debian.org> Tue, 15 Sep 2009 09:56:16 +0000
354+
355diff --git a/debian/control b/debian/control
356index ac1fc59..f6e9365 100644
357--- a/debian/control
358+++ b/debian/control
359@@ -1,7 +1,8 @@
360 Source: resource-agents
361 Section: admin
362 Priority: optional
363-Maintainer: Debian HA Maintainers <debian-ha-maintainers@alioth-lists.debian.net>
364+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
365+XSBC-Original-Maintainer: Debian HA Maintainers <debian-ha-maintainers@alioth-lists.debian.net>
366 Uploaders: Adrian Vondendriesch <adrian.vondendriesch@credativ.de>,
367 Valentin Vidic <vvidic@debian.org>
368 Build-Depends: autoconf,
369@@ -39,17 +40,82 @@ Vcs-Browser: https://salsa.debian.org/ha-team/resource-agents
370 Vcs-Git: https://salsa.debian.org/ha-team/resource-agents.git
371
372 Package: resource-agents
373+Architecture: all
374+Section: oldlibs
375+Depends: ${misc:Depends},
376+ resource-agents-base (>= ${source:Version}),
377+ resource-agents-extra (>= ${source:Version})
378+Description: Transitional package for the resource-agents
379+ This package contains cluster resource agents (RAs) compliant with the Open
380+ Cluster Framework (OCF) specification, used to interface with various services
381+ in a High Availability environment managed by the Pacemaker resource manager.
382+ .
383+ This is a transitional package which provides a set of curated
384+ (resource-agents-base) and non-curated (resource-agents-extra) agents.
385+
386+Package: resource-agents-extra
387 Architecture: any
388-Depends: ${misc:Depends}, ${shlibs:Depends}, ${python3:Depends}, bc, cluster-glue, gawk
389-Recommends: libxml2-utils, net-tools, python3-googleapi
390-Provides: resource-agents-dev
391+Depends: ${misc:Depends}, ${shlibs:Depends}, ${python3:Depends},
392+ bc,
393+ cluster-glue,
394+ gawk,
395+ python3,
396+ resource-agents-common (>= ${source:Version})
397+Recommends: libxml2-utils,
398+ net-tools,
399+ resource-agents-base (>= ${source:Version})
400+Suggests: python3-googleapi
401+Replaces: resource-agents (<< 1:4.7.0-1ubuntu2),
402+ resource-agents-base (<<1:4.7.0-1ubuntu7)
403+Breaks: resource-agents (<< 1:4.7.0-1ubuntu2),
404+ resource-agents-base (<<1:4.7.0-1ubuntu7)
405 Description: Cluster Resource Agents
406 This package contains cluster resource agents (RAs) compliant with the Open
407 Cluster Framework (OCF) specification, used to interface with various services
408 in a High Availability environment managed by the Pacemaker resource manager.
409 .
410 Agents included:
411- ${agents}
412+ ${agents}
413+
414+Package: resource-agents-base
415+Architecture: all
416+Depends: ${misc:Depends},
417+ resource-agents-common (>= ${source:Version})
418+Suggests:
419+# for iscsi agent
420+ open-iscsi,
421+# for iSCSITarget and iSCSILogicalUnit agents (the recommended implementation is lio-t)
422+ targetcli-fb,
423+# for LVM-activate agent
424+ dmsetup,
425+ lvm2
426+Replaces: resource-agents (<< 1:4.7.0-1ubuntu2),
427+ resource-agents-extra (<<1:4.7.0-1ubuntu7)
428+Breaks: resource-agents (<< 1:4.7.0-1ubuntu2),
429+ resource-agents-extra (<<1:4.7.0-1ubuntu7)
430+Description: Cluster Resource Agents curated by Ubuntu
431+ This package contains cluster resource agents (RAs) compliant with the Open
432+ Cluster Framework (OCF) specification, used to interface with various services
433+ in a High Availability environment managed by the Pacemaker resource manager.
434+ .
435+ This package contains the Resource Agents that are curated by the Ubuntu
436+ Server team.
437+ .
438+ Agents included:
439+ ${curatedAgents}
440+
441+Package: resource-agents-common
442+Architecture: any
443+Depends: ${misc:Depends}, ${shlibs:Depends}, ${python3:Depends}
444+Replaces: resource-agents (<< 1:4.7.0-1ubuntu2)
445+Breaks: resource-agents (<< 1:4.7.0-1ubuntu2)
446+Provides: resource-agents-dev
447+Description: Common files used by the Cluster Resource Agents
448+ This package contains cluster resource agents (RAs) compliant with the Open
449+ Cluster Framework (OCF) specification, used to interface with various services
450+ in a High Availability environment managed by the Pacemaker resource manager.
451+ .
452+ This package provides common files used by the Resource Agents.
453
454 Package: ldirectord
455 Architecture: all
456diff --git a/debian/curated-agents b/debian/curated-agents
457new file mode 100644
458index 0000000..4cf27cd
459--- /dev/null
460+++ b/debian/curated-agents
461@@ -0,0 +1,5 @@
462+IPaddr2
463+iscsi
464+iSCSILogicalUnit
465+iSCSITarget
466+LVM-activate
467diff --git a/debian/extract-agents-description b/debian/extract-agents-description
468new file mode 100755
469index 0000000..9824f4d
470--- /dev/null
471+++ b/debian/extract-agents-description
472@@ -0,0 +1,44 @@
473+#!/bin/bash
474+
475+set -x
476+
477+export LC_ALL=C
478+
479+agents=()
480+curated_agents=()
481+non_curated_agents=()
482+
483+readonly RESOURCE_AGENTS_EXTRA_DIR="debian/resource-agents-extra"
484+readonly RESOURCE_AGENTS_COMMON_DIR="debian/resource-agents-common"
485+readonly RESOURCE_AGENTS_BASE_DIR="debian/resource-agents-base"
486+readonly NON_CURATED_HEARTBEAT_DIR="$RESOURCE_AGENTS_EXTRA_DIR/usr/lib/ocf/resource.d/heartbeat"
487+readonly CURATED_HEARTBEAT_DIR="$RESOURCE_AGENTS_BASE_DIR/usr/lib/ocf/resource.d/heartbeat"
488+
489+export OCF_ROOT="$RESOURCE_AGENTS_COMMON_DIR/usr/lib/ocf"
490+
491+for agent in $CURATED_HEARTBEAT_DIR/* $NON_CURATED_HEARTBEAT_DIR/*; do
492+ name=$(basename "$agent")
493+ short_desc=$("$agent" meta-data | xml_grep --root resource-agent/shortdesc --text_only /dev/stdin)
494+
495+ # Remove unwanted whitespaces
496+ short_desc=$(echo -e $short_desc | sed -e 's/^[[:space:]]*//' -e 's/[[:space:]]*$//')
497+
498+ # Limit the size of the string to 80 characters
499+ desc=$(echo -n "$name: $short_desc" | sed -e 's/^\(.\{75\}\).\{4\}.*/\1.../')
500+
501+ agents+=("$desc")
502+done
503+
504+for agent in "${agents[@]}"; do
505+ if grep -qFx $(cut -d: -f1 <<< "$agent") debian/curated-agents; then
506+ curated_agents+=("$agent\${Newline}")
507+ else
508+ non_curated_agents+=("$agent\${Newline}")
509+ fi
510+done
511+
512+echo "agents=${non_curated_agents[*]}" >> debian/resource-agents-extra.substvars
513+echo "curatedAgents=${curated_agents[*]}" >> debian/resource-agents-base.substvars
514+
515+# Clean up pycache
516+rm -rf debian/resource-agents-common/usr/lib/ocf/lib/heartbeat/__pycache__
517diff --git a/debian/install-common-files b/debian/install-common-files
518new file mode 100755
519index 0000000..cd14889
520--- /dev/null
521+++ b/debian/install-common-files
522@@ -0,0 +1,41 @@
523+#!/bin/bash
524+
525+# This script aims to install all the common files used by resource-agents-base
526+# and resource-agents-extra into resource-agents-common binary package.
527+
528+set -x
529+
530+readonly RESOURCE_AGENTS_EXTRA_DIR="debian/resource-agents-extra"
531+readonly RESOURCE_AGENTS_COMMON_DIR="debian/resource-agents-common"
532+
533+readonly COMMON_DIRS="usr/include/heartbeat usr/lib/heartbeat
534+ usr/lib/ocf/lib/heartbeat usr/share/pkgconfig etc/ha.d
535+ lib/systemd/system usr/sbin usr/share/man/man8
536+ usr/lib/tmpfiles.d usr/libexec/heartbeat"
537+
538+for dir in $COMMON_DIRS; do
539+ mkdir -p "$RESOURCE_AGENTS_COMMON_DIR/$dir"
540+ mv "$RESOURCE_AGENTS_EXTRA_DIR/$dir"/* "$RESOURCE_AGENTS_COMMON_DIR/$dir"
541+done
542+
543+mkdir -p "$RESOURCE_AGENTS_COMMON_DIR"/usr/lib/ocf/resource.d/heartbeat \
544+ "$RESOURCE_AGENTS_COMMON_DIR"/usr/share/resource-agents/ocft
545+
546+readonly TARGETS="ocf-binaries ocf-directories ocf-returncodes ocf-shellfuncs"
547+for tgt in $TARGETS; do
548+ ln -r -s -T "$RESOURCE_AGENTS_COMMON_DIR/usr/lib/ocf/lib/heartbeat/$tgt" \
549+ "$RESOURCE_AGENTS_COMMON_DIR/usr/lib/ocf/resource.d/heartbeat/.$tgt"
550+ rm "$RESOURCE_AGENTS_EXTRA_DIR/usr/lib/ocf/resource.d/heartbeat/.$tgt"
551+done
552+
553+readonly FILES="metadata.rng ra-api-1.dtd"
554+for file in $FILES; do
555+ mv "$RESOURCE_AGENTS_EXTRA_DIR/usr/share/resource-agents/$file" \
556+ "$RESOURCE_AGENTS_COMMON_DIR"/usr/share/resource-agents/
557+done
558+
559+readonly OCFT_FILES="README README.zh_CN caselib helpers.sh runocft runocft.prereq"
560+for file in $OCFT_FILES; do
561+ mv "$RESOURCE_AGENTS_EXTRA_DIR/usr/share/resource-agents/ocft/$file" \
562+ "$RESOURCE_AGENTS_COMMON_DIR"/usr/share/resource-agents/ocft/
563+done
564diff --git a/debian/install-curated-agents b/debian/install-curated-agents
565new file mode 100755
566index 0000000..2e3fbff
567--- /dev/null
568+++ b/debian/install-curated-agents
569@@ -0,0 +1,25 @@
570+#!/bin/bash
571+
572+# This script aims to install all the agents curated by the Ubuntu community
573+# into resource-agents-base binary package.
574+
575+set -x
576+
577+readonly RESOURCE_AGENTS_BASE="debian/resource-agents-base"
578+readonly RESOURCE_AGENTS_EXTRA="debian/resource-agents-extra"
579+
580+mkdir -p $RESOURCE_AGENTS_BASE/usr/share/resource-agents/ocft/configs/ \
581+ $RESOURCE_AGENTS_BASE/usr/share/man/man7/ \
582+ $RESOURCE_AGENTS_BASE/usr/lib/ocf/resource.d/heartbeat/
583+
584+for agent in $(cat debian/curated-agents); do
585+ mv $RESOURCE_AGENTS_EXTRA/usr/lib/ocf/resource.d/heartbeat/$agent \
586+ $RESOURCE_AGENTS_BASE/usr/lib/ocf/resource.d/heartbeat/
587+ mv $RESOURCE_AGENTS_EXTRA/usr/share/man/man7/ocf_heartbeat_$agent.7 \
588+ $RESOURCE_AGENTS_BASE/usr/share/man/man7/
589+
590+ if [ -f $RESOURCE_AGENTS_EXTRA/usr/share/resource-agents/ocft/configs/$agent ]; then
591+ mv $RESOURCE_AGENTS_EXTRA/usr/share/resource-agents/ocft/configs/$agent \
592+ $RESOURCE_AGENTS_BASE/usr/share/resource-agents/ocft/configs/
593+ fi
594+done
595diff --git a/debian/install-ldirectord-files b/debian/install-ldirectord-files
596new file mode 100755
597index 0000000..39c97d0
598--- /dev/null
599+++ b/debian/install-ldirectord-files
600@@ -0,0 +1,26 @@
601+#!/bin/bash
602+
603+# This script aims to install all the ldirectord files into its own binary package.
604+
605+set -x
606+
607+readonly RESOURCE_AGENTS_EXTRA_DIR="debian/resource-agents-extra"
608+readonly LDIRECTORD_DIR="debian/ldirectord"
609+
610+mkdir -p $LDIRECTORD_DIR/etc/ha.d/resource.d \
611+ $LDIRECTORD_DIR/etc/init.d \
612+ $LDIRECTORD_DIR/etc/logrotate.d \
613+ $LDIRECTORD_DIR/lib/systemd/system \
614+ $LDIRECTORD_DIR/usr/sbin \
615+ $LDIRECTORD_DIR/usr/share/man/man8
616+
617+cp debian/ldirectord.cf $LDIRECTORD_DIR/etc/ha.d
618+mv $RESOURCE_AGENTS_EXTRA_DIR/etc/ha.d/resource.d/ \
619+ $LDIRECTORD_DIR/etc/ha.d/
620+mv $RESOURCE_AGENTS_EXTRA_DIR/etc/init.d $LDIRECTORD_DIR/etc/
621+mv $RESOURCE_AGENTS_EXTRA_DIR/etc/logrotate.d $LDIRECTORD_DIR/etc/
622+mv $RESOURCE_AGENTS_EXTRA_DIR/lib/systemd/system/ldirectord.service \
623+ $LDIRECTORD_DIR/lib/systemd/system/
624+mv $RESOURCE_AGENTS_EXTRA_DIR/usr/sbin/ldirectord $LDIRECTORD_DIR/usr/sbin
625+mv $RESOURCE_AGENTS_EXTRA_DIR/usr/share/man/man8/ldirectord.8 \
626+ $LDIRECTORD_DIR/usr/share/man/man8/
627diff --git a/debian/ldirectord.install b/debian/ldirectord.install
628deleted file mode 100755
629index ba2ed80..0000000
630--- a/debian/ldirectord.install
631+++ /dev/null
632@@ -1,9 +0,0 @@
633-#!/usr/bin/dh-exec
634-
635-debian/ldirectord.cf /etc/ha.d
636-etc/ha.d/resource.d/ldirectord
637-etc/init.d/ldirectord
638-etc/logrotate.d/ldirectord
639-lib/systemd/system/ldirectord.service [linux-any]
640-usr/sbin/ldirectord
641-usr/share/man/man8/ldirectord.8
642diff --git a/debian/resource-agents-cleanup b/debian/resource-agents-cleanup
643new file mode 100755
644index 0000000..ad34bde
645--- /dev/null
646+++ b/debian/resource-agents-cleanup
647@@ -0,0 +1,13 @@
648+#!/bin/bash
649+
650+set -x
651+
652+readonly RESOURCE_AGENTS_EXTRA_DIR="debian/resource-agents-extra"
653+
654+# Those directories were moved to another binary package
655+readonly EMPTY_DIRS="etc lib run usr/include usr/lib/heartbeat usr/sbin
656+ usr/share/man/man8 usr/share/pkgconfig usr/lib/tmpfiles.d"
657+
658+for dir in $EMPTY_DIRS; do
659+ rm -rf $RESOURCE_AGENTS_EXTRA_DIR/$dir
660+done
661diff --git a/debian/resource-agents-common.lintian-overrides b/debian/resource-agents-common.lintian-overrides
662new file mode 100644
663index 0000000..3b7c8df
664--- /dev/null
665+++ b/debian/resource-agents-common.lintian-overrides
666@@ -0,0 +1,11 @@
667+# ignore manpage warnings
668+resource-agents-common: no-manual-page usr/sbin/ocft
669+resource-agents-common: no-manual-page usr/sbin/sfex_stat
670+
671+# these are sourced shell libraries:
672+resource-agents-common: script-not-executable [usr/lib/ocf/lib/heartbeat/findif.sh]
673+resource-agents-common: script-not-executable [usr/lib/ocf/lib/heartbeat/mysql-common.sh]
674+
675+# ignore notices about usr/lib
676+resource-agents-common: executable-in-usr-lib usr/lib/ocf/resource.d/heartbeat/*
677+resource-agents-common: repeated-path-segment lib usr/lib/ocf/lib/
678diff --git a/debian/resource-agents-extra.docs b/debian/resource-agents-extra.docs
679new file mode 100644
680index 0000000..62e425e
681--- /dev/null
682+++ b/debian/resource-agents-extra.docs
683@@ -0,0 +1 @@
684+debian/DEPRECATED_AGENTS
685diff --git a/debian/resource-agents.lintian-overrides b/debian/resource-agents-extra.lintian-overrides
686similarity index 90%
687rename from debian/resource-agents.lintian-overrides
688rename to debian/resource-agents-extra.lintian-overrides
689index cfdd8c5..e670aa5 100644
690--- a/debian/resource-agents.lintian-overrides
691+++ b/debian/resource-agents-extra.lintian-overrides
692@@ -1,12 +1,6 @@
693 # ignore manpage warnings
694-resource-agents: no-manual-page [usr/sbin/ocft]
695-resource-agents: no-manual-page [usr/sbin/sfex_stat]
696 resource-agents: groff-message 37: warning [p 1, 2.3i]: can't break line [usr/share/man/man7/ocf_heartbeat_openstack-info.7.gz:1]
697
698-# these are sourced shell libraries:
699-resource-agents: script-not-executable [usr/lib/ocf/lib/heartbeat/findif.sh]
700-resource-agents: script-not-executable [usr/lib/ocf/lib/heartbeat/mysql-common.sh]
701-
702 # ignore capitalization in agent names
703 resource-agents: capitalization-error-in-description apache Apache
704 resource-agents: capitalization-error-in-description mysql MySQL
705diff --git a/debian/resource-agents.install b/debian/resource-agents.install
706deleted file mode 100755
707index 5e44f54..0000000
708--- a/debian/resource-agents.install
709+++ /dev/null
710@@ -1,17 +0,0 @@
711-#!/usr/bin/dh-exec
712-etc/ha.d/shellfuncs
713-lib/systemd/system/resource-agents-deps.target [linux-any]
714-usr/include
715-usr/lib/ocf
716-usr/lib/tmpfiles.d/resource-agents.conf [linux-any]
717-usr/libexec/heartbeat
718-usr/sbin/ocft
719-usr/sbin/ocf-tester
720-usr/sbin/sfex_init [linux-any]
721-usr/sbin/sfex_stat [linux-any]
722-usr/share/doc/resource-agents
723-usr/share/man/man7/*
724-usr/share/man/man8/ocf-tester.8
725-usr/share/man/man8/sfex_init.8 [linux-any]
726-usr/share/pkgconfig/resource-agents.pc
727-usr/share/resource-agents
728diff --git a/debian/rules b/debian/rules
729index 9155449..dc1cb9e 100755
730--- a/debian/rules
731+++ b/debian/rules
732@@ -5,6 +5,8 @@ DPKG_EXPORT_BUILDFLAGS = 1
733 include /usr/share/dpkg/buildflags.mk
734 include /usr/share/dpkg/pkg-info.mk
735
736+RESOURCE_AGENTS_EXTRA_DIR="$(CURDIR)/debian/resource-agents-extra"
737+
738 %:
739 dh $@ --with python3
740
741@@ -26,8 +28,16 @@ override_dh_auto_configure:
742
743 # fix manpage header
744 override_dh_auto_install:
745- dh_auto_install
746- sed -i -e 's/^\(\.TH "[^"]*\?\)\\"/\1"/' $(CURDIR)/debian/tmp/usr/share/man/man7/*.7
747+ $(MAKE) install DESTDIR=$(RESOURCE_AGENTS_EXTRA_DIR)
748+ sed -i -e 's/^\(\.TH "[^"]*\?\)\\"/\1"/' $(RESOURCE_AGENTS_EXTRA_DIR)/usr/share/man/man7/*.7
749+
750+override_dh_install:
751+ debian/install-ldirectord-files
752+ debian/install-common-files
753+ debian/install-curated-agents
754+ debian/resource-agents-cleanup
755+
756+ dh_install
757
758 override_dh_python3:
759 dh_python3 /usr/lib/ocf/lib/heartbeat
760@@ -38,18 +48,5 @@ override_dh_auto_clean:
761 find . -name Makefile.in | xargs -r rm
762
763 override_dh_gencontrol:
764- set -e; \
765- export OCF_ROOT=$(CURDIR)/debian/resource-agents/usr/lib/ocf; \
766- export LC_ALL=C; \
767- ( \
768- echo -n "agents="; \
769- for agent in debian/resource-agents/usr/lib/ocf/resource.d/heartbeat/*; do \
770- echo "$$agent meta-data ..." >&2; \
771- desc=$$($$agent meta-data 2>/dev/null | xml_grep --root resource-agent/shortdesc --text_only /dev/stdin | sed -n '/^$$/!{s/^[[:space:]]*//p; q}'); \
772- line=$$(echo "$$(basename $$agent): $$desc" | sed -e 's/^\(.\{75\}\).\{4\}.*/\1.../'); \
773- echo -n " $$line\$${Newline}"; \
774- done; \
775- echo \
776- ) >> debian/resource-agents.substvars
777- rm -rf debian/resource-agents/usr/lib/ocf/lib/heartbeat/__pycache__
778+ debian/extract-agents-description
779 dh_gencontrol
780diff --git a/debian/tests/control b/debian/tests/control
781index e80996d..4b83b1d 100644
782--- a/debian/tests/control
783+++ b/debian/tests/control
784@@ -1,5 +1,5 @@
785 Tests: IPaddr2
786-Depends: resource-agents
787+Depends: resource-agents-base
788 Restrictions: needs-root, isolation-container
789
790 Test-Command: service ldirectord status

Subscribers

People subscribed via source and target branches