lp:~lttng/lttng-ust/lttng-ust

Created by Alex Montplaisir and last modified
Get this branch:
bzr branch lp:~lttng/lttng-ust/lttng-ust

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Ubuntu LTTng
Project:
LTTng-UST
Status:
Abandoned

Import details

Import Status: Suspended

This branch is an import of the HEAD branch of the Git repository at https://git.lttng.org/lttng-ust.git.

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-3 and finished taking 25 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 15 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-1 and finished taking 20 seconds — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-0 and finished taking 20 seconds — see the log

Recent revisions

3255. By Michael Jeanson <email address hidden>

ring-buffer: replace fallocate() with posix_fallocate()

Replace the linux specific fallocate(2) with the more portable
posix_fallocate(3) which has been available in Glibc since 2.18 and is
also available on other systems like FreeBSD. On Linux the Glibc
posix_fallocate implementation will end up using the fallocate system
call resulting in similar performance.

Also add a while loop around the call since both fallocate and
posix_fallocate can return EINTR on signal delivery.

Change-Id: Ib79e70d90f6bedf683b1231cb14a306539abde66
Signed-off-by: Michael Jeanson <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>

3254. By Michael Jeanson <email address hidden>

fix: MADV_REMOVE is linux specific

This allows building on FreeBSD but will make the reclaim feature
unavailable on this platform. Since we don't currently have a working
Tools build on anything but Linux, we can address this when we continue
the porting effort.

Change-Id: Id897142fe852016d7621180435a64cdc2219fcef
Signed-off-by: Michael Jeanson <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>

3253. By Mathieu Desnoyers

Fix: ustctl: sigbus handling: statement with no effect

The sigbus handling never returns "true" because the macro always
evaluates to "false".

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I577dc7bdfb467b5d172aff7a18f16775707833e0

3252. By Mathieu Desnoyers

Fix: Ancillary data protocol fixes

Fix:
- msg->msg_controllen needs to be the size of the sent file descriptors
  rather than the buffer. Caused failure on 32-bit architectures.
- Handle NULL cmptr in read_message_payload_and_ancillary.
- Re-introduce MSG_CMSG_CLOEXEC when receiving file descriptors so they
  are closed on exec.

Cleanup:
- Use ssize_t rather than int64_t for size.
- Use LTTNG_UST_COMM_MAX_SEND_FDS buffer now that we intend to bump the
  protocol major version when needed.
- Add memset to zero-initialize buffers.
- Use aligned() attribute for ancillary buffer alignment rather than
  union.
- Remove the MSG_TRUNC flag on receive, because we will handle protocol
  misbehavior by doing a socket shutdown, therefore we don't care if we
  truncate a too long message or not.

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I51ad78d9d99cbb45e39196a0fe2a1fa13bdbf2c5

3251. By Mathieu Desnoyers

Fix: ustctl: Null pointer dereferences

Found by Coverity:

** CID 1642128: Null pointer dereferences (REVERSE_INULL)
/src/lib/lttng-ust-ctl/ustctl.c: 1341 in lttng_ust_ctl_send_stream_to_ust()

*** CID 1642127: Null pointer dereferences (REVERSE_INULL)
/src/lib/lttng-ust-ctl/ustctl.c: 4609 in lttng_ust_ctl_send_counter_cpu_data_to_ust()

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: Icbb55b2f1505e3b72cccff88b369b9abce336654

3250. By Mathieu Desnoyers

Cleanup: lttng_ust_abi_event_exclusion ends with 0-len array

Ending lttng_ust_abi_event_exclusion with [LTTNG_UST_ABI_SYM_NAME_LEN][0]
is backwards. We really mean a 0-len array of LTTNG_UST_ABI_SYM_NAME_LEN
elements. Rather than reverse those, just express this as a 0-len
array.

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: Ic9b2c44d6535849c64b32e6dd29bfd72b80cca09

3249. By Mathieu Desnoyers

Fix: ustctl experimental counters

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I232fedb72bb7c367d6e24bf70c8775a442450e34

3248. By Olivier Dion <email address hidden>

ustctl: Zero initialize every message

Instead of relying on initialization rules that can change from C
versions and C toolchains, use memset(3) to zero initialize everything
sent over the wire.

Signed-off-by: Olivier Dion <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I84297ad275219ce5a5249e0ed97f8019dda80b93

3247. By Olivier Dion <email address hidden>

ustctl: Zero initialize context name buffer

This was zmalloc before. Initialize to 0 to mimic the old behavior.

Signed-off-by: Olivier Dion <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I238968eb055ff3387eda6fb030f302c459fa7aa3

3246. By Mathieu Desnoyers

Fix: Add missing error handling in lttng_ust_ctl_create_event

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: Iee169bff40403515c4f83ab42042c3102696a30a

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers