lp:~lttng/lttng-ust/lttng-ust

Created by Alex Montplaisir on 2011-11-03 and last modified on 2020-02-13
Get this branch:
bzr branch lp:~lttng/lttng-ust/lttng-ust

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Ubuntu LTTng
Project:
LTTng-UST
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://git.lttng.org/lttng-ust.git.

The next import is scheduled to run in 1 hour.

Last successful import was 4 hours ago.

Import started 4 hours ago on alnitak and finished 4 hours ago taking 20 seconds — see the log
Import started 10 hours ago on alnitak and finished 10 hours ago taking 20 seconds — see the log
Import started 16 hours ago on alnitak and finished 16 hours ago taking 20 seconds — see the log
Import started 23 hours ago on alnitak and finished 23 hours ago taking 20 seconds — see the log
Import started on 2020-02-15 on alnitak and finished on 2020-02-15 taking 20 seconds — see the log
Import started on 2020-02-15 on alnitak and finished on 2020-02-15 taking 20 seconds — see the log
Import started on 2020-02-15 on alnitak and finished on 2020-02-15 taking 20 seconds — see the log
Import started on 2020-02-14 on alnitak and finished on 2020-02-14 taking 20 seconds — see the log
Import started on 2020-02-14 on alnitak and finished on 2020-02-14 taking 20 seconds — see the log
Import started on 2020-02-14 on alnitak and finished on 2020-02-14 taking 20 seconds — see the log

Recent revisions

2368. By Francis Deslauriers <email address hidden> on 2020-02-13

Fix: lttng-ust-comm.c: return number of fd rather size of array

There are two conflicting comments for this function. One says it
returns the size of the received data and the other says it returns the
number of fd received.

It's more useful to receive the number of fd.

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I74084b461d396c3e623fa55100e6dd7e59dbea83

2367. By Francis Deslauriers <email address hidden> on 2020-02-13

liblttng-ust-comm: move `_unlock_fd_tracker()` after `close()` on error paths

Right now, receiving an error from `lttng_ust_add_fd_to_tracker()` means that
the fd was _not_ added to the fd set. So the `lttng_ust_safe_close_fd()`
(overriding `close()`) call will indeed close the fd as expected. So, it
doesn't matter if the `close()` is before or after the `_unlock_`.

Even considering that, I believe that it's clearer and more common to
have all related operations within the `_lock_` and `_unlock_`
functions. Also, `lttng_ust_add_fd_to_tracker()` might be modified in
the future and fail for some other reason.

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: Id29a6ab004cfd5ca601615e1a70c74cf754b12e2

2366. By Francis Deslauriers <email address hidden> on 2020-02-13

Cleanup: liblttng-ust: change `int` flag to `bool`

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I78b35b6b99afe8a84aba6c836df3bce8d2532760

2365. By Francis Deslauriers <email address hidden> on 2020-02-13

liblttng-ust: exit loop early on event enabler match

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I0fa3215f7cd6a2d32ac00d66cf5fc184abd14612

2364. By Francis Deslauriers <email address hidden> on 2020-02-13

Cleanup: remove redundant memory barrier

This memory barrier is redundant with the one already issued in
`rcu_assign_pointer()` function during the `set_tracepoint()` call.

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I78decd9ae87a63d7663928ad99e03831155548f7

2363. By Francis Deslauriers <email address hidden> on 2020-02-13

Cleanup: remove unused `lttng_bytecode_runtime::event` field

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: Id946b69e8cb4e79415d221f0be0889cfe707b439

2362. By Francis Deslauriers <email address hidden> on 2020-02-13

Docs: explain why unused `lttng_enabler::ctx` is kept around

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I93cc035ced57e29f3d675c8c611d5319194e6cfb

2361. By Francis Deslauriers <email address hidden> on 2020-02-13

Cleanup: remove unused `lttng_free_enabler_filter_bytecode()` func

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: Id9326aec2e6758ffffeb3eb9805bb0fa85d3076c

2360. By Francis Deslauriers <email address hidden> on 2020-02-13

Cleanup: move unused function to deprecated symbol list

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I9c75feee029364ab17ef3783a6c8f0d45ff2948b

2359. By Francis Deslauriers <email address hidden> on 2020-02-13

Cleanup: remove unused `__check_ust_safe_fmt()` function

Usages of this function were removed by this commit:
  commit 5e96a46756a5dcd6e348afd84078b9e26438245d
  Author: Mathieu Desnoyers <email address hidden>
  Date: Tue Aug 9 09:46:51 2011 -0400

      Add UST_DEBUG env. var. support

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I535028fc9338c0c2cef51a993bcab8f0e6c062c6

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers