lp:~lttng/lttng-ust/lttng-ust

Branch merges

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2506. By Mathieu Desnoyers on 2021-01-20

Fix: Use default visibility for tracepoint provider symbol

When building a probe provider `someprobe` with -fvisibility=hidden into
a shared library, the `__tracepoint_provider_someprobe` symbol is hidden,
which does not allow tracepoint instrumentation to link to it.

Fix this by using the "default" visibility attribute.

For a shared library built with -fvisibility=hidden, this changes the
output of nm for that symbol from:

000000000000417c b __tracepoint_provider_someprobe

(local BSS symbol)

to

000000000000417c B __tracepoint_provider_someprobe

(global (external) BSS symbol)

Fixes: #1296
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I308374f6cac58cca86e8eb19c872286a3da21a75

2505. By Jérémie Galarneau <email address hidden> on 2021-01-13

Fix: configure: support Autoconf 2.70

The newly-released autoconf 2.70 introduces a number of breaking
changes [1] and is being rolled-out by some distros.

Amongst those changes, the AC_PROG_CC_STDC macro is marked as obsolete
and was merged into AC_PROG_CC, which we already use. On 2.70, this
results in a warning which we handle as an error.

A version check is added to invoke the AC_PROG_CC_STDC macro only when
running a pre-2.70 version of autoconf, fixing the issue.

Also, the AX_PTHREAD macro makes use of the $as_echo built-in shell
variable which no longer exists in 2.70. A patch was submitted to the
GNU Autoconf archive in March, but there have been no signs of life
given since then [2].

As such, our local copy is updated to the latest version and the patch
(which looks fairly straight-forward / safe) is applied. This should
minimize changes once we go back to an "official" version of the macro.

[1] https://lwn.net/Articles/839395/
[2] https://savannah.gnu.org/patch/?9906

Signed-off-by: Jérémie Galarneau <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I2f4eac788638924aa4960b54374d09de73957925

2504. By Mathieu Desnoyers on 2020-12-18

Fix: event notifier create protocol order issue

sessiond needs to send the additional command payload before awaiting
reply from UST.

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I4d046e3fd2f334d728d4310ceb2b003f6bf0abed

2503. By Mathieu Desnoyers on 2020-12-17

Fix: lttng-ust 2.13 should not try to use notifiers from 2.12 or prior probes

Probe providers built against lttng-ust 2.12 or prior do not implement
the event notifier callback, and accessing desc->u.ext.event_notifier_callback
accesses beyond the size of struct lttng_event_desc.

Therefore, skip those older probe providers from the list of providers
considered for event notifications, and print an error when this
situation is encountered.

Currently, the error reporting of lttng-ust is performed through ERR(),
which is only observable on the console of the application when run with
LTTNG_UST_DEBUG=1.

Signed-off-by: Mathieu Desnoyers <email address hidden>
Reviewed-by: Francis Deslauriers <email address hidden>
Change-Id: Ia8a9bae1a471ae5d30ff0364b28e1cd3a8b4e396

2502. By Mathieu Desnoyers on 2020-12-17

Fix: UST comm protocol: event notifier command is too large

The event notifier command is larger than the current largest command,
and we don't want to break the protocol between UST and tools
needlessly.

Therefore, pass the struct lttng_ust_event_notifier _after_ struct
ustcomm_ust_msg.

Signed-off-by: Mathieu Desnoyers <email address hidden>
Reviewed-by: Francis Deslauriers <email address hidden>
Change-Id: Ief172eaddd113ec9092dd57bad3d73fd4c29fd51

2501. By Mathieu Desnoyers on 2020-12-16

Fix: incorrect parameters passed to vtracelog

The vtracelog APIs should be called from the vtracelog instrumentation
rather than the "tracelog" APIs, because it passes a va_list rather than
a variable argument list (...).

This can be verified by tracing the demo program doc/examples/demo-tracelog/demo-vtracelog:

Issue (corrupted trace output):

16:17:26.686073539] (+0.000000530) thinkos lttng_ust_tracelog:TRACE_ERR: { cpu_id = 2 }, { line = 31, file = "demo-vtracelog.c", func = "print_err", _msg_length = 49, msg = "This is a \"\b\" formatted 638975520 error event d68" }

Fixed:

[16:23:33.538189343] (+0.000000600) thinkos lttng_ust_tracelog:TRACE_ERR: { cpu_id = 3 }, { line = 31, file = "demo-vtracelog.c", func = "print_err", _msg_length = 52, msg = "This is a \"mystring test\" formatted 4 error event 42" }

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I330e339a3bf68fb8d9779bbc71b08c3bc033ac4e

2500. By Francis Deslauriers <email address hidden> on 2020-12-15

event-notifier: Initialize `_notifier_notification` struct to zero

Valgrind reports the following use of uninitialized bytes:

  ==2233138== Syscall param writev(vector[...]) points to uninitialised byte(s)
  ==2233138== at 0x4EA161D: __writev (writev.c:26)
  ==2233138== by 0x4EA161D: writev (writev.c:24)
  ==2233138== by 0x489A9EC: patient_writev (in /usr/local/lib/liblttng-ust.so.0.0.0)
  ==2233138== by 0x48C2D5F: lttng_event_notifier_notification_send (in /usr/local/lib/liblttng-ust.so.0.0.0)
  ==2233138== by 0x4033F3: __event_notifier_probe__tp___tptest (in /home/frdeso/projets/lttng/tools/tests/utils/testapp/gen-ust-events/gen-ust-events)
  ==2233138== by 0x401D6E: main (in /home/frdeso/projets/lttng/tools/tests/utils/testapp/gen-ust-events/gen-ust-events)
  ==2233138== Address 0x1ffeffedda is on thread 1's stack
  ==2233138== in frame #2, created by lttng_event_notifier_notification_send (???:)
  ==2233138==

Signed-off-by: Francis Deslauriers <email address hidden>
Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I49ac4b440df61b322ac9614b09c32d1f69beedd0

2499. By Mathieu Desnoyers on 2020-12-11

Add tests/unit/libmsgpack/test_msgpack to gitignore

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I8d838f961414ee996a4a63c9270fd26ef8ba0e02

2498. By Mathieu Desnoyers on 2020-12-11

ustctl.h: use enumeration values 0, 1 for bitness

Signed-off-by: Mathieu Desnoyers <email address hidden>
Change-Id: I915d3bad476f1b11b3c972f6bb60162f3f93d519

2497. By Mathieu Desnoyers on 2020-12-11

ust-abi: use 0, 1 for counter enumerations

Signed-off-by: Mathieu Desnoyers <email address hidden>